linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
To: Richard Weinberger <richard@nod.at>
Cc: linux-mm@kvack.org, linux-doc@vger.kernel.org,
	linux-kernel@vger.kernel.org, corbet@lwn.net, mhocko@suse.com,
	surenb@google.com, rppt@kernel.org, vbabka@suse.cz,
	Liam.Howlett@oracle.com, david@kernel.org,
	akpm@linux-foundation.org,
	Vladimir Davydov <vdavydov@virtuozzo.com>,
	Konstantin Khlebnikov <koct9i@gmail.com>,
	Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>,
	Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH] pagemap: Update BUDDY flag documentation
Date: Mon, 24 Nov 2025 10:51:03 +0000	[thread overview]
Message-ID: <ccd47ac6-439b-4c17-91fc-15c4f007af80@lucifer.local> (raw)
In-Reply-To: <20251122211920.3410371-1-richard@nod.at>

On Sat, Nov 22, 2025 at 10:19:20PM +0100, Richard Weinberger wrote:
> Since v4.6 the BUDDY flag is set for _all_ pages in the block
> and no longer just for the first one.
> This change was introduced by:
> commit 832fc1de01ae ("/proc/kpageflags: return KPF_BUDDY for "tail" buddy pages")
>
> Strictly speaking, this was an ABI change, but as nobody has noticed
> since 2016, let's just update the documentation.
>
> Cc: Vladimir Davydov <vdavydov@virtuozzo.com>>
> Cc: Konstantin Khlebnikov <koct9i@gmail.com>
> Cc: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Cc: Linus Torvalds <torvalds@linux-foundation.org>
> Signed-off-by: Richard Weinberger <richard@nod.at>

Good catch! LGTM, so:

Reviewed-by: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>

> ---
>  Documentation/admin-guide/mm/pagemap.rst | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/admin-guide/mm/pagemap.rst b/Documentation/admin-guide/mm/pagemap.rst
> index e60e9211fd9b2..c57e61b5d8aa8 100644
> --- a/Documentation/admin-guide/mm/pagemap.rst
> +++ b/Documentation/admin-guide/mm/pagemap.rst
> @@ -115,7 +115,8 @@ Short descriptions to the page flags
>      A free memory block managed by the buddy system allocator.
>      The buddy system organizes free memory in blocks of various orders.
>      An order N block has 2^N physically contiguous pages, with the BUDDY flag
> -    set for and _only_ for the first page.
> +    set for all pages.
> +    Before 4.6 only the first page of the block had the flag set.
>  15 - COMPOUND_HEAD
>      A compound page with order N consists of 2^N physically contiguous pages.
>      A compound page with order 2 takes the form of "HTTT", where H donates its
> --
> 2.51.0
>


      parent reply	other threads:[~2025-11-24 10:51 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-22 21:19 Richard Weinberger
2025-11-23  9:29 ` Mike Rapoport
2025-11-24 10:47 ` David Hildenbrand (Red Hat)
2025-11-24 10:51 ` Lorenzo Stoakes [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ccd47ac6-439b-4c17-91fc-15c4f007af80@lucifer.local \
    --to=lorenzo.stoakes@oracle.com \
    --cc=Liam.Howlett@oracle.com \
    --cc=akpm@linux-foundation.org \
    --cc=corbet@lwn.net \
    --cc=david@kernel.org \
    --cc=koct9i@gmail.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mhocko@suse.com \
    --cc=n-horiguchi@ah.jp.nec.com \
    --cc=richard@nod.at \
    --cc=rppt@kernel.org \
    --cc=surenb@google.com \
    --cc=torvalds@linux-foundation.org \
    --cc=vbabka@suse.cz \
    --cc=vdavydov@virtuozzo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox