From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2F331C433F5 for ; Mon, 14 Feb 2022 06:32:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A24EA6B0072; Mon, 14 Feb 2022 01:32:56 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9D3426B0073; Mon, 14 Feb 2022 01:32:56 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8C2646B0078; Mon, 14 Feb 2022 01:32:56 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0124.hostedemail.com [216.40.44.124]) by kanga.kvack.org (Postfix) with ESMTP id 7E2196B0072 for ; Mon, 14 Feb 2022 01:32:56 -0500 (EST) Received: from smtpin15.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 2E1C118135C5C for ; Mon, 14 Feb 2022 06:32:56 +0000 (UTC) X-FDA: 79140417552.15.7EB6413 Received: from mail-oi1-f169.google.com (mail-oi1-f169.google.com [209.85.167.169]) by imf04.hostedemail.com (Postfix) with ESMTP id 96B2840002 for ; Mon, 14 Feb 2022 06:32:55 +0000 (UTC) Received: by mail-oi1-f169.google.com with SMTP id t199so16348427oie.10 for ; Sun, 13 Feb 2022 22:32:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:in-reply-to:message-id:references :mime-version; bh=h0JP709O9eQRvYaHcZW5ywH5vkUoeEc9HEo34GT5kVU=; b=KM16yQHt1UQm3xp/rwQu+bJ+52ngVLufsAiYc2dhsQKBY+q32Fs12Vvrev/hiKkPCj yXJ/TWaG3C9z2O58D2cbi4+5wsJNFbflgCcSkMJeTyopITHZJXlKDNAvTy+0ZwxJPgwh J6LNq1E/USRp5cbW2XOAhcIjmIMumYGISzsMsEoKHi6t5Mt3LsPUwMcleFYJCHHS+cuC 4LoL0+A+shY1VtADWU6Vl6k3EmusJcOwANaUxeZTV+rkHBHnVjmFfLW276bwqaLNowbN GLh0oOqfHJaw6NpjDcRdnl24ka7nsy57bn/CtNJ7/vFAXdGt0X0aRGT+IlFrj7tSf8Fm T6PQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:in-reply-to:message-id :references:mime-version; bh=h0JP709O9eQRvYaHcZW5ywH5vkUoeEc9HEo34GT5kVU=; b=jf6L0AGoYMRWFWFF0Djau1IwDSo7jGvzvrOtpmdSQkpRX5sMJYkz9cfVkf3XlLBlEx t0QqFF85PoD+o9342je0eGtmuupIK79tK5JvKkrz0Hh2h/8zLWO57JOVHv4/VExFsfIw DXMN90RMF4ClWdXPlRURJeDuYG4GsvOg1O77J4w6o3f75jUCJToma6fCJOVJMCcxYSSu hhLDoLbn636BGxdFL3Yes0IpOzyv1Peof2hLaWL+nG/yID/uEKuC1chYnvcTaqm7U2A3 9pvPtByednw2B0UuEAF9Mu9yxwezVTmn1RoV7vhLYmjXJoa1vGoWJxztcCGGqO19a418 JFcQ== X-Gm-Message-State: AOAM530tXahnb/zofVP2ovj527a1KNm8QySVa9Yn233MAdoAsx1zBppO YwwpO+v8r4MpukoDX8TJbvbKNw== X-Google-Smtp-Source: ABdhPJzFXzAHk9ZZwaynAWPuynoSFRSx1RsMS+pBEAuMQDYHuypZzfpc3gGQx4JMklT3Je0tfBl5Vw== X-Received: by 2002:a05:6808:2112:: with SMTP id r18mr4983152oiw.20.1644820374805; Sun, 13 Feb 2022 22:32:54 -0800 (PST) Received: from ripple.attlocal.net (172-10-233-147.lightspeed.sntcca.sbcglobal.net. [172.10.233.147]) by smtp.gmail.com with ESMTPSA id x17sm12066099oop.1.2022.02.13.22.32.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 13 Feb 2022 22:32:53 -0800 (PST) Date: Sun, 13 Feb 2022 22:32:41 -0800 (PST) From: Hugh Dickins X-X-Sender: hugh@ripple.anvils To: Vlastimil Babka cc: Hugh Dickins , Andrew Morton , Michal Hocko , "Kirill A. Shutemov" , Matthew Wilcox , David Hildenbrand , Alistair Popple , Johannes Weiner , Rik van Riel , Suren Baghdasaryan , Yu Zhao , Greg Thelen , Shakeel Butt , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 07/13] mm/munlock: mlock_pte_range() when mlocking or munlocking In-Reply-To: <2ec49f65-fe4e-26a0-4059-c18e6dab0af4@suse.cz> Message-ID: References: <8e4356d-9622-a7f0-b2c-f116b5f2efea@google.com> <8bc3ee8c-7f1-d812-7f22-4f9f6d436bc@google.com> <2ec49f65-fe4e-26a0-4059-c18e6dab0af4@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 96B2840002 X-Stat-Signature: 3ssynfae649ujs4jyf6bckrrty4kdyz9 X-Rspam-User: Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=KM16yQHt; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf04.hostedemail.com: domain of hughd@google.com designates 209.85.167.169 as permitted sender) smtp.mailfrom=hughd@google.com X-HE-Tag: 1644820375-959426 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, 11 Feb 2022, Vlastimil Babka wrote: > On 2/6/22 22:42, Hugh Dickins wrote: > > @@ -162,8 +230,7 @@ static int mlock_fixup(struct vm_area_struct *vma, struct vm_area_struct **prev, > > pgoff_t pgoff; > > int nr_pages; > > int ret = 0; > > - int lock = !!(newflags & VM_LOCKED); > > - vm_flags_t old_flags = vma->vm_flags; > > + vm_flags_t oldflags = vma->vm_flags; > > > > if (newflags == vma->vm_flags || (vma->vm_flags & VM_SPECIAL) || > > Nit: can use oldflags instead of vma->vm_flags above? Yes thanks, that is nicer, I'm making that change now. Hugh