From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 43A04C7EE22 for ; Mon, 8 May 2023 17:21:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8ACCE6B0071; Mon, 8 May 2023 13:21:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 85D266B0074; Mon, 8 May 2023 13:21:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 74D0A6B0075; Mon, 8 May 2023 13:21:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 693C96B0071 for ; Mon, 8 May 2023 13:21:22 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 34E64C0378 for ; Mon, 8 May 2023 17:21:22 +0000 (UTC) X-FDA: 80767754004.03.725003E Received: from mail-lf1-f43.google.com (mail-lf1-f43.google.com [209.85.167.43]) by imf04.hostedemail.com (Postfix) with ESMTP id 16CD740008 for ; Mon, 8 May 2023 17:21:19 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=VsL5h7zK; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf04.hostedemail.com: domain of toiwoton@gmail.com designates 209.85.167.43 as permitted sender) smtp.mailfrom=toiwoton@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1683566480; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=EGF9Bdb9JOj4ZKrCw770yZ6qanDIda3Of6R8VUahyS0=; b=MtCG9Rwuvr+ILr0vpH1V1O8Bttt97KVf0KlZWIJGkyQDxDEsn+jQO/PPKJDovPpeV3N6gl 0COS/F0ajHudmkOyJqsvc0nh3Z1Xq9H8I3wL7XGlfy8THeUOjALu2uYfrCxECeT2axGWlA kVty8LJhCmhczBGsnFFtdCU1xlVNY20= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=VsL5h7zK; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf04.hostedemail.com: domain of toiwoton@gmail.com designates 209.85.167.43 as permitted sender) smtp.mailfrom=toiwoton@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1683566480; a=rsa-sha256; cv=none; b=TidN6i6vHVKDjhloFUMSsuFHwxZOs0fiwFE0NHmeNm3789OkNpI59QsnS+zW61n9HSBZTm CSNomjgORLZBmmFt9OwF+4g85fnXZXnweAfuwejwTPPx+sDnc/XiD1mXN6nF9chjKHlA78 ziq3A7lGSjhBP1jwFk36Ix07tnZNZ3Y= Received: by mail-lf1-f43.google.com with SMTP id 2adb3069b0e04-4efe9a98736so5485341e87.1 for ; Mon, 08 May 2023 10:21:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1683566478; x=1686158478; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=EGF9Bdb9JOj4ZKrCw770yZ6qanDIda3Of6R8VUahyS0=; b=VsL5h7zKMPs8Q7T4GaqwhDe0M3SaDXdFdUp6gR7o664fIAPEUCyV4Pb43Dop55RNHW glHp7weXenZXMh3BaH58FJFUqVqai1vYkHY8etK5czOgBN1DF7ZdeHFjbrtXxnSBPc34 ZhIfEhIMdAp4NiLuRxnfsUbijWeh/sCfaAmSs5ACwdAK9gHubvuib0vBx1Z2bxy+nLdW kLclBgUmwJTKHrjSttIkZKLk9pk7DwByR12vZYsWO+cCX/rVi4setysscov+Xh9WNiwN PyawKVKMWGZvrZgFhWLo5SYYSrRwrGuf6LfBrmtZVSPWjZqW5+elTXznLSDBfT49uaoe lpBQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683566478; x=1686158478; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=EGF9Bdb9JOj4ZKrCw770yZ6qanDIda3Of6R8VUahyS0=; b=TkJOcSUVhiZ7uwev1Kdcg+WWe9UJjdIQlJFw0IYJDWy2Rt8tntmchHtg+B2htQurh5 IanCpsWSjfcfNDL8DMNwXr6PyDyNyKceqXOlWMSfTUo/Dhuwzm3a88do4RnC/VftWT3J fOmzzZnZQlE4bBou3syG/VfCYo0PhG9TQzyBdEyj7ncSL2bcI/zFI7jRsQfRW/f+t76L yiGWqlatUi168PrnTVuPUBhKyad/QqhYGMfUEaivBZL3Lp6uXM+a5/1lv2CjU50wRCQB 2IXsIi1ndAsU1yCgT6GRmX7k3kgowNuify1NwTh2X0L6OVknAzKrEY31QSfVu/ROVhY/ fyRA== X-Gm-Message-State: AC+VfDwXs++4FCwHYDbP7H68raf5/cuFXnfYfhrvZTMp5CWcFv3NrIQO ooGMpV7pNYUKnoqHOhd/PAw= X-Google-Smtp-Source: ACHHUZ4dVI80FNEX6T5ejMuHXHeThUuqEEjmxZ8iOPMrmvM3U8wzY3U13oIxVMuR6XBI1z9RVavMfA== X-Received: by 2002:ac2:44a6:0:b0:4ea:e0e7:d12d with SMTP id c6-20020ac244a6000000b004eae0e7d12dmr2617051lfm.1.1683566477979; Mon, 08 May 2023 10:21:17 -0700 (PDT) Received: from [192.168.1.12] (81-197-197-13.elisa-laajakaista.fi. [81.197.197.13]) by smtp.gmail.com with ESMTPSA id q5-20020ac25fc5000000b004f1477cf8a7sm50172lfg.115.2023.05.08.10.21.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 08 May 2023 10:21:17 -0700 (PDT) Message-ID: Date: Mon, 8 May 2023 20:21:16 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH 0/4] MDWE without inheritance To: Catalin Marinas , Florent Revest Cc: Peter Xu , linux-kernel@vger.kernel.org, linux-mm@kvack.org, akpm@linux-foundation.org, anshuman.khandual@arm.com, joey.gouly@arm.com, mhocko@suse.com, keescook@chromium.org, david@redhat.com, izbyshev@ispras.ru, nd@arm.com, broonie@kernel.org, szabolcs.nagy@arm.com, lennart@poettering.net References: <20230504170942.822147-1-revest@chromium.org> Content-Language: en-US From: Topi Miettinen In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 16CD740008 X-Rspam-User: X-Stat-Signature: qp3zyouuwuynj956quaqi6udfptsam1y X-HE-Tag: 1683566479-325009 X-HE-Meta: U2FsdGVkX18Yc0hH1bRJYtGrgbS/WkgP5g4POCPWtBxXwdJrsmx4Bmi4YC0QheJ99EEEJfzkMZoy5vxa14CbX6tMHm8GtnbRvOsyaJ/I9aFqOKasf8jqh2BVTqMMazSO8Kw9gfEAqpXBkP6Wyhh/UHjhfj3uwgNGkIYLbUKyJVSowOs63rLb3c1dsZjpKNd/EMwVVQrTv/hAdectP5+KVYYTUG34RhN2BckDqbjf6o/sD/li+HXEaqVO/QmOcaE9MTMVburfL3zhIhcgoOVjX7tvpNLX9pO6VNbDxeWVYnbR8mXzqeatTDQX6zLlAy9qDSYuKredC42tU5F4VB0ozLMO3rdV6TGCbP0Z3y8rDKYPXqpZPIBMibHNICpA7Mz6ABXh5SvNu40EqfqgazSPPmpX2sjO9SuQHkEqNrkvQ1kHX9Jnify9lLBy3sDCs27/FAdJlyT7lvbftnwANmpBw/HTJQQ3jmTb5z6gde8YZzv/eZY11A31jUM3ElD6S4BhSdq7AWw7+s9IQI4aH8uTQlhEL27luiVTzekPgbGuHEEc87+lmDYQPDQ8auRo1lhACG5VbAfIwM+m6MNt0y2rIgH/f8DPYd2drVxuibetSwnFxTY1PFummFoXYMqqg/mUEhbnwlZvS7RufdlHfyyEjunNnKPjpfgj2P231QCTmuKwBE4vfTX3nRUFXt9OFioM2xLhp+pwLNQ1hHUdEs/g7H9VHeSl0qWbzfkA/Yp3uSazlSPCEc79DrvwcFx0pYPiQgT2BEn1lx0vX0V9zvvvPSCHQyO2UjRNhQhAuJRKU7g7O0d97hLG5OXBKwtoS5VGmUHzvxELHmqLvYggSUsOG9Z489RY76KQykM9IBmHuO9WyEbwI8ikFAvnMCI5BzZ0mGqdEVj4palOH4BpfNI3SfTVfQYJC7qK8fH1BphNJbdv8Q3i5yz5Q1JE1mfLbcOw0gaNlyXuC+iuyN+PHSM QF9o3byg d5FKeCPlq8J6mNPrSDKr2RNLdv/WECex6A5vGHRgHIeNV98I6rQy6YG6w8NM60TVFmDMGs8VCKff6PAG1frqXkfK069oEqgGlw8KJskUoAlZ/DKUwnFaKstX5cI8NETEc4QhGiFMgvFbhemEDk0JL2mLkR9YwiWOKsDlvNZGee+XO3m/1urNIhR4nC17jLAJ2mYd9rr+ePDvqXbluhb14sxYtforYcUXnJDy83pEMQE5zH77q09RKvhk1PPf2mHdZk6YdVwWUHJ9T9wCGVPHZVQL6wvF2DaKlV8utJypQaODxWWLDrXiqrv/l0VKSd1wbZ231f6PGE5RxrRu99bLYBDFIElslRRBcXii0YPfjaE4qJFtPjAbRv/56HqttQkZB68Cd3a3jINxojcDyNfBKmpuXSZs1bDXyvk7/hMCTMzVexCcvGY0HwBNBeg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 8.5.2023 17.10, Catalin Marinas wrote: > I think we should keep the original behaviour of systemd here, otherwise > they won't transition to the new interface and keep using the SECCOMP > BPF approach (which, in addition, prevents glibc from setting PROT_BTI > on an already executable mapping). Systemd has transitioned to prctl(PR_SET_MDWE) method since release of v253, so the original behaviour definitely should be kept. > To me MDWE is not about preventing JITs but rather ensuring buggy > programs don't end up with WX mappings. We ended up this way because of > the SECCOMP BPF limitations (just guessing, I haven't been involved in > its design). With a no-inherit MDWE, one can introduce an additional > policy for systemd. It would be a sysadmin decision which one to enable > and maybe current (inherit) MDWE will disappear in time. There could be a new setting for this, like MemoryDenyWriteExecute=no-inherit. I'd only use it for those special cases where MemoryDenyWriteExecute=yes can't be used. > x86 has protection keys and arm64 will soon have permission overlays > that allow user-space to toggle between RX and RW (Joey is looking at > the arm64 support). I'm not sure how we'll end up implemented this on > arm64 (and haven't looked at x86) but I have a suspicion MDWE will get > in the way as the base page table permission will probably need > PROT_WRITE|PROT_EXEC. Wouldn't those features defeat any gains from MDWE? The features probably should be forbidden with MemoryDenyWriteExecute=yes. -Topi