From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F0F2EC3DA7A for ; Thu, 5 Jan 2023 09:04:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 779208E0002; Thu, 5 Jan 2023 04:04:22 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 72A6A8E0001; Thu, 5 Jan 2023 04:04:22 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5F20D8E0002; Thu, 5 Jan 2023 04:04:22 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 518608E0001 for ; Thu, 5 Jan 2023 04:04:22 -0500 (EST) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 28D4A80D34 for ; Thu, 5 Jan 2023 09:04:22 +0000 (UTC) X-FDA: 80320159164.04.EECE723 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf20.hostedemail.com (Postfix) with ESMTP id 1EE5F1C0016 for ; Thu, 5 Jan 2023 09:04:19 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=TwNLaJ2E; spf=pass (imf20.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1672909460; a=rsa-sha256; cv=none; b=fw3X+jeLs4FPTThTktnA1yIBZYz27VV3oA05GOT/24YR/Uw7ZH1yBXdjK12iZs1J/e2Wa+ FeJKW07pZfOiQdGMlqsrHNzbrdroV2LfUJdh1qWZTQr5osjS5WzpQM5tM8kod6BguJV7v7 rO9q984+tA47T7/q8fB//WvQBzTWDcI= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=TwNLaJ2E; spf=pass (imf20.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1672909460; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Gex+QnT4hwAgx1h+eIu+UAUxgiKZCLZj1HYsXCJOojw=; b=Bj/DSgZkqW1fBfXlB3D33bazROhgDi0dYN8uEdsaLsGPcwPJtDduVkR4QMmNYhwbIZ+POz js9HG6ok3chzCDrqo9wqA7bIsIdENv38C6I0huRaLw+ZTrCg8vp29uBkfi8HwedeBMRT7E 7Bm01ysa32oC+NiaRGrhDX3060uAvXs= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1672909459; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Gex+QnT4hwAgx1h+eIu+UAUxgiKZCLZj1HYsXCJOojw=; b=TwNLaJ2E+kzMljcRBJz3BZP7GNKNrDqA6D2jFdanMzGCm0+QTcVS5qUkkpbiQLSMcnRHGw fHuyD2Gp2uvSvUXgAR18HkjKg6RklP4G1cMiuLhXjzWHLcHFMmQKORy97YBf8UrkPxqoBN JldykU/TPAF3tFRqpkVGlcIFAh92gcs= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-15-Spo-4oCjP-yDxzHtWWPKOQ-1; Thu, 05 Jan 2023 04:04:17 -0500 X-MC-Unique: Spo-4oCjP-yDxzHtWWPKOQ-1 Received: by mail-wm1-f70.google.com with SMTP id c23-20020a7bc857000000b003d97c8d4935so15178258wml.8 for ; Thu, 05 Jan 2023 01:04:17 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Gex+QnT4hwAgx1h+eIu+UAUxgiKZCLZj1HYsXCJOojw=; b=j8TPMPWivO6ivXU7+PrU/o62fxjOL12uSGOSHPtdC9DPRbP2uEYlsmirwqvHHZ7pmp J2g7/7AVipPDrUqoKBl+vxllyYiFWpYPjWensAlXX145qcUS0ZAVwyGKxDtJDIhVfJS4 PigEztR2Q8e60kUvvO9/Sq9fMFK7sCTs+hxt2GLKXsowRIoIGqBrIRUj7ZqLt2KyzbI5 c/BmZ3r+dhk5D38RAHn1nJL8km6/7Hm9OiFg3cEDyUb7gwrO/BMYizNVmCUq/NRV4YWy vVDer3xaW3NGH6qKlMifCDDOfJ0srBY3wL2yOzxk/49e5eYOyOS1DoX2xq6xR/3TVrYW lTbA== X-Gm-Message-State: AFqh2kp5Ol+vqLX/TtiBHuraawVmKl4kB7e6XhULe/Mk2x0oEKy835F+ WpxSf3iva1rCvDPdwbGaGj13HN7sf0feiYl8XN/zcpWHUHdjhLq2O84UUHcM+x27slKZsJgWISV H8v3NYsEcRU8= X-Received: by 2002:a05:600c:3d11:b0:3cf:8b22:76b3 with SMTP id bh17-20020a05600c3d1100b003cf8b2276b3mr36164735wmb.0.1672909456588; Thu, 05 Jan 2023 01:04:16 -0800 (PST) X-Google-Smtp-Source: AMrXdXvE4YV6gmwoMdYh7/YQCeNZ3S6PGe2qC4e43M/dqNDy8OkC6hj8sgg2g/J5YgDEpskNAkF9hw== X-Received: by 2002:a05:600c:3d11:b0:3cf:8b22:76b3 with SMTP id bh17-20020a05600c3d1100b003cf8b2276b3mr36164714wmb.0.1672909456272; Thu, 05 Jan 2023 01:04:16 -0800 (PST) Received: from ?IPV6:2003:cb:c707:6e00:ff02:ec7a:ded5:ec1e? (p200300cbc7076e00ff02ec7aded5ec1e.dip0.t-ipconnect.de. [2003:cb:c707:6e00:ff02:ec7a:ded5:ec1e]) by smtp.gmail.com with ESMTPSA id n126-20020a1ca484000000b003d21759db42sm1717113wme.5.2023.01.05.01.04.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 05 Jan 2023 01:04:15 -0800 (PST) Message-ID: Date: Thu, 5 Jan 2023 10:04:14 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH v2 1/1] mm: fix vma->anon_name memory leak for anonymous shmem VMAs To: Suren Baghdasaryan , akpm@linux-foundation.org Cc: hughd@google.com, hannes@cmpxchg.org, vincent.whitchurch@axis.com, seanjc@google.com, rppt@kernel.org, shy828301@gmail.com, pasha.tatashin@soleen.com, paul.gortmaker@windriver.com, peterx@redhat.com, vbabka@suse.cz, Liam.Howlett@Oracle.com, ccross@google.com, willy@infradead.org, arnd@arndb.de, cgel.zte@gmail.com, yuzhao@google.com, bagasdotme@gmail.com, suleiman@google.com, steven@liquorix.net, heftig@archlinux.org, cuigaosheng1@huawei.com, kirill@shutemov.name, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, syzbot+91edf9178386a07d06a7@syzkaller.appspotmail.com References: <20230105000241.1450843-1-surenb@google.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20230105000241.1450843-1-surenb@google.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Queue-Id: 1EE5F1C0016 X-Rspamd-Server: rspam01 X-Stat-Signature: 9fkadropxm8sqdm5jkbye656zziucope X-HE-Tag: 1672909459-265758 X-HE-Meta: U2FsdGVkX1+2WQM4t3FApE1ZFPMCBokwVjqpPbCL3mMU7MkqhiBrDZx53vVu+ghLP0wJ/8JkDATFGQMdRf4on21TYuenZBG2fX4Ikq5G/KLM3GnYK00u5z3upGEVwHzBju7qYOeQnn3BIbMhkJQZGpCSLman1+sVS9zyJu7QXUi845rvuFu7HSWRPwOw+JDTkTEImTF0/rZzyQ1sb6NZ0lXZyOOH3/NW7oAnKaowLx1vWJ0Af1BrfsHIL4JOHA/26uPh4o0VeNZrjj1PEaIgC27shBDRVVTfRHmzW1jZAe4muYhZWHBdlx9436MlQgxZQSzGYPW/DznVEOkQOcHmeYVoblhzf9xUBY1ejuKeDkFcaHFxUqigVYQgmn6cR8jRrZC/1c08Zr8CXPCt00Xq4X59Q8pZBgiKjdzB4UBP6mpYjz1ZY7jwGYHXbT08KB//5vUeQ+LrrFzD7eEDYeIAcc9WYBCVV7NgBF0/MySLjNjlBBWMPnuRzwvedMeSI39BMxCKIMJxtpfqIq4TU0NWpBieG64HLS6387blRWk1Gy4XfIvG9pM0I2to8CcGDNkSx3j42Snh4GTxHN+/1pUi65udrUy3mnRlPqdoFCFa5hNL6QnDXFMAsg0xpRduG0vR6gPW82Z020BvBzuov7nU1ZFZJMDazg19p5U4ptd6QDHTjOCNkSYYi7VQFzZ6Q19rLYT7xjeT9GLWt9+GiOVQnyxygBAN7IBhD9rKuclpe+EtHLKZhyNVNFWF4n3cPxlcSONRWPGUfAd0/psuuMbZwKjICGr8hTjtnJ76D5Spg62Q23BbVNMGDKQYdgixgiMGAjOjB0VS7F3XIv6UOhbYphZVUZ4r/NmMAI25gQaUCP8yETkrqTWu5QNTu67niH9aOjIh3J9gCC+lJ4XVuwnLb53ypuZaXhj+Pnl7bfKXks/7NlqTeimz2/l7alyC08oMuMRniwIs4vfIK7ehzb7 ANdOwNQp LYHhMMUbvoJcDofC3c2e++eYXvvxHu7cu/hGiL9PKld2EhwBQEMKPE7sSAFVCb9PKXUNwhaR3hlQXvYhCrGs3YPz8vQvUZMT5iMMoPVVmN+so1ers8VG7QIPUfANxeQceQAnTt0ZM3mu20VtOMboPcElimTjTlewY0luJHkJ+ASJCL3smHISkKuU0UK8t3jNLabCRtv4nz3dsXyyXdWFxw0HpDpcuVDUZ18VSXA4wyKXfI+K0bLB+rKuprfdyd64mA80qyc669z0C0nnpKMvBoGKCyAq7MeI4j1Ma X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 05.01.23 01:02, Suren Baghdasaryan wrote: > free_anon_vma_name() is missing a check for anonymous shmem VMA which > leads to a memory leak due to refcount not being dropped. Fix this by > calling anon_vma_name_put() unconditionally. It will free vma->anon_name > whenever it's non-NULL. > > Fixes: d09e8ca6cb93 ("mm: anonymous shared memory naming") > Signed-off-by: Suren Baghdasaryan > Suggested-by: David Hildenbrand > Reported-by: syzbot+91edf9178386a07d06a7@syzkaller.appspotmail.com > Cc: David Hildenbrand > Cc: Hugh Dickins > Cc: Pasha Tatashin Reviewed-by: David Hildenbrand -- Thanks, David / dhildenb