From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 26867C433EF for ; Tue, 30 Nov 2021 01:41:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5BE696B0071; Mon, 29 Nov 2021 20:41:03 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 547156B0072; Mon, 29 Nov 2021 20:41:03 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3C0A36B0073; Mon, 29 Nov 2021 20:41:03 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay034.a.hostedemail.com [64.99.140.34]) by kanga.kvack.org (Postfix) with ESMTP id 2BB206B0071 for ; Mon, 29 Nov 2021 20:41:03 -0500 (EST) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id F23D720C14 for ; Tue, 30 Nov 2021 01:40:52 +0000 (UTC) X-FDA: 78863892744.01.094F4C9 Received: from out30-45.freemail.mail.aliyun.com (out30-45.freemail.mail.aliyun.com [115.124.30.45]) by imf02.hostedemail.com (Postfix) with ESMTP id 39C12700178D for ; Tue, 30 Nov 2021 01:40:47 +0000 (UTC) X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R921e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e04400;MF=baolin.wang@linux.alibaba.com;NM=1;PH=DS;RN=6;SR=0;TI=SMTPD_---0UyoPEMz_1638236446; Received: from 30.21.164.33(mailfrom:baolin.wang@linux.alibaba.com fp:SMTPD_---0UyoPEMz_1638236446) by smtp.aliyun-inc.com(127.0.0.1); Tue, 30 Nov 2021 09:40:47 +0800 Message-ID: Date: Tue, 30 Nov 2021 09:41:38 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.3.0 Subject: Re: [BUG] hugetlbfs: Fix issue of preallocation of gigantic pages can't work To: Zhenguo Yao , mike.kravetz@oracle.com, akpm@linux-foundation.org, mlevitsk@redhat.com Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org References: <20211129133803.15653-1-yaozhenguo1@gmail.com> From: Baolin Wang In-Reply-To: <20211129133803.15653-1-yaozhenguo1@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 39C12700178D X-Stat-Signature: n81yhcp8odoc9ioncm5qdstcrtuxq4ww Authentication-Results: imf02.hostedemail.com; dkim=none; spf=pass (imf02.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.45 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com; dmarc=pass (policy=none) header.from=alibaba.com X-HE-Tag: 1638236447-53765 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000212, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi, On 2021/11/29 21:38, Zhenguo Yao wrote: > Preallocation of gigantic pages can't work bacause of commit:b5389086ad7b > (hugetlbfs: extend the definition of hugepages parameter to support node > allocation). When nid is NUMA_NO_NODE(-1), alloc_bootmem_huge_page will > always return without doing allocation. Fix this by adding more check. > > Signed-off-by: Zhenguo Yao You should add a fixes tag, otherwise LGTM. Reviewed-by: Baolin Wang Fixes: b5389086ad7b ("hugetlbfs: extend the definition of hugepages parameter to support node allocation")