From: Baolin Wang <baolin.wang@linux.alibaba.com>
To: Zhenguo Yao <yaozhenguo1@gmail.com>,
mike.kravetz@oracle.com, akpm@linux-foundation.org,
mlevitsk@redhat.com
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [BUG] hugetlbfs: Fix issue of preallocation of gigantic pages can't work
Date: Tue, 30 Nov 2021 09:41:38 +0800 [thread overview]
Message-ID: <ccb002e0-7ea6-5289-0f01-48f1a23eaf46@linux.alibaba.com> (raw)
In-Reply-To: <20211129133803.15653-1-yaozhenguo1@gmail.com>
Hi,
On 2021/11/29 21:38, Zhenguo Yao wrote:
> Preallocation of gigantic pages can't work bacause of commit:b5389086ad7b
> (hugetlbfs: extend the definition of hugepages parameter to support node
> allocation). When nid is NUMA_NO_NODE(-1), alloc_bootmem_huge_page will
> always return without doing allocation. Fix this by adding more check.
>
> Signed-off-by: Zhenguo Yao <yaozhenguo1@gmail.com>
You should add a fixes tag, otherwise LGTM.
Reviewed-by: Baolin Wang <baolin.wang@linux.alibaba.com>
Fixes: b5389086ad7b ("hugetlbfs: extend the definition of hugepages
parameter to support node allocation")
next prev parent reply other threads:[~2021-11-30 1:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-29 13:38 Zhenguo Yao
2021-11-29 20:58 ` Mike Kravetz
2021-11-30 1:41 ` Baolin Wang [this message]
2021-11-30 2:33 ` Muchun Song
2021-11-30 7:48 ` Maxim Levitsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ccb002e0-7ea6-5289-0f01-48f1a23eaf46@linux.alibaba.com \
--to=baolin.wang@linux.alibaba.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mike.kravetz@oracle.com \
--cc=mlevitsk@redhat.com \
--cc=yaozhenguo1@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox