From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B947C71157 for ; Tue, 17 Jun 2025 14:04:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D17D06B0092; Tue, 17 Jun 2025 10:04:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CC86B6B0093; Tue, 17 Jun 2025 10:04:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BDED16B0095; Tue, 17 Jun 2025 10:04:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id AEC306B0092 for ; Tue, 17 Jun 2025 10:04:35 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 56BC21A0326 for ; Tue, 17 Jun 2025 14:04:35 +0000 (UTC) X-FDA: 83565062910.13.E222C27 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf16.hostedemail.com (Postfix) with ESMTP id 70A23180019 for ; Tue, 17 Jun 2025 14:04:32 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=chMDOGdA; spf=pass (imf16.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750169072; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=mvDC1nx99PBAn05PNx0i2guL0ZWIOt26UDKBU6S0cf8=; b=4Q8YPpGKFRIpPliBJHPnKgm7hefs7gdVzpuy8dQfvdCzanEtBPChXJmj2jfR5BxFZETpna aMJ/5Lj0eQbyH446EFfX3/emTgbtAoT/phvmtXLDkLW8vHPMIU5G+e6JRVXwqsFeOHSu4L QfqOtxIJVfOIbKHLmhLN3ODaL0LKtl0= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=chMDOGdA; spf=pass (imf16.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750169072; a=rsa-sha256; cv=none; b=6LraZpD/UVNimZmfaV7I3g6ah1h1HfqUrkBLcptQDxAjonVmhCzDeyghi3ATYQDbY+ETf+ XK3DbQKeqGqu4szJ+haG+BLCLb/oUyik48nHseoneQOoi80ttcy0I/SSw4dn2GwJc1hFFf Xi4RYn4K6VACAeE1eBJ7K1BOuIP0tV0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1750169071; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=mvDC1nx99PBAn05PNx0i2guL0ZWIOt26UDKBU6S0cf8=; b=chMDOGdApC0AI3xXa7RGA1NUjds7WByt5dpq4PrY5MXI61eLGteYzrOW/ntYFXUNn/WqK9 +0kuIxB3cR28gLfz3F+nUe+o47Ht0/+JaFhQJpN2mQOnZlXcyMe+TbcyoTiqI7iyHQVmwi ln+M7Xfgcm/sLBtgdDuUNP1wLMI2550= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-48-XLX_AmekMii3JNKXDo_ZjQ-1; Tue, 17 Jun 2025 10:04:30 -0400 X-MC-Unique: XLX_AmekMii3JNKXDo_ZjQ-1 X-Mimecast-MFC-AGG-ID: XLX_AmekMii3JNKXDo_ZjQ_1750169069 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-450df53d461so47357285e9.1 for ; Tue, 17 Jun 2025 07:04:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750169069; x=1750773869; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:from:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=mvDC1nx99PBAn05PNx0i2guL0ZWIOt26UDKBU6S0cf8=; b=uuJm8SOVthrv8+KUdWrJ/ri/qlnJlcDtZ/7LatTUhXFP6fYtXdGmfWQz4rTGR//IL2 HyTUa3VZDht1cQP3px5GfEomyNcPR0qbo1QWo78567gqcHsIP+B3Q5Og7xTTYd/9ZKOc IpnrUR9ibPqO5L0EzYFCO9kiyZ6kVtOkizj0raxaKoqCP3S9Y/IVDyabbZO/RIpmMdc0 tIL4MuDP6AZ/ObsS60kYtepKCOVmiiie9rrEuTfK5LTWR/AQw0c0lnqG+53tsbIm5b77 S1oqdgDZs3BgIRAERFHB3X1dVkMqIl+Z2Ab39Biow+Nfm8ACO/pm8DLDv1uKmKofUaUS yceQ== X-Forwarded-Encrypted: i=1; AJvYcCUXDExF5GfbUDLtu1vVq/PDArm9jAd0Wn1XviUfJSvP3es3GXKRIhcAauN08dkeuStdE8wbjVFdxA==@kvack.org X-Gm-Message-State: AOJu0YzdcWzUVCwyJyZXR+3W4bwYP3Ay3iHxapGzmltJdp1YLUARaipr TVqV73QtSBwE2/gALp3abyCguNGSa4SvDcLMlRXkbBsfGN32pJLji/hUbuQbT65kaxfFWgPbSJk durXG36BkxfOkJSjOHo0w6sdyDU95IoMYJkFzj3yiAIUMlMlq1gHn X-Gm-Gg: ASbGnctaMZfpQEQqC5gTZzsx6PN38Hgms9U0rTG89Rx0plofwaUqZ4gh4m6ddMHGtO5 7xm2iJqIojOpgJoEkPsvRFZ1I8RY5SgQOexcZ+k/FrRbCfl0ITjzogVK6BasqwlPjmS9CfpCCFV B3imAf9QKklLYNTJiAkMsknTtuzcgm7IOLgsba23/fN074X/zV3pnSUT0tzmHoRmEdo7H6kPaEg Vc/C+oHaEYU+4pweyDpRMBa9pRcMy+1VYltRTJQj5pL+jAMJAONQ7tdXWBjB7c6tnkPW9gu16Vr 5JOGgrEA6NG9qhtkN2Uzo8d51glmyeoXgcqmP15oz2zghB46n6ORF5rwsyCcOoRqq4ipqm+8qo6 RJVPySsOqT6fKuhXETgRmCf231mJI4OIM8ySXaTEmQ5yuc6Y= X-Received: by 2002:a05:600c:4f95:b0:450:d01f:de6f with SMTP id 5b1f17b1804b1-4533ca84626mr152306665e9.15.1750169068350; Tue, 17 Jun 2025 07:04:28 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGWvx+VbLkHVGiv9bP6lMEQVN/ySPOrPeOw2lBtXxzJFFJl30SyEGfTKNbFaHIi3jpkOPlwSw== X-Received: by 2002:a05:600c:4f95:b0:450:d01f:de6f with SMTP id 5b1f17b1804b1-4533ca84626mr152305495e9.15.1750169067621; Tue, 17 Jun 2025 07:04:27 -0700 (PDT) Received: from ?IPV6:2003:d8:2f31:700:3851:c66a:b6b9:3490? (p200300d82f3107003851c66ab6b93490.dip0.t-ipconnect.de. [2003:d8:2f31:700:3851:c66a:b6b9:3490]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a568b08dfesm14318806f8f.60.2025.06.17.07.04.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 17 Jun 2025 07:04:27 -0700 (PDT) Message-ID: Date: Tue, 17 Jun 2025 16:04:26 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 2/3] gup: introduce unpin_user_folio_dirty_locked() From: David Hildenbrand To: Jason Gunthorpe , lizhe.67@bytedance.com Cc: alex.williamson@redhat.com, akpm@linux-foundation.org, peterx@redhat.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org References: <20250617041821.85555-1-lizhe.67@bytedance.com> <20250617041821.85555-3-lizhe.67@bytedance.com> <20250617134251.GA1376515@ziepe.ca> <460e16a0-c8d9-493a-b54f-2c793c969eb1@redhat.com> <21958961-259f-4520-ae60-e234383945d7@redhat.com> Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <21958961-259f-4520-ae60-e234383945d7@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: KDL3VS2CilXU9TXEo-YoVa-cUfdEtju73XvMx9BVHho_1750169069 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 70A23180019 X-Stat-Signature: 9fb7ykax4r15urxkbek77pafm3nni56a X-HE-Tag: 1750169072-227125 X-HE-Meta: U2FsdGVkX1+G6StNRrIi/5Xx77yIei1rGN4K0f7/dslf/b+8hj0Q2cjuCXJ0T0G/idevl3tyq6p1WRzSIF4fd5xRzKqYvljgVw81mF9WJFaSnl9iSh4tfIl3cHlEEC3JIJ7t8NpD6zaoUjGiGJbvctPhWrHMruuaPWpOhkuZQchKUkEGYl2/rJwX7mN7htxKVLle0UHqqpczg4md+bzR+Y5gj2sz2RxBwGAcyadZ8/kybp0FS8Q2K/4cW0GNia/IelDt8osGgsva267wMeYM9AQKzKAxIrZsMi7As3bO8oBnt/tzhm0PH5JxkZrJxInp+JALt6NBBhGgBSsn+qqutn8DqjYjFz9EHig9FS7WBVsshkeKhniB/msZxNi7VWnOijL8TIa9pnG7GgJG5R0v8uiv+4yR5P0nSAL77VBIuNOfrn5wSns0wWgI3zkXvlWtzaVCCjTBdJDGBZfmlqXrvhH9RTCSrYI4V+TKWFRst3G6tCR/TBB9rOhHL86I01EvnKW5q6m084uA6z6zhxt5/4SlTnWw1iUaPXxRTM3uAOCiVdj031kfTEWs+3YIeHVHt7pq7rsHpt/6tlcChwq0hek7a1WnmhotyJBRQIJGHMyzJ6ibclgV9wfZx2g07ImszyUOgxpb7QBt+8txw8EGeBjWQJZvKUM3d2JAtoANWDenGlv2DntxtMrkc3Pc1HBkMb1dyhcrhdRGy6b6XXTMJG3CwotULmC4toXgf88nMQBDw/3Hv/mDvQ+c6AZbUNglvyZOcwVJG2GZ7pOuw08yoPwCV/WeR+i+VWVXONAiJUcez69CiFsYjzbZ7zOQ28wFHh4eD331a4um7tA9HQZjGiFBfp9Qc1JpjezW27jC/dh6+XzryOm/QV/zA8akgmOcRdk5cq0+tTOB3H7nFPFfHz0jNaLGbLiRjfom3iCC+WKNxciZRbLDbohDcOoG5spehHRY9D4bIKxYecxcg7A RP6CGsuI Maq9JGPlrjdkpVr18CUnA+B6tCDVueBNFCn0+KYywLXSgUJW4fDtoKvPdrXSPXU+AoevC50qVcF76VrCPAw/06q7h34L6jQsBgtZ9pN0uLks6Had3m9k3oe/TqtOop+uJXk6GnwR8wP+GR0H3cFGLQgvCDztHNTB8nf9LWB6NZLF+j3p/SQ4ZWAvs7HqohnI5nSZPGH4iecpzLhuqfRgHJX04txx78A/kL2TPgMnYaQf+Qr0gyzILKhG64IlABCcP1NOq4kDJO1GOH3T7Vabe3O23P7/P4E+D1GFr3uoJexW9yaLwbCIsrGb88tBafRaHooqtT/U4MYeMd6QadvDMBbPbNGHzaAaOJSGriAiJhQ5Mr8OaHvRRMoIRaCq3IkPo7jHf4i8VFABhvL4iGyodHUzD1O/K6XkwTEqQBKjepYwb7mwpyFRMj7Fdrz/tSWezii3/bq4UsjCp9gis8mPibqz+/D4bx7O7V1P5 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 17.06.25 15:58, David Hildenbrand wrote: > On 17.06.25 15:45, David Hildenbrand wrote: >> On 17.06.25 15:42, Jason Gunthorpe wrote: >>> On Tue, Jun 17, 2025 at 12:18:20PM +0800, lizhe.67@bytedance.com wrote: >>> >>>> @@ -360,12 +360,7 @@ void unpin_user_page_range_dirty_lock(struct page *page, unsigned long npages, >>>> >>>> for (i = 0; i < npages; i += nr) { >>>> folio = gup_folio_range_next(page, npages, i, &nr); >>>> - if (make_dirty && !folio_test_dirty(folio)) { >>>> - folio_lock(folio); >>>> - folio_mark_dirty(folio); >>>> - folio_unlock(folio); >>>> - } >>>> - gup_put_folio(folio, nr, FOLL_PIN); >>>> + unpin_user_folio_dirty_locked(folio, nr, make_dirty); >>>> } >>> >>> I don't think we should call an exported function here - this is a >>> fast path for rdma and iommfd, I don't want to see it degrade to save >>> three duplicated lines :\ >> >> Any way to quantify? In theory, the compiler could still optimize this >> within the same file, no? > > Looking at the compiler output, I think the compile is doing exactly that. > > Unless my obdjump -D -S analysis skills are seriously degraded :) FWIW, while already looking at this, even before this change, the compiler does not inline gup_put_folio() into this function, which is a bit unexpected. -- Cheers, David / dhildenb