From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C07F7C021A4 for ; Mon, 24 Feb 2025 21:17:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3496728000A; Mon, 24 Feb 2025 16:17:58 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2F967280002; Mon, 24 Feb 2025 16:17:58 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 14C8128000A; Mon, 24 Feb 2025 16:17:58 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id EA7E2280002 for ; Mon, 24 Feb 2025 16:17:57 -0500 (EST) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 922D21C6EC2 for ; Mon, 24 Feb 2025 21:17:57 +0000 (UTC) X-FDA: 83156100594.30.9491BEB Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf29.hostedemail.com (Postfix) with ESMTP id ECB45120002 for ; Mon, 24 Feb 2025 21:17:54 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=ijJsKv9z; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf29.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740431875; a=rsa-sha256; cv=none; b=SS2+iO0pM/siAq6CTK/ppJ85vbCTeehSQgGJG6HGBH5NNfnOoMpBuCGVBHqq3gWEEoVDK2 opUVgsxL/fHYQfJnH+S90DZ35sB5TKLuTLVBlcy/Vsl0NRj9quJX+DXYRkn/Uj7ozQTEYY 40mFsTm71FuLAmDLkvqlf4KbrKf+7Bw= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=ijJsKv9z; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf29.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740431875; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=+pfaFYnZrGg4aP81g3fvxtKUOG+gZ00codvuI9HyJP4=; b=SSfBpFUcj6sN1NR3t4M898jf4OVlJUKW2sj/E+jwShq2ayZ4kDFAGazdZgZKEAgjkGftqP papsZEPtCAwVBzTfu9/yyKYhLh0eOcPVxEoecPa8oLfxek1wmKqgVU/RxUlORfoQgmtAes /u9ZtrYImqf9tJ+SnzZzNIPV5M8aO58= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1740431874; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=+pfaFYnZrGg4aP81g3fvxtKUOG+gZ00codvuI9HyJP4=; b=ijJsKv9zQ0amDbB9rUEd8QhGugvpW9Yk6ym0eicvtAsnDCoU+ecsJxyMBGKzLKJlkhlVyw mQNvULo21v9mlHZVksU+dVIUbcUovZFvYcF9hlJI9s+V1uQDa+roAzOmm0LWUgul+DLo/F UVdsHlivfXldqfa08/iaZLb/R9EyFWU= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-687-nTLmiDgUP2OTx3kYhCRhuQ-1; Mon, 24 Feb 2025 16:17:50 -0500 X-MC-Unique: nTLmiDgUP2OTx3kYhCRhuQ-1 X-Mimecast-MFC-AGG-ID: nTLmiDgUP2OTx3kYhCRhuQ_1740431869 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-38f4e47d0b2so2249690f8f.2 for ; Mon, 24 Feb 2025 13:17:49 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740431869; x=1741036669; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=+pfaFYnZrGg4aP81g3fvxtKUOG+gZ00codvuI9HyJP4=; b=UcT1la+J68zSJS8e0sSv0Ykf546/sXtFZIS3mA3C2V8Wf7W/p8xGmeAdpB6rG2otxz +327/gGpdO07hI3/CBjYXFmuhJhhn4GlbEsZ9wpk2429F3NTJTU0xeOALW+QX/bd6Ar2 bhBH5uPIpE+aePoqHTt5PV3tVqIoXykBLb95sMFLO9Jl6r5ijYqnRpdORWrtCgeCnHoE CMnSrtIRp9VC75JCVinpA9cODuKNYkJm4Rxa7IojHfIp9peoYf0W9Qq4a17YMDRgJeEY d0/bLYqcoHw+2S88yTwrBlRWn/uJvvts8hU/HfDtbO6bW98OK2iTYzB1AkGmDEY+nxrE wv2w== X-Forwarded-Encrypted: i=1; AJvYcCWiWAkWb3OpGwKYeeoomA2C41sq/4/GFgJR3ee2Jk6JVRbdg0ANGhpXKgE36rGoyC0rnNAx9dQGQQ==@kvack.org X-Gm-Message-State: AOJu0Yz+K3EDpho3yPw1nIRAyBy4HnI+1CE0caVpLIRhsk6v8A7UExY1 2KyOtDkDK9vEkc9cX44zQYbMT5hBL4KD69x4M6btRXXKQUKpPMEVronkW2yj6gUixnF6x9VWDv2 e8c0JDP1kLPgoW5WGwfYNNyY7qL5LoL3WNPC3/bUXA1wDz94c X-Gm-Gg: ASbGncs//tUp8d0IQfIcIJE2kAp4lxhKBbFtL4QKd8kWHl427VAwUKYSUDYi75xH94Z kP4lIURD8lyZrKnIsMzzDr3h4itfGeBmF5uNMgh8uWDl+9kTaeI4z5Ebuzk7s/j/w7fJyHKvLJs GFPDnMF8XazyWGREZ5MAh6J1DkdYVNR0NO0u44SsKKdGu7pukZQDi+x1cFs0yyHY1LFE0m9aVQI K4AgpRYjrTYn+4sfqSZA/flm824GOTc8DP3RJrHPGIS1TdOgzUyGnG5BMe23AvmofNUxfSwUZcO HIINeOKPp1gjrAKcZZCI/rA+IXg79CuCNXBh32NpZsZowbzy5zjipD27U/30TLW4t6bfG1JSldc GadRUOeryxq30HEgitRnNTXSUZVKccfu2h1K3rvkdCFs= X-Received: by 2002:a05:6000:186c:b0:38d:eaee:3b32 with SMTP id ffacd0b85a97d-38f6e977bb1mr11433784f8f.26.1740431868842; Mon, 24 Feb 2025 13:17:48 -0800 (PST) X-Google-Smtp-Source: AGHT+IG33QLU4MJ0xSM0Xmwfzw/OZoX0OLRfIElZNAkzclFnmmRRtf6dMGVpb0BdzzxB/d4Ljuls4Q== X-Received: by 2002:a05:6000:186c:b0:38d:eaee:3b32 with SMTP id ffacd0b85a97d-38f6e977bb1mr11433771f8f.26.1740431868431; Mon, 24 Feb 2025 13:17:48 -0800 (PST) Received: from ?IPV6:2003:cb:c735:1900:ac8b:7ae5:991f:54fc? (p200300cbc7351900ac8b7ae5991f54fc.dip0.t-ipconnect.de. [2003:cb:c735:1900:ac8b:7ae5:991f:54fc]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-390cd86cb08sm150988f8f.29.2025.02.24.13.17.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 24 Feb 2025 13:17:48 -0800 (PST) Message-ID: Date: Mon, 24 Feb 2025 22:17:46 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 19/20] fs/proc/task_mmu: remove per-page mapcount dependency for smaps/smaps_rollup (CONFIG_NO_PAGE_MAPCOUNT) To: Zi Yan , linux-kernel@vger.kernel.org Cc: linux-doc@vger.kernel.org, cgroups@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-api@vger.kernel.org, Andrew Morton , "Matthew Wilcox (Oracle)" , Tejun Heo , Zefan Li , Johannes Weiner , =?UTF-8?Q?Michal_Koutn=C3=BD?= , Jonathan Corbet , Andy Lutomirski , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , Muchun Song , "Liam R. Howlett" , Lorenzo Stoakes , Vlastimil Babka , Jann Horn References: <20250224165603.1434404-1-david@redhat.com> <20250224165603.1434404-20-david@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: XVtYfUcv1qawdnoI5gLdtyD__a8gmrz3ogUXfRfjB2g_1740431869 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Queue-Id: ECB45120002 X-Rspamd-Server: rspam12 X-Stat-Signature: uwdaiytzhmmudwnt953ibxbsyw6a8nac X-HE-Tag: 1740431874-453289 X-HE-Meta: U2FsdGVkX1/I8QUneKi5nt97hiBXLHuDmuvbn2IuMpz/nTpZnVawHBHBno9P+6dEXK8Om229vjMD1EfYOwTd3X+HwlQ5GjX5oLt8NJ56pFD60zU33rOeeVUORIb6vFt3QdSTKGqohKodh8TC/qz8mdp3n++z9oFxHLrbpzPTpOoGQdP30eYFO24tL5YG+W36X7rdSXXLNcTkCFfaXp76MFTkzwocgb8BRVn7CHSMB6Rj3vFFOq308gEMA4w4vnDNPK1Grlszv6hf91aw+H7yVf5YjBfW+9sQdfmZ2Q6oOMlnoMtZxtAXOjAGghliZV2yNXH4/MqSuS4bZsVoSboqwXBqmrjxEXpKJ78PsKhwkCiKlb1ZS8O0CBZTjpcmIKZlbccHoki6uBK/llFhG01anYQC6FUy0ZiKIrl1BVqMLZfeZyu5zX531DiqBh7uhyd43/hA/ACGMWApjDKI/Z/dxWmyP/jS3tYUDM5dA0xXNyakkz9xkMoOjh9aLf2ndMZJFkEo0zo3/t84RNSXEbfdu7nvRz3bJD77bOeu13Ey5qCpviu6e01oA9peO+s6B2TOOn6AlZEXCdXMe+iuHMN9RySi5Ua2AsKwslGVvhAS1nWS55f15ply7ELuxSOZVEW8KZpREle1HDS3SqLykbzT3jlkml/eE390EDK+nRWldHaK22V5KHpUeWj95xupuM8aTO+NW+wsfAy3htp3rlNnZ/9phqPwLeklHQlPY2vRQWSmZmDs3ppUtD3368qF0yhTQLuJXZQRBL6HWUwKKrLtR7RQFp8JsXtXzfAVN9wDEKxgwa67/Z8d9kcRC3XQTjT2tnVUerrqmOEXJVAPmjfvFqt/amGfLZN/tzMXXFEhvlGaIEUcqPAl6uM8kVATsFMx6NpbKVZOI53FVrKmnga1LQecK9XXhW+X1rbMcExOaGX/6utXditG5nuCEOv/Ne1UMk0iEMXU7hWe1e8lOGm rm7BousV +00LMsXcdvCsqi/g0sHXisPIRK4tzUpRe8UJdOVuMpVYIMyeuyu1cRYvwRlktrwYYUG3tClyt8Kohe0KGd4Bzd5Suzs2gnU5iMM0MBkqOuVVNZRIOAk3la0vB79f/hXWPhDSQ+mCd/zXrTOU43UjpzI/nd24FOuBiRdE3pVfdFUsQmihWd+eHgxZDgV2ISPU8q3ORcN+S10NPerxuo/GugkMlLT525mIBdW72NS2/mtAcdgasm18vKuDHLlkJ+ISl0mDR/x7NVd82OsxFtd3jgv3blCvjsatdfXDTtQMpSZllvyssdayYLjF6wqJIpqVmqjSOGafKdv6IN8j6YmprbZGjFyI6S9ExgYJ5M/1reMqZQzMxdlJ/ByxhKJVD3665EZIrJVrPO1Jrr1Eg7etkeVNKka3Dvd5/pMaljsHa9ToEqy5jxLRYAUPsEGp+t2uw9yiULi8yq/6Y5fEGhI80azgIuQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 24.02.25 21:53, Zi Yan wrote: > On Mon Feb 24, 2025 at 11:56 AM EST, David Hildenbrand wrote: >> Let's implement an alternative when per-page mapcounts in large folios are >> no longer maintained -- soon with CONFIG_NO_PAGE_MAPCOUNT. >> >> When computing the output for smaps / smaps_rollups, in particular when >> calculating the USS (Unique Set Size) and the PSS (Proportional Set Size), >> we still rely on per-page mapcounts. >> >> To determine private vs. shared, we'll use folio_likely_mapped_shared(), >> similar to how we handle PM_MMAP_EXCLUSIVE. Similarly, we might now >> under-estimate the USS and count pages towards "shared" that are >> actually "private" ("exclusively mapped"). >> >> When calculating the PSS, we'll now also use the average per-page >> mapcount for large folios: this can result in both, an over-estimation >> and an under-estimation of the PSS. The difference is not expected to >> matter much in practice, but we'll have to learn as we go. >> >> We can now provide folio_precise_page_mapcount() only with >> CONFIG_PAGE_MAPCOUNT, and remove one of the last users of per-page >> mapcounts when CONFIG_NO_PAGE_MAPCOUNT is enabled. >> >> Document the new behavior. >> >> Signed-off-by: David Hildenbrand >> --- >> Documentation/filesystems/proc.rst | 13 +++++++++++++ >> fs/proc/internal.h | 8 ++++++++ >> fs/proc/task_mmu.c | 17 +++++++++++++++-- >> 3 files changed, 36 insertions(+), 2 deletions(-) >> >> diff --git a/Documentation/filesystems/proc.rst b/Documentation/filesystems/proc.rst >> index 1aa190017f796..57d55274a1f42 100644 >> --- a/Documentation/filesystems/proc.rst >> +++ b/Documentation/filesystems/proc.rst >> @@ -506,6 +506,19 @@ Note that even a page which is part of a MAP_SHARED mapping, but has only >> a single pte mapped, i.e. is currently used by only one process, is accounted >> as private and not as shared. >> >> +Note that in some kernel configurations, all pages part of a larger allocation >> +(e.g., THP) might be considered "shared" if the large allocation is >> +considered "shared": if not all pages are exclusive to the same process. >> +Further, some kernel configurations might consider larger allocations "shared", >> +if they were at one point considered "shared", even if they would now be >> +considered "exclusive". >> + >> +Some kernel configurations do not track the precise number of times a page part >> +of a larger allocation is mapped. In this case, when calculating the PSS, the >> +average number of mappings per page in this larger allocation might be used >> +as an approximation for the number of mappings of a page. The PSS calculation >> +will be imprecise in this case. >> + >> "Referenced" indicates the amount of memory currently marked as referenced or >> accessed. >> >> diff --git a/fs/proc/internal.h b/fs/proc/internal.h >> index 16aa1fd260771..70205425a2daa 100644 >> --- a/fs/proc/internal.h >> +++ b/fs/proc/internal.h >> @@ -143,6 +143,7 @@ unsigned name_to_int(const struct qstr *qstr); >> /* Worst case buffer size needed for holding an integer. */ >> #define PROC_NUMBUF 13 >> >> +#ifdef CONFIG_PAGE_MAPCOUNT >> /** >> * folio_precise_page_mapcount() - Number of mappings of this folio page. >> * @folio: The folio. >> @@ -173,6 +174,13 @@ static inline int folio_precise_page_mapcount(struct folio *folio, >> >> return mapcount; >> } >> +#else /* !CONFIG_PAGE_MAPCOUNT */ >> +static inline int folio_precise_page_mapcount(struct folio *folio, >> + struct page *page) >> +{ >> + BUILD_BUG(); >> +} >> +#endif /* CONFIG_PAGE_MAPCOUNT */ >> >> /** >> * folio_average_page_mapcount() - Average number of mappings per page in this >> diff --git a/fs/proc/task_mmu.c b/fs/proc/task_mmu.c >> index d7ee842367f0f..7ca0bc3bf417d 100644 >> --- a/fs/proc/task_mmu.c >> +++ b/fs/proc/task_mmu.c >> @@ -707,6 +707,8 @@ static void smaps_account(struct mem_size_stats *mss, struct page *page, >> struct folio *folio = page_folio(page); >> int i, nr = compound ? compound_nr(page) : 1; >> unsigned long size = nr * PAGE_SIZE; >> + bool exclusive; >> + int mapcount; >> >> /* >> * First accumulate quantities that depend only on |size| and the type >> @@ -747,18 +749,29 @@ static void smaps_account(struct mem_size_stats *mss, struct page *page, >> dirty, locked, present); >> return; >> } >> + >> + if (IS_ENABLED(CONFIG_NO_PAGE_MAPCOUNT)) { >> + mapcount = folio_average_page_mapcount(folio); > > This seems inconsistent with how folio_average_page_mapcount() is used > in patch 16 and 18. It only looks that way. Note that the code below only does >> if (mapcount >= 2) >> pss /= mapcount; Having it as 0 or 1 doesn't matter in that regard. Thanks! -- Cheers, David / dhildenb