From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7ED3AD68BE3 for ; Sat, 16 Nov 2024 05:02:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A2D8A6B00BC; Sat, 16 Nov 2024 00:02:47 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9B7016B00BD; Sat, 16 Nov 2024 00:02:47 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8564E6B00BE; Sat, 16 Nov 2024 00:02:47 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 6838A6B00BC for ; Sat, 16 Nov 2024 00:02:47 -0500 (EST) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id E4EF81A0B50 for ; Sat, 16 Nov 2024 05:02:46 +0000 (UTC) X-FDA: 82790760570.09.D3CA9B1 Received: from mail-pf1-f177.google.com (mail-pf1-f177.google.com [209.85.210.177]) by imf02.hostedemail.com (Postfix) with ESMTP id 9AF998000C for ; Sat, 16 Nov 2024 05:01:17 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=hQTAXxVd; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf02.hostedemail.com: domain of yunshenglin0825@gmail.com designates 209.85.210.177 as permitted sender) smtp.mailfrom=yunshenglin0825@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1731733300; a=rsa-sha256; cv=none; b=7yJA/1hk6DwlrldYCa0JyaAHgysRgF1HVEeO+oMo+XaPienVSDgJgv2IXvrteJL/RP8sgm X1oq+ZCUzya8eCjpYN9I7kUjAsoYuQwfR3G1y2qpZHUldsaTxGUqkOLz9bImVZNONWk0nt 7YE8of51FHm21qU7SIOM2uS2GVvfDkQ= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=hQTAXxVd; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf02.hostedemail.com: domain of yunshenglin0825@gmail.com designates 209.85.210.177 as permitted sender) smtp.mailfrom=yunshenglin0825@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1731733300; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Al2Fv5O+3DHuButDDwBDr/yMow4Wua+CLhtsdNpXD4k=; b=i/u5WaAR+qfjpwfY6V5HVkJ6PBgYZfp115gSk2VgQ0/0GKYToAHVOFAtAOH5SuPMk1MZl1 s+46DH8DxRhX7/TJ3CS+t/nxcCNAYGqV35NH/eex8vQXj6vNSukDGnMNGcuTqAKtneexKI igP40KKQzMQCbkY/f5spZOeNkx6YUDs= Received: by mail-pf1-f177.google.com with SMTP id d2e1a72fcca58-72061bfec2dso234818b3a.2 for ; Fri, 15 Nov 2024 21:02:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1731733364; x=1732338164; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Al2Fv5O+3DHuButDDwBDr/yMow4Wua+CLhtsdNpXD4k=; b=hQTAXxVdFLdjy/bzdAXgUj8SbtRqb2lWAIE6a8Qxh21y90Sj1qLEcw4pN9YeTcJ9aD JMigI4x1hENprEYoWAdSGIrQDLdfsqVQCs8uMEE0GSRAz6MiWHfx3Cdf9+/X+mvkvnpi uKOo81lHro+jZij3wAFZO3niS+OHvpC+kllWnOddK/6N8FQB0KLCexItKmqfqufzgKEp 2mlym31HN0aXZFQlihysMQq2vc3c2RjSr8BOc47YwfbAZgES9hQ5XZs8WbyahoDiavjk Uyme4TpZlpDBCqBTXa+MzGSYsHtMjvz7iFEoqDnsWR4iVGlh/FHfXKJbgF10HyKo5F/h +OWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1731733364; x=1732338164; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Al2Fv5O+3DHuButDDwBDr/yMow4Wua+CLhtsdNpXD4k=; b=ncO3Zc/VPfPJ0alGh5yLiPRzcoX7KFLkOXPZ+uqiv3xn1Sit3srYD56F3q5JK6dt+x PNLiZS9OyDQndCgNKTSYWTQzjt7tIpykhroWGl0nkPHrrPki+1m1fz+pe3/6mssqbMCa 3j/RoQRhnoW2AC4mTe8ttR16mt/YHZhpbVfUjEWbz/WE98LM7C6Fv1QTr14B4Q08K+AU uxxs74utPmILMzH84eJlHAVlEIW5UiOZEy5f/kgp4eQqdlTm/AvwWj2I5h1GHbkeuL0C oOtPYeP3FKGQ8wQrBf6HnojsHMPIzcazN6Ltdq1q57j2KWcHfM/7rmYi6GWtJ4gFhCkf pU7g== X-Forwarded-Encrypted: i=1; AJvYcCVV6T0xeEGbgHXHoywiK/474nqKsurLXtQQzihW40EnWLZX3asgJ8KZnupdM1qtEnxnxpJ+oAZHug==@kvack.org X-Gm-Message-State: AOJu0Yz+5tnpvILjm008V5YE7vIHtOL5hndWH5mg/QjOTr419mM8l/RO zKTTN1+gHXIvMwlgI0HzEfKv6CCQhn653HPapiR0sK8VGWjoNAOS X-Google-Smtp-Source: AGHT+IEnO27UZrQ5wsGrVcrctH9PWQnt52pfrgIDphtZTd0pLpaLdSDw3VPq57AJBDsOnC27+WU8MA== X-Received: by 2002:a05:6a00:3c96:b0:710:9d5d:f532 with SMTP id d2e1a72fcca58-72476f7d406mr7437628b3a.19.1731733363577; Fri, 15 Nov 2024 21:02:43 -0800 (PST) Received: from ?IPV6:2409:8a55:301b:e120:1128:c4a9:977c:8412? ([2409:8a55:301b:e120:1128:c4a9:977c:8412]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-72477203a4bsm2238498b3a.192.2024.11.15.21.02.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 15 Nov 2024 21:02:43 -0800 (PST) Message-ID: Date: Sat, 16 Nov 2024 13:02:38 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next] mm: page_frag: fix a compile error when kernel is not compiled To: davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com Cc: linyunsheng@huawei.com, Andrew Morton , Alexander Duyck , Linux-MM , Mark Brown , Shuah Khan , linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org References: <20241116042314.100400-1-yunshenglin0825@gmail.com> Content-Language: en-US From: Yunsheng Lin In-Reply-To: <20241116042314.100400-1-yunshenglin0825@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Queue-Id: 9AF998000C X-Rspamd-Server: rspam01 X-Stat-Signature: o4x6nqogoynyyca3d9jamwf6jt3147g1 X-HE-Tag: 1731733277-614127 X-HE-Meta: U2FsdGVkX1+jkBLAaHXrk2Ahu2p7AAM28cuiF1FIVTJF/P/Ao0BIfQEzHYJ7ZEEALqrwcqgFr+aa7MmCDr5BVwL7d0XF+EmVQLA/xTZoPpcwIM7QFOVTewtYDQT4wL/aiJjAa2xd8l1f0rRjhK66SnpTPGkEf3uToDQ+sTJKYkKfji/o/5C1A3ZkpBEc8htnbe+Way1Luqf/Q/3N7IrpkvbyDEQ3uLj7mmE42pkrHJeSVo4DhO2ksPDUUklbup+yGDefimYuIEUcpzOeFrKdnd/e3jwL6MNdk6UU0wla7H50oYyys3A0pyzYYp4KMFriQ/h4mDIZOdur72LjLOpcHy5hBNxePfjuGh6IfPHO7l5A6txv2HmFiRr/LQ4/AppuN9S1fuzMlDY2CAxMev9RgJmZvNZoldUOyrkCSsQ0q3EFBnP9N9WwPp2UpT5xrFNXA82kaWLqbYZcJKMcc9H5qd4bUvkA9Ok90fFK9kY4TRO8guRwxuoIOsFZHcsYIgrxjXmteQ26yF1TJ5Xxvi0LFhcXNBhxozncs/crx2AbCOZ6lGvBErzp7OeuQJ4DGMtXSVot4GxKcJIMdeqs9nOXnpeYT7qhD6zIqYiNTYWhnpAa+FZdHADKkhuiHnc6T6GTFYhj016clopeUVYsnFi0jmKpDEfrLq8xnerxFvM074g0wsdI07lG0knExeekJ7pXeK7qpLHfMPuNyOJnsSZ4AHwYiox8/zrUq/at0fI2j8KqPi3e3rYDwNX+q+Q4fDlMVf6ka6BEF2kTU539KMdzgKEkXOstN/OXl74t43ZCmfcrzp3P36HdYZZH0FhjXSg/Iw6R5y2+8Ck9OD3w1kkj7Bs7CbUYWorqkhkPxYXVGWOkEbNRwB/DcHyRlOVqN8k0B9l55JYMJyDL4bOTG2u65qzcXigfEa/yed+77D9TnnUsm5p56FjzFRBfVylAqGJFcjXECIFMsdQ97JBhU/m Trcn9PEP XXkYI0/QEkxDf07/UgVxSldaxDacvNW6ACKIitwB4zF+O1CwWsgMJb1XpW9TR2MRyzxR2PZFWHr+RpAlPWvF7h9gcmAplSy1FMKbHcfuPVumqcXMUW1HIMNkF1pvq8b8LBGOUfr+ZH4b4BihNsfmac+I1qW53Kfash3PWw4H4v36XrfBAO1Bh4ktrqxsVQpy9nkw4TBHYuSAtdGCMfh7QbMAwdY82EPXCh4qT1pKmIAGJ/k0uFWg7UuVuJGHu0LsMhOgQjPDgGgNrI0D7z4GPKhKFvAc3loFb1ZOJJ4gg8jTume19N89P3fXYoU05WohRvBsBSLDEqFDSWHtWPV1rFsSva/qL53GnLc1ewiINPVjAcgIhVnFr6p5vYKuLC0GCiaE9XCwozWvxvKaorN/CJCXikoRmORThDqHu0A+oCL9M7XclHZd52xRzeuuNqDyzbYYTymDGLqbDTGxOJAHut3ZGc+NDiErGmGffI0fDyqQCFxrjUYPBGtsbx2W8nB6cL/d8+5ZMtE5AdOT3XwRnVkNw1Hsan7kwZ0gw8HJ2a78eHhTF6Li7wEM/goUI1MgZqJVPLDxqNuOGoqufSmlqB1u87xOCP5clhWl9J31v1ohuIyy+QXCIF2xJGmiN/ZnoJn2SwKJ9fzvV8ylltb+1mWwYVfiPSsVNWWGsOHPdnEq0KDo= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000008, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: It seemed that somehow I missed to add the netdev ML:( On 11/16/2024 12:23 PM, Yunsheng Lin wrote: > page_frag test module is an out of tree module, but built > using KDIR as the main kernel tree, the mm test suite is > just getting skipped if newly added page_frag test module > fails to compile due to kernel not yet compiled. > > Fix the above problem by ensuring both kernel is built first > and a newer kernel which has page_frag_cache.h is used. > > CC: Andrew Morton > CC: Alexander Duyck > CC: Linux-MM > Fixes: 7fef0dec415c ("mm: page_frag: add a test module for page_frag") > Fixes: 65941f10caf2 ("mm: move the page fragment allocator from page_alloc into its own file") > Reported-by: Mark Brown > Signed-off-by: Yunsheng Lin > --- > Mote, page_frag test module is only in the net-next tree for now, > so target the net-next tree. > --- > tools/testing/selftests/mm/Makefile | 18 ++++++++++++++++++ > tools/testing/selftests/mm/page_frag/Makefile | 2 +- > 2 files changed, 19 insertions(+), 1 deletion(-) > > diff --git a/tools/testing/selftests/mm/Makefile b/tools/testing/selftests/mm/Makefile > index acec529baaca..04e04733fc8a 100644 > --- a/tools/testing/selftests/mm/Makefile > +++ b/tools/testing/selftests/mm/Makefile > @@ -36,7 +36,16 @@ MAKEFLAGS += --no-builtin-rules > CFLAGS = -Wall -I $(top_srcdir) $(EXTRA_CFLAGS) $(KHDR_INCLUDES) $(TOOLS_INCLUDES) > LDLIBS = -lrt -lpthread -lm > > +KDIR ?= /lib/modules/$(shell uname -r)/build > +ifneq (,$(wildcard $(KDIR)/Module.symvers)) > +ifneq (,$(wildcard $(KDIR)/include/linux/page_frag_cache.h)) > TEST_GEN_MODS_DIR := page_frag > +else > +PAGE_FRAG_WARNING = "missing page_frag_cache.h, please use a newer kernel" > +endif > +else > +PAGE_FRAG_WARNING = "missing Module.symvers, please have the kernel built first" > +endif > > TEST_GEN_FILES = cow > TEST_GEN_FILES += compaction_test > @@ -214,3 +223,12 @@ warn_missing_liburing: > echo "Warning: missing liburing support. Some tests will be skipped." ; \ > echo > endif > + > +ifneq ($(PAGE_FRAG_WARNING),) > +all: warn_missing_page_frag > + > +warn_missing_page_frag: > + @echo ; \ > + echo "Warning: $(PAGE_FRAG_WARNING). page_frag test will be skipped." ; \ > + echo > +endif > diff --git a/tools/testing/selftests/mm/page_frag/Makefile b/tools/testing/selftests/mm/page_frag/Makefile > index 58dda74d50a3..8c8bb39ffa28 100644 > --- a/tools/testing/selftests/mm/page_frag/Makefile > +++ b/tools/testing/selftests/mm/page_frag/Makefile > @@ -1,5 +1,5 @@ > PAGE_FRAG_TEST_DIR := $(realpath $(dir $(abspath $(lastword $(MAKEFILE_LIST))))) > -KDIR ?= $(abspath $(PAGE_FRAG_TEST_DIR)/../../../../..) > +KDIR ?= /lib/modules/$(shell uname -r)/build > > ifeq ($(V),1) > Q =