From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4571AC41513 for ; Thu, 27 Jul 2023 10:32:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 853648D0001; Thu, 27 Jul 2023 06:32:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 801E26B0074; Thu, 27 Jul 2023 06:32:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6A2878D0001; Thu, 27 Jul 2023 06:32:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 59EE36B0072 for ; Thu, 27 Jul 2023 06:32:30 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 2955DB2AFF for ; Thu, 27 Jul 2023 10:32:30 +0000 (UTC) X-FDA: 81057027660.25.F5E7B24 Received: from mail-pj1-f45.google.com (mail-pj1-f45.google.com [209.85.216.45]) by imf18.hostedemail.com (Postfix) with ESMTP id 2D8D81C0002 for ; Thu, 27 Jul 2023 10:32:26 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b="Zr/NhsMb"; dmarc=pass (policy=quarantine) header.from=bytedance.com; spf=pass (imf18.hostedemail.com: domain of zhengqi.arch@bytedance.com designates 209.85.216.45 as permitted sender) smtp.mailfrom=zhengqi.arch@bytedance.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1690453948; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=4VsKgOIlO7JTMbURB3u+V7Qr/QzOpc+0Bt56AjhAYAM=; b=qbO2PK0pzWzk4unGq62Qq/3Kw1K6VE/nMO/BYxhyYFEy+pxS4rQD/pxDgU8l03qqKc8Vgh K520Z/uj6+enbjpF4AMTx5UdOmcd7lUqLeM9LR1iFO7CD+l6v4oiSbdMZGY9BOo/ZXgk/d UM+RDm5WG3HopIgjPyOI8cCpEmfnQSA= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b="Zr/NhsMb"; dmarc=pass (policy=quarantine) header.from=bytedance.com; spf=pass (imf18.hostedemail.com: domain of zhengqi.arch@bytedance.com designates 209.85.216.45 as permitted sender) smtp.mailfrom=zhengqi.arch@bytedance.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1690453948; a=rsa-sha256; cv=none; b=djY62bHwbizBhzFoQQdOa7rQ3+n7u+gOccRMZHw4fAgdh4ex2NLWgvtkIKh/ezWZnkaOYm 8nn4NH24u9SiERJlalIdQvruz9I6EXFRrVx1HGTv26ByPMAMD2LBlX35E+GLuaF65jElef iJyTBYouPjxTkiPcXAcmi906+zTO4n8= Received: by mail-pj1-f45.google.com with SMTP id 98e67ed59e1d1-2659b1113c2so160327a91.1 for ; Thu, 27 Jul 2023 03:32:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1690453945; x=1691058745; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=4VsKgOIlO7JTMbURB3u+V7Qr/QzOpc+0Bt56AjhAYAM=; b=Zr/NhsMbDbdIdSqoueTQTw00LusmUmyLrdR7MeDx+ZO5Q+75jdmzv373GL0Ee5CtKr W6fluKiuFJCg5ZU3kW0Km101UvphMU1vBCY7hDEO6TFqab4XzqrIV8fVDPR2Owpqim7U N3OX4eAxVQVjc5z6Zvv7YweV9TAIgzv2mVUZoaytYD45Z4tHHiC7Kn023GaYmi5v6RKy g9n+r/2KPb5qfD2ZK/MDUQIwCLsfUVl7c4q/2XRu1uefpNinWMEwlZLohyik+zojbFUF urJtl81vW3ulTBjRT5ht+WLfC03kh8PaMNuzZ2kESl6uu5dT49u0KrVoAN4kKuQ8SPSD k2iA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690453945; x=1691058745; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=4VsKgOIlO7JTMbURB3u+V7Qr/QzOpc+0Bt56AjhAYAM=; b=IKrHViktgnVppthj1zc81UcimvK369iQv4yL7r7Nq8Q5gV8PVp2+cv9y7PNx95nY2p 75RwIjOkp8jiXlY3yEGFA1uhDN0HRx5AmQz3opCfb5ZqhwcKq/fw8IXKPq0fVwTzeHUR azqgvc/3qk/HeFeYBV49h6mGcPsIweIVo3sKmmBzOBYSW7qytSi9+cHB/c5yJEnqLOhx WsNDRy95nPuqXYdSnHqwwkdb/8GVZhI5C+tGJdGs0C9BYEOVzLNCZUq4X3QmHwxvLP6s Ruxadv2Bjy07c+mHpRDjT9eT24wQ7SLEXX8tuytBwt+LO7P0orMiCKPar3NezpDQMiDe piPg== X-Gm-Message-State: ABy/qLbV1ViLWJ3TJu+WyWQL47rJmFc1HSeoIw1t8AzQWo5wAegRm9a0 5WemAynTc2/nyYSBJUxi8MuHEw== X-Google-Smtp-Source: APBJJlGmzPZn88CMJAqpsojyTb97uikW28yo5O3pi8rH8SDlSH8BwjASuoOudfeGFyxgCSRxAf0mLA== X-Received: by 2002:a17:90a:1b06:b0:263:2312:60c2 with SMTP id q6-20020a17090a1b0600b00263231260c2mr4299433pjq.3.1690453945653; Thu, 27 Jul 2023 03:32:25 -0700 (PDT) Received: from [10.70.252.135] ([203.208.167.147]) by smtp.gmail.com with ESMTPSA id 8-20020a17090a018800b0026309d57724sm2755058pjc.39.2023.07.27.03.32.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 27 Jul 2023 03:32:25 -0700 (PDT) Message-ID: Date: Thu, 27 Jul 2023 18:32:10 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH v3 28/49] dm zoned: dynamically allocate the dm-zoned-meta shrinker Content-Language: en-US To: Damien Le Moal Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org, kvm@vger.kernel.org, xen-devel@lists.xenproject.org, linux-erofs@lists.ozlabs.org, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com, linux-nfs@vger.kernel.org, linux-mtd@lists.infradead.org, rcu@vger.kernel.org, netdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, dm-devel@redhat.com, linux-raid@vger.kernel.org, linux-bcache@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, linux-btrfs@vger.kernel.org, Muchun Song , akpm@linux-foundation.org, david@fromorbit.com, tkhai@ya.ru, vbabka@suse.cz, roman.gushchin@linux.dev, djwong@kernel.org, brauner@kernel.org, paulmck@kernel.org, tytso@mit.edu, steven.price@arm.com, cel@kernel.org, senozhatsky@chromium.org, yujie.liu@intel.com, gregkh@linuxfoundation.org, muchun.song@linux.dev References: <20230727080502.77895-1-zhengqi.arch@bytedance.com> <20230727080502.77895-29-zhengqi.arch@bytedance.com> <56ee1d92-28ee-81cb-9c41-6ca7ea6556b0@bytedance.com> From: Qi Zheng In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 2D8D81C0002 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: oj6jara4e1f5jfam7rqzrezsn8s3u4uy X-HE-Tag: 1690453946-472918 X-HE-Meta: U2FsdGVkX19a8GAruubbvLMbaMiv073HPmxbP6avUizZ4tEPFWgL6jIx/ZJkL4JYUfE6FitgAfOfyYHGE/jC/o+LXRAgCsEcnRkdW+9pYpjzKZjraNE8YMr535enox5/gzzXzOYT9d+AIOcLYvxRZuk9dNybttgxILNSpL/zGRT1lm+z+vT5u/OJHwCrP2wdu183Ztb5I6kj5KQZ+mlJsm9dNfKUyI6jz99ZsN6nYe/NwNHeoRYoTNeXOvndM5wsMpWw6Vxj3yBW11nwN9rQJO1v0jj7eDEeaIRvrk3MMVGfSwVijrKv++lfboCBEl8vm2bcyC9dGs75XDNWGTHn+DTSa22+L8LjBE2sUIObsVm3jr31teWiJ2DluCaAuWbu41NNWW58lIXE++GcOKBqEBqFiAJauCnI//kFTFNyJcgyChmv97/VvrKP0/vk8gB+up4OZxn1Zd4Bub72gi4nA8uvfN5OXoMDA0Wp8GaiGCd+ZC6sOGNcfjukTbmuFMSB4OeW2/cLgah8PcsJvqEAPwHDyBz41rHaIQObqa8TFMv7PJQjJDciJ42LgnYIvRCDihmTKqu+op7PQIPxI0h/6mg6wEjbGvfZObMcFYKtdZK2E1xtaFXTEO21ReSZ3kDgpwHgIYb9RWtL5EokqJeLZ0Q46YuJHgTK6rnB0ebAYotVRUXWLVi1INNFmd65MfDPiav+luayla+3bm+j55aDRGYjE5I1sPW3vD6DJH4r/ZnLggFZ7IW4qzo6TxivwV9ChKxK13qNPcyuQtPTVWkVk/Z17El6WlnXn1fPkdrzT234Slk9zpNOceHAF8mW0Vh2370CSOWLSOCj5wPQfgL4k+56zUY2wlQdwWTAevL9xyv2hv3SsvekvLzsx/5dwpzCTKbsRepuSFFj3RfOW9pQOtjf4beSrEd6gdxOOCr+b1eyIfAnnVAmcJIthl/e/wfbu9Ywct4iaTWkCAVT1kS rUOFCT0k bvW1V0z09hiNsodnyg6UqQ6rL9oFSYnfpLiJFS8VxCcnvNErUD8spce99xQbu/kYI33SXAoQgNFZQXC2/axcqsDIEq3R9FsjIIPX16zlDYMPuSUuiYyLlkRCxNwjz9w65PFJrnbyBvE9AkXKqnFLMjNcvYF1grT5Mm3Ml/ZeWJFawC0gNkzucc00lMrDODVxGInzXuKrIV9tI4xdax1YEDtQHL7U7TWkEN9wSMG0qoFh4JVfGHbRuFyDJLkSkppBnZpMdtrAlAOX1tS80r2mUQb+EOrZWYGf56TdoiolA610zvMPsIJhGJ1mfubXnboaycTxhdBbN+NQ2UWwuT6URZ9wXLZS1jhn5oxzUoLhFreWabRnt6Chd4gs5Cg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2023/7/27 18:20, Damien Le Moal wrote: > On 7/27/23 17:55, Qi Zheng wrote: >>>>           goto err; >>>>       } >>>>   +    zmd->mblk_shrinker->count_objects = dmz_mblock_shrinker_count; >>>> +    zmd->mblk_shrinker->scan_objects = dmz_mblock_shrinker_scan; >>>> +    zmd->mblk_shrinker->seeks = DEFAULT_SEEKS; >>>> +    zmd->mblk_shrinker->private_data = zmd; >>>> + >>>> +    shrinker_register(zmd->mblk_shrinker); >>> >>> I fail to see how this new shrinker API is better... Why isn't there a >>> shrinker_alloc_and_register() function ? That would avoid adding all this code >>> all over the place as the new API call would be very similar to the current >>> shrinker_register() call with static allocation. >> >> In some registration scenarios, memory needs to be allocated in advance. >> So we continue to use the previous prealloc/register_prepared() >> algorithm. The shrinker_alloc_and_register() is just a helper function >> that combines the two, and this increases the number of APIs that >> shrinker exposes to the outside, so I choose not to add this helper. > > And that results in more code in many places instead of less code + a simple > inline helper in the shrinker header file... So not adding that super simple It also needs to be exported to the driver for use. > helper is not exactly the best choice in my opinion. Hm, either one is fine for me. If no one else objects, I can add this helper. ;) >