From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E6E19C433F5 for ; Fri, 17 Dec 2021 12:08:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6F2736B0071; Fri, 17 Dec 2021 07:08:42 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 6A1C96B0072; Fri, 17 Dec 2021 07:08:42 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 591546B0073; Fri, 17 Dec 2021 07:08:42 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0047.hostedemail.com [216.40.44.47]) by kanga.kvack.org (Postfix) with ESMTP id 4C2796B0071 for ; Fri, 17 Dec 2021 07:08:42 -0500 (EST) Received: from smtpin07.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 16104886E6 for ; Fri, 17 Dec 2021 12:08:32 +0000 (UTC) X-FDA: 78927164064.07.833F2BD Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf07.hostedemail.com (Postfix) with ESMTP id A826540019 for ; Fri, 17 Dec 2021 12:08:31 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id C29B81435; Fri, 17 Dec 2021 04:08:30 -0800 (PST) Received: from [10.57.34.58] (unknown [10.57.34.58]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 743A93F5A1; Fri, 17 Dec 2021 04:08:29 -0800 (PST) Message-ID: Date: Fri, 17 Dec 2021 12:08:25 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; rv:91.0) Gecko/20100101 Thunderbird/91.4.0 Subject: Re: [PATCH v2 05/11] iommu/iova: Squash flush_cb abstraction Content-Language: en-GB To: Christoph Hellwig Cc: joro@8bytes.org, will@kernel.org, linux-kernel@vger.kernel.org, willy@infradead.org, linux-mm@kvack.org, iommu@lists.linux-foundation.org References: <6326303c396e28fd3b9ed89d82673dfcf159b8c6.1639157090.git.robin.murphy@arm.com> From: Robin Murphy In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: A826540019 X-Stat-Signature: wj9o1se5jtxa4yfjyog35speob7yuiuu Authentication-Results: imf07.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf07.hostedemail.com: domain of robin.murphy@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=robin.murphy@arm.com X-HE-Tag: 1639742911-650162 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2021-12-16 08:02, Christoph Hellwig wrote: >> @@ -147,7 +142,7 @@ struct iova *reserve_iova(struct iova_domain *iovad, unsigned long pfn_lo, >> unsigned long pfn_hi); >> void init_iova_domain(struct iova_domain *iovad, unsigned long granule, >> unsigned long start_pfn); >> -int init_iova_flush_queue(struct iova_domain *iovad, iova_flush_cb flush_cb); >> +int init_iova_flush_queue(struct iova_domain *iovad, struct iommu_domain *fq_domain); > > Overly long line here. Fear not, it disappears again in the final patch. In cases like this I much prefer to minimise the amount of churn within the series, to keep the patches focused on the meaningful changes. > Otherwise looks good: > > Reviewed-by: Christoph Hellwig Thanks for the reviews! Robin.