From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 54121C25B75 for ; Fri, 10 May 2024 09:19:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9B5066B00A2; Fri, 10 May 2024 05:19:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 827D26B00A4; Fri, 10 May 2024 05:19:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 67AF96B00A3; Fri, 10 May 2024 05:19:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 4AAB76B00A0 for ; Fri, 10 May 2024 05:19:29 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id E88B11C1E66 for ; Fri, 10 May 2024 09:19:28 +0000 (UTC) X-FDA: 82101938016.08.CC8D880 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf06.hostedemail.com (Postfix) with ESMTP id A023C180005 for ; Fri, 10 May 2024 09:19:26 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=RTbhV8fL; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf06.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1715332766; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=w0K49mR3hMRsaS3+WXflIxtYT2lACdM2QgyeFZGMIw0=; b=PRKtkyiSqF011WXZYpl+Dc18FiS3i7uPdg2qp8PusgdSmwolUKtiBBhK9+QCRWU6nVPtOu fcMLP8KDy8kWU1s2oj4bmDLCBxOYoW53u4JTqmyQI3eX+RIGslO9aj/EK4IPJk7r/XGNkX 8Y+AgPOikMn0rL4mbWq14XucvR7IKV8= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=RTbhV8fL; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf06.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1715332766; a=rsa-sha256; cv=none; b=O105NMRRVoVzqrwEdCo5+Jna3AZdhtqVeI0PLHu1PS9zu+tgxdmzjWz04/7OJcECeoUOFT 1aqQx7sTF5aYMEKS1mRQH2av5qSBrVrS71gMB7z9ciQohqmI/bwXdq8+90i3HeSlHjD6BV sr7yMtes0G0+rIncUqauulqhwzIiIO8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1715332766; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=w0K49mR3hMRsaS3+WXflIxtYT2lACdM2QgyeFZGMIw0=; b=RTbhV8fLBtz3GXwCnojN5c4B+JJi5JARnbyMWZhpwOVay5nRPCDwJeBiIQSiZmUdgq9MCU em9XrnoiV65tJ4HKMnvZO0JKjf2RHlDxMXZ/iSfGs3ZWsC5lsXVqFTyA8dosmlirx1MkSX TZwnZyaynitfDVOexXE7u7x5cNq71jg= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-661-G-fePiYuMHqJcPRoRLTyRQ-1; Fri, 10 May 2024 05:19:24 -0400 X-MC-Unique: G-fePiYuMHqJcPRoRLTyRQ-1 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-34da4921505so1035627f8f.3 for ; Fri, 10 May 2024 02:19:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715332763; x=1715937563; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=w0K49mR3hMRsaS3+WXflIxtYT2lACdM2QgyeFZGMIw0=; b=DBdAqNug3x/XHO5UIjqzxbvsMbHB02wMJIPoq6kEyLrwQ83wVfqM2TEfDlNkPcXL22 OfxuWF7fLrC1b+2O4ocURMZeGYAU9IzXgzQj+92Zovo2m88UzDwzNAAirJ+k2jVeZGer nbLfmZY9m2l+KSL7Qnai26hF1kQHfhuYMGWVkwjtLGBAiuFJL8aZMr4VZQe9Ya6t4cWP Cc4J4DZ16/+fvuhGSUx4Hb7ION4iKNW5HPkR2lJv6sixMjpXllF6bJTbVH0dNOl+kMZl XFV9xCxtMa6lC8EPuLA59vCah9/hRC6zG/LXqaPO4A62uRx98GzY9sAwWYkr76Om+gZ+ nBsw== X-Forwarded-Encrypted: i=1; AJvYcCUkNcucmxgALNdy+vI8EwS054faS5XH6UapSwd2XCa2RecYgjznx2inVmWZ/Ux+OSD1Es6yXxyU+rD3x7NdINVdTCU= X-Gm-Message-State: AOJu0YwzXTNoIIhmGjH8JDA7azqHCxdtXZt8o8D/yhSRl8dypNQsVivl RGttHxlVAobD/Sj54Uad/lZJMvlIpPGL7jt5UFWGMS5Y9wTwQLIIjz+SBXmXA5Aut25WLDFm6hz c/jTrAw67DDn6VG4VfN4kVJYIcqi0M7LPQjnnawoiRoXcmBvQ X-Received: by 2002:a5d:6650:0:b0:34d:7f17:1e22 with SMTP id ffacd0b85a97d-3504a61c818mr1654071f8f.14.1715332763301; Fri, 10 May 2024 02:19:23 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHDLI567jRNFDBdwdqfZ6nGf1Xf15xv0+TRyAm8U9bnx+S0TvouZY2YxcPUZgob0O4OHNWsmA== X-Received: by 2002:a5d:6650:0:b0:34d:7f17:1e22 with SMTP id ffacd0b85a97d-3504a61c818mr1654058f8f.14.1715332762858; Fri, 10 May 2024 02:19:22 -0700 (PDT) Received: from ?IPV6:2003:cb:c710:2b00:9c9f:9357:3f4c:5358? (p200300cbc7102b009c9f93573f4c5358.dip0.t-ipconnect.de. [2003:cb:c710:2b00:9c9f:9357:3f4c:5358]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3502baad074sm4067920f8f.70.2024.05.10.02.19.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 10 May 2024 02:19:22 -0700 (PDT) Message-ID: Date: Fri, 10 May 2024 11:19:21 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v22 2/5] ring-buffer: Introducing ring-buffer mapping functions To: Steven Rostedt , Vincent Donnefort Cc: mhiramat@kernel.org, linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, mathieu.desnoyers@efficios.com, kernel-team@android.com, rdunlap@infradead.org, rppt@kernel.org, linux-mm@kvack.org References: <20240430111354.637356-1-vdonnefort@google.com> <20240430111354.637356-3-vdonnefort@google.com> <20240507223402.206d6ddc@rorschach.local.home> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240507223402.206d6ddc@rorschach.local.home> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: A023C180005 X-Stat-Signature: d48tcad6854yp9dx7ygpb9kgx8qk1qbg X-HE-Tag: 1715332766-544155 X-HE-Meta: U2FsdGVkX18Io4YJvWR450uhYKANgsX0VO/JKjf8Z0BskDKdwqQWIXOm5KiRsKTS50/0X4wHDUqgwnf0rqWZ9zR/zb5rJwUxqrHUt42I8ywwmD+Sun6VGfxT43LmDmRxYDzI4cJrJeLtjGmcJpQLrFnLaTZ5glMklGhJYClnK575gcFK5FgyHjIdPVMLpRCsBp6JZ3yzSWK8p0JqI/nDi0MawFfkqB+OBBxBrWITY4fYaz4hHLZPxlr8+cV3cdvIbvKtHkVuroTaEgdFDFwaaBCVv9uj9NEPNg5zjIu7L3Td86nakfMoEvJSVSlMqNMDsa0yfd+JGTTVhzxcVmb6qvy6V5bPXi3eNs6iMHNon77xiiWr3wY0/S0lDqbW/Eltsxw64UZZLefvH3gtOyYwPBdWA/jeSzWfx6o+masgxxufpYR/c+gk063usvc009z27A4r2zuMOAzJlxgpUr+KT71rWehihKvTjefay8DMobgSWX6QzL12ma2lpp3nUGBUnYQFmq7xNIgLVDzeZ8yWKU+vlmyiP6+7kMAtBN1o4sWOSEL5MoW8ViR0dujezMg5MGU1J0ZxogJV29VkG/Gdo2Uu98+5I6M2VRe89FqsG4d/JaNIAnVl60kTxJoA/kV7dWjO4G+siRSRFZrTHB4Mrx9aJE9zaY1zZmkQOWVfXPg0klnzoK8OQ3ZWXgGaGMpWtwdTgPGu7oniAOZRoLiCvsXVg2z02exoXFbNThPkw2Ahh3ZE3uQXyVgbUxy86f1T80WSxGllYVyUk+VVoKL4ToqXmbLj5FNZ6g8aAs/ue8ZfQxJewPonjuhNVSuq+XvOAX4JB+1GHOyBTt1NXAtdE9ac7x+OhIcAGNBm8bOuYvosc0aiVxHeEscKvi2IDd0szOfDdhaWJ6FiebJzbSLRttrh4DkXLX8aZKKJSSFfPTDQreEkJqVnwHSXAbymSGoWTN5IQUxNT5hBkt/Pdzq uVyj7iiq 0iUd+jhxJHlSGMwtT/RdW0bOgLnDdvZgdPRQLq43yGWAEW6iQZGLAsRSLJ0dUT8M/T6XmrQaeTmp5DzX5EtSN8ZKfTNgWio9V8utK9gdGuDUYNSTGwu5B8NO7oF3hAgoPjRYpc2BKg3swRXsz8jta83s44ePEagGpGLFCGqZKqrYt1H/MLYZ6LFxEMJtObYKZzF5Tz7ODwbsIAK4/zN/wNNJAkk542ZgR405sfRiK+peHjV/L2ksE5cE5Qjf42Vnuibv81pJnzU8C/yEHkOOBhtaE4KxuWCyLAAVoEjeAmVmackx9cmoskVW0Vd3d+HIfER4mJDBzj4EkA0cZe2+FWD1nuM5K2hTpcQCdKIRx7IyO38s7OqLG9XtnzoW91qZZTdOnixjnJIusMY3k2TXRX6VfFszgIIvGyFYJKu/jiThvkdyW5XgrU0DhcbwaXWf161BiicdYUd11oQQQEC5mMsReZaliYoEzkSRyQT6OFMTpkRQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 08.05.24 04:34, Steven Rostedt wrote: > On Tue, 30 Apr 2024 12:13:51 +0100 > Vincent Donnefort wrote: > >> +#ifdef CONFIG_MMU >> +static int __rb_map_vma(struct ring_buffer_per_cpu *cpu_buffer, >> + struct vm_area_struct *vma) >> +{ >> + unsigned long nr_subbufs, nr_pages, vma_pages, pgoff = vma->vm_pgoff; >> + unsigned int subbuf_pages, subbuf_order; >> + struct page **pages; >> + int p = 0, s = 0; >> + int err; >> + >> + /* Refuse MP_PRIVATE or writable mappings */ >> + if (vma->vm_flags & VM_WRITE || vma->vm_flags & VM_EXEC || >> + !(vma->vm_flags & VM_MAYSHARE)) >> + return -EPERM; >> + >> + /* >> + * Make sure the mapping cannot become writable later. Also tell the VM >> + * to not touch these pages (VM_DONTCOPY | VM_DONTEXPAND). Finally, >> + * prevent migration, GUP and dump (VM_IO). >> + */ >> + vm_flags_mod(vma, VM_DONTCOPY | VM_DONTEXPAND | VM_IO, VM_MAYWRITE); > > Do we really need the VM_IO? > > When testing this in gdb, I would get: > > (gdb) p tmap->map->subbuf_size > Cannot access memory at address 0x7ffff7fc2008 > > It appears that you can't ptrace IO memory. When I removed that flag, > gdb has no problem reading that memory. > > I think we should drop that flag. > > Can you send a v23 with that removed, Shuah's update, and also the > change below: > >> + >> + lockdep_assert_held(&cpu_buffer->mapping_lock); >> + >> + subbuf_order = cpu_buffer->buffer->subbuf_order; >> + subbuf_pages = 1 << subbuf_order; >> + >> + nr_subbufs = cpu_buffer->nr_pages + 1; /* + reader-subbuf */ >> + nr_pages = ((nr_subbufs) << subbuf_order) - pgoff + 1; /* + meta-page */ >> + >> + vma_pages = (vma->vm_end - vma->vm_start) >> PAGE_SHIFT; >> + if (!vma_pages || vma_pages > nr_pages) >> + return -EINVAL; >> + >> + nr_pages = vma_pages; >> + >> + pages = kcalloc(nr_pages, sizeof(*pages), GFP_KERNEL); >> + if (!pages) >> + return -ENOMEM; >> + >> + if (!pgoff) { >> + pages[p++] = virt_to_page(cpu_buffer->meta_page); >> + >> + /* >> + * TODO: Align sub-buffers on their size, once >> + * vm_insert_pages() supports the zero-page. >> + */ >> + } else { >> + /* Skip the meta-page */ >> + pgoff--; >> + >> + if (pgoff % subbuf_pages) { >> + err = -EINVAL; >> + goto out; >> + } >> + >> + s += pgoff / subbuf_pages; >> + } >> + >> + while (s < nr_subbufs && p < nr_pages) { >> + struct page *page = virt_to_page(cpu_buffer->subbuf_ids[s]); >> + int off = 0; >> + >> + for (; off < (1 << (subbuf_order)); off++, page++) { >> + if (p >= nr_pages) >> + break; >> + >> + pages[p++] = page; >> + } >> + s++; >> + } > > The above can be made to: > > while (p < nr_pages) { > struct page *page; > int off = 0; > > if (WARN_ON_ONCE(s >= nr_subbufs)) > break; I'm not particularly happy about us calling vm_insert_pages with NULL pointers stored in pages. Should we instead do if (WARN_ON_ONCE(s >= nr_subbufs)) { err = -EINVAL; goto out; } ? -- Cheers, David / dhildenb