From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C5C63C3064D for ; Wed, 26 Jun 2024 13:34:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D6F526B008C; Wed, 26 Jun 2024 09:34:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D1E306B0093; Wed, 26 Jun 2024 09:34:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BBF8D6B0095; Wed, 26 Jun 2024 09:34:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 9F07E6B008C for ; Wed, 26 Jun 2024 09:34:50 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 40D8FC1137 for ; Wed, 26 Jun 2024 13:34:50 +0000 (UTC) X-FDA: 82273135140.07.58DA47D Received: from mail-yb1-f172.google.com (mail-yb1-f172.google.com [209.85.219.172]) by imf08.hostedemail.com (Postfix) with ESMTP id 3F302160027 for ; Wed, 26 Jun 2024 13:34:48 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=draconx-ca.20230601.gappssmtp.com header.s=20230601 header.b="G0/qfrOd"; dmarc=none; spf=none (imf08.hostedemail.com: domain of nbowler@draconx.ca has no SPF policy when checking 209.85.219.172) smtp.mailfrom=nbowler@draconx.ca ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1719408876; a=rsa-sha256; cv=none; b=vIhvkzRaIe8uNW98M5x/Z3K0rcO335GH3oG942MCV7ezIrcPTZgBnXdOyiY5OS3JF3Oglt jmE4O79CpfBOtM3/yFfbliW/u6UIhOau/mYwwE/nTXlAlgY/MxH3MZZLUePzO28QXfruqV XrFjOwtB/DM0YGMHDElX5E/McLhYc24= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=draconx-ca.20230601.gappssmtp.com header.s=20230601 header.b="G0/qfrOd"; dmarc=none; spf=none (imf08.hostedemail.com: domain of nbowler@draconx.ca has no SPF policy when checking 209.85.219.172) smtp.mailfrom=nbowler@draconx.ca ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1719408876; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=V2ukVWFT1tyYPa/ZAcJ6dOW3ry3HjmGJ9j874uwa7jY=; b=xQaI1iTVrI4eK2ft3YTZ17dAdV3oTdlKDR59lWfgtVWHakMDKPSTbnkJas4D9sGqBqJg6a jsLxOc3vT3Qo1HrILTbjj1eMxVqMblkM760p7TW4mszfmNHuTLCAfio//1n5hpFpufcJhy VonK6N/iQbPFmU0qg88OVwy7b5qu4Pk= Received: by mail-yb1-f172.google.com with SMTP id 3f1490d57ef6-e033d34987cso292980276.1 for ; Wed, 26 Jun 2024 06:34:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=draconx-ca.20230601.gappssmtp.com; s=20230601; t=1719408887; x=1720013687; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=V2ukVWFT1tyYPa/ZAcJ6dOW3ry3HjmGJ9j874uwa7jY=; b=G0/qfrOdLd9/tAt6ZD4O6aotOU8H84wqpvH8/42Bc0jkCExk5VIaFinTv4xYBBOg29 iyF25WOtSr4f2crknERdcaG9f4K0MOYGclvWEdLpSkGF5009rf6+SM9a7MK0QJTUrxBh bEo4/mRqWWckKJ1AJI9ompIIwYZz2ZO5qzWSTRKgakM1s93V4VrEPBAYoqDxaN0ca/am KUTNHVFyXWQ7rRXW97qvOCJf8GiYI7nSxSFDikVfIs3PHymu7Qg5LSVFA+n4lUMyTIBb ZO+R3NrS0njrgGKl2UMOYMP6Wtq3v/qrzGW1FRd2/oDsPm1brGBWSMK+3XTjrJQF+UCB xoIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719408887; x=1720013687; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=V2ukVWFT1tyYPa/ZAcJ6dOW3ry3HjmGJ9j874uwa7jY=; b=GXK8tYQOVHMylyNxXCmSkpmrcP61qvKXTI6jCnTsB8L955T5KxQQwL4YTzakJ7i3w+ KLp0T5gVnD9OGWC+96AsusjoUBBl60z2rFDsGELo3zU/V04GJEEOFTDtCYAoi3zdbrTm NCukST015sRIj0dfWxsMoKOSF6bQ9eawai+9J0CGELGe7jL8X4cV2FvoUO9N9UUuMmgZ zr+hkVQ7nOrf8wzevzxGowW2XTAldSgRF/52bqoob7kL1Vk5+RpSipi35CyltnWu8JYC qOepB1+QnDrnre0oABz+9pQ+bHkgfCVNk04rfhisYmbhYRAEcti8gRmIDSXAaQDQKTmo +otw== X-Forwarded-Encrypted: i=1; AJvYcCXkkREefR+ZAdTkFPMr0o9iUf4fBpDgwue6yL3L4xMBX5nPg2Q/DnHEIhTOYzE8WJ92SDiYg5Iva/K+o/j7jaJErqQ= X-Gm-Message-State: AOJu0Yy/zZyDeTpGxvBeBuC+XwESLZ+b1E60YHcHAezXdTNDHAYZqaMW Vs3Fxlu30lvA39XKbm5PM4AMiki9hQAoBfpwp+Ufla8SQY3V8p0UtENJaa1kSQk= X-Google-Smtp-Source: AGHT+IEQI8k8PaDkmUreltxCCIhuD3MDFLr14G/kuLv1N8q8FK1w7DZXRPufoe5tRX7CDtMnP4E8Cw== X-Received: by 2002:a5b:f90:0:b0:dfe:fac8:b890 with SMTP id 3f1490d57ef6-e0300fcee40mr10585487276.28.1719408887101; Wed, 26 Jun 2024 06:34:47 -0700 (PDT) Received: from [192.168.0.50] (dhcp-24-53-241-2.cable.user.start.ca. [24.53.241.2]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-444c2c3dc89sm66757551cf.65.2024.06.26.06.34.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 26 Jun 2024 06:34:46 -0700 (PDT) Message-ID: Date: Wed, 26 Jun 2024 09:34:44 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: PROBLEM: kernel crashes when running xfsdump since ~6.4 To: Uladzislau Rezki Cc: Baoquan He , linux-kernel@vger.kernel.org, Linux regressions mailing list , linux-mm@kvack.org, sparclinux@vger.kernel.org, Andrew Morton , Hailong Liu References: <20240626051206.mx2r4iy3wpexykay@oppo.com> <20240626100342.2dudj6fjjx6srban@oppo.com> Content-Language: en-US From: Nick Bowler In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 3F302160027 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: t4ue8c8a713rn7at6n3hfojgfj8aitoz X-HE-Tag: 1719408888-956864 X-HE-Meta: U2FsdGVkX19IwVKTBfM+JO6AEC6+58wm8TeNNBbYz0c+rHXy4ijj6yHPmqEZY6scmCrTJ0wJyp5FHot80t8JEppSkpD6f3QExnXJPB/HqY1aASc7zRIfsQdmC9QCca0QHgBzOlKdT416C2qJu7UKuSPNj5PnkEDNkjaPgy7XMS5z56xIaPSl21z6E4vWyQwLPRoPrdid7JtoFMNN3+IRA0j/TaMCoVm2qXxNSUQXGxXCBF2elTp1uGqsz+qv01SWiKKqNb5ZU0gpYpI2NQ5wyxhi5p5aSXwEgFM8rczTJeBHK2fxJqvc6W7XQdjFrwLUuCZGy0kFwhjtq0IMcGzgoasFo20/BPngqjoUZVPnGo88ynyx0k+WAaiOHbV3hPGOXbg6otopCmu/ZABgkiYb9V7cbGJracUCFYzeCncZ3nRrgF8tnbNS27LgOdqaEsS6SZpWvRvMhRON218aAZK2vJ/N0F8jNeC5lNXIom/wcO8hrY6u2muYb+StqgU67hyBE43ZhkFH1jbrKkLq31Ux5p6E9O0kM7VzgfHnTjtwfnVeZnprdq4cKYB0Hf7sfgyS52Tz5IInmBdx6huPmUf4P8DM2UUvNycSzfNAdqh0lgUoVSIYEkBiOQJqEVQPlbeD0fthtFAMvOZD0CuS7rLi/qVmQfi8CN6Atc0mII4gHUc2uFOGklr0BaN2qceil5ZvH6eIOk8UXKrZSfvbAvLqcaNMwq3JnTimuESZEKOOw6xWXyH9jRRpkVgRkiApyT4fEdFf2Ak8enXDIRMZPzXEisaMhENa3EaLVeA1EzK85Kz5MPLwbp7CoMDnPjm2ImB9lj8cDPzc+FRwaWQqP5UfKCLWApY78KYgSCLCF7tgag1NX1hmSHzrSmBFIEHzDa11ZXYavSLmNeZ88rvqrRdud7K3ApJVWhozwwE9B/VbC7QPpsoFX73enE0bnbXs99lRgZQAvbu6EP39pzWDm3p zC38oCGS RDgQmusr3ij/j2UoqgLi+gbEUDfUNvolPwfS2G8jgbxqBP4i5thS30k+IE69Io2dtT78q9Fg7QBeVtYhW5MXrpP7vmcGekLm8NKKrcDnI/qmWgJv460ljJSoCLinCwuVgAJ4CCMJuas6aEtsn7x5at6MPHrbrd0X7Mre+IzDW+ESe3pTWa+s0wv7R8JMaMzSLadW0ohMfB1wNZa3VVWgT6fqn+cKKm+rDdpCrWSjVtrNViQVNU/iTFU47iS9VbzHQM5tLxseHsUnAt4iUR1mr4i/K1+ccOa5n2T2bOizmuMh5JsrfMqJtZcMftUg/Oq/G9MnK X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024-06-26 06:51, Uladzislau Rezki wrote: [...] > Thank you for pointing this. Below is updated version with extra comment: I checked that I can still reproduce the problem on 6.10-rc5 and with this patch applied on top, xfsdump doesn't crash anymore. > diff --git a/mm/vmalloc.c b/mm/vmalloc.c > index 45e1506d58c3..03b82fb8ecd3 100644 > --- a/mm/vmalloc.c > +++ b/mm/vmalloc.c > @@ -2542,7 +2542,15 @@ static DEFINE_PER_CPU(struct vmap_block_queue, vmap_block_queue); > static struct xarray * > addr_to_vb_xa(unsigned long addr) > { > - int index = (addr / VMAP_BLOCK_SIZE) % num_possible_cpus(); > + int index = (addr / VMAP_BLOCK_SIZE) % nr_cpu_ids; > + > + /* > + * Please note, nr_cpu_ids points on a highest set > + * possible bit, i.e. we never invoke cpumask_next() > + * if an index points on it which is nr_cpu_ids - 1. > + */ > + if (!cpu_possible(index)) > + index = cpumask_next(index, cpu_possible_mask); > > return &per_cpu(vmap_block_queue, index).vmap_blocks; > } Thanks, Nick