From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CD496C02181 for ; Wed, 22 Jan 2025 16:59:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2E519280004; Wed, 22 Jan 2025 11:59:34 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 29467280001; Wed, 22 Jan 2025 11:59:34 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 15CCC280004; Wed, 22 Jan 2025 11:59:34 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id EBC1A280001 for ; Wed, 22 Jan 2025 11:59:33 -0500 (EST) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 7168345874 for ; Wed, 22 Jan 2025 16:59:33 +0000 (UTC) X-FDA: 83035699026.10.F56961D Received: from shelob.surriel.com (shelob.surriel.com [96.67.55.147]) by imf27.hostedemail.com (Postfix) with ESMTP id B9D534001D for ; Wed, 22 Jan 2025 16:59:31 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf27.hostedemail.com: domain of riel@shelob.surriel.com designates 96.67.55.147 as permitted sender) smtp.mailfrom=riel@shelob.surriel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1737565171; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hb2n/eqb1C0Uf1+FxIrdR20lRG4uJi9wrhO02VC+Pow=; b=pRCVc3sPRma6ZImk3uIB1LpK3TXpwsZPix57/DIhCoFvJACKk7mO8e6L4Y5llsQkiSWEJG HVXxRVDMMRG+YMSKK0afepFOGSSMp6qOwtkROJMsXzcLSykMyxWcZPtknnU29HrUWwFLZl R3umvWlRZyZ0m77CY1iEieKeW0oFNzU= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1737565171; a=rsa-sha256; cv=none; b=cLrH41g0UXm3NEUEaCKmLwgl8Xx9NOPs/hReRg9fkPrX2WtAgi1FCLZvklG1rRtSQIzpTG RhPGBRglmxs/tjqTNhQkxQ7VGQPIc4RcfNGSPQMnndbomVQ13ggZ+tPVYVGdIXLoqdAaCh FtrpM5hApCy+IJxdrwAFJxxtryMyKFM= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf27.hostedemail.com: domain of riel@shelob.surriel.com designates 96.67.55.147 as permitted sender) smtp.mailfrom=riel@shelob.surriel.com Received: from fangorn.home.surriel.com ([10.0.13.7]) by shelob.surriel.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.97.1) (envelope-from ) id 1tae3e-000000006bO-3beT; Wed, 22 Jan 2025 11:58:26 -0500 Message-ID: Subject: Re: [PATCH v6 05/12] x86/mm: add INVLPGB support code From: Rik van Riel To: Peter Zijlstra Cc: x86@kernel.org, linux-kernel@vger.kernel.org, bp@alien8.de, dave.hansen@linux.intel.com, zhengqi.arch@bytedance.com, nadav.amit@gmail.com, thomas.lendacky@amd.com, kernel-team@meta.com, linux-mm@kvack.org, akpm@linux-foundation.org, jannh@google.com, mhklinux@outlook.com, andrew.cooper3@citrix.com Date: Wed, 22 Jan 2025 11:58:26 -0500 In-Reply-To: <20250121094540.GA5388@noisy.programming.kicks-ass.net> References: <20250120024104.1924753-1-riel@surriel.com> <20250120024104.1924753-6-riel@surriel.com> <20250121094540.GA5388@noisy.programming.kicks-ass.net> Autocrypt: addr=riel@surriel.com; prefer-encrypt=mutual; keydata=mQENBFIt3aUBCADCK0LicyCYyMa0E1lodCDUBf6G+6C5UXKG1jEYwQu49cc/gUBTTk33A eo2hjn4JinVaPF3zfZprnKMEGGv4dHvEOCPWiNhlz5RtqH3SKJllq2dpeMS9RqbMvDA36rlJIIo47 Z/nl6IA8MDhSqyqdnTY8z7LnQHqq16jAqwo7Ll9qALXz4yG1ZdSCmo80VPetBZZPw7WMjo+1hByv/ lvdFnLfiQ52tayuuC1r9x2qZ/SYWd2M4p/f5CLmvG9UcnkbYFsKWz8bwOBWKg1PQcaYHLx06sHGdY dIDaeVvkIfMFwAprSo5EFU+aes2VB2ZjugOTbkkW2aPSWTRsBhPHhV6dABEBAAG0HlJpayB2YW4gU mllbCA8cmllbEByZWRoYXQuY29tPokBHwQwAQIACQUCW5LcVgIdIAAKCRDOed6ShMTeg05SB/986o gEgdq4byrtaBQKFg5LWfd8e+h+QzLOg/T8mSS3dJzFXe5JBOfvYg7Bj47xXi9I5sM+I9Lu9+1XVb/ r2rGJrU1DwA09TnmyFtK76bgMF0sBEh1ECILYNQTEIemzNFwOWLZZlEhZFRJsZyX+mtEp/WQIygHV WjwuP69VJw+fPQvLOGn4j8W9QXuvhha7u1QJ7mYx4dLGHrZlHdwDsqpvWsW+3rsIqs1BBe5/Itz9o 6y9gLNtQzwmSDioV8KhF85VmYInslhv5tUtMEppfdTLyX4SUKh8ftNIVmH9mXyRCZclSoa6IMd635 Jq1Pj2/Lp64tOzSvN5Y9zaiCc5FucXtB9SaWsgdmFuIFJpZWwgPHJpZWxAc3VycmllbC5jb20+iQE +BBMBAgAoBQJSLd2lAhsjBQkSzAMABgsJCAcDAgYVCAIJCgsEFgIDAQIeAQIXgAAKCRDOed6ShMTe g4PpB/0ZivKYFt0LaB22ssWUrBoeNWCP1NY/lkq2QbPhR3agLB7ZXI97PF2z/5QD9Fuy/FD/jddPx KRTvFCtHcEzTOcFjBmf52uqgt3U40H9GM++0IM0yHusd9EzlaWsbp09vsAV2DwdqS69x9RPbvE/Ne fO5subhocH76okcF/aQiQ+oj2j6LJZGBJBVigOHg+4zyzdDgKM+jp0bvDI51KQ4XfxV593OhvkS3z 3FPx0CE7l62WhWrieHyBblqvkTYgJ6dq4bsYpqxxGJOkQ47WpEUx6onH+rImWmPJbSYGhwBzTo0Mm G1Nb1qGPG+mTrSmJjDRxrwf1zjmYqQreWVSFEt26tBpSaWsgdmFuIFJpZWwgPHJpZWxAZmIuY29tP okBPgQTAQIAKAUCW5LbiAIbIwUJEswDAAYLCQgHAwIGFQgCCQoLBBYCAwECHgECF4AACgkQznneko TE3oOUEQgAsrGxjTC1bGtZyuvyQPcXclap11Ogib6rQywGYu6/Mnkbd6hbyY3wpdyQii/cas2S44N cQj8HkGv91JLVE24/Wt0gITPCH3rLVJJDGQxprHTVDs1t1RAbsbp0XTksZPCNWDGYIBo2aHDwErhI omYQ0Xluo1WBtH/UmHgirHvclsou1Ks9jyTxiPyUKRfae7GNOFiX99+ZlB27P3t8CjtSO831Ij0Ip QrfooZ21YVlUKw0Wy6Ll8EyefyrEYSh8KTm8dQj4O7xxvdg865TLeLpho5PwDRF+/mR3qi8CdGbkE c4pYZQO8UDXUN4S+pe0aTeTqlYw8rRHWF9TnvtpcNzZw== Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.54.1 (3.54.1-1.fc41) MIME-Version: 1.0 X-Stat-Signature: zejcagj884zg8ccs7kj5gx94abyqojy4 X-Rspam-User: X-Rspamd-Queue-Id: B9D534001D X-Rspamd-Server: rspam03 X-HE-Tag: 1737565171-105432 X-HE-Meta: U2FsdGVkX1+7x+PgYQ8eEGk4HUXW7IyJe+ctgUFn+n8hiO7JQL4PMy6hnfVUUGaX0CG2HEimLIOw0lULslMBFuP5ao0dX5JTeUdAmHmG3OSHKWgi0j6var5TRyJNqNks7gBhp33zjVv72tIYNqJGKGYK90RTgZCsOje5gdZ0sQhPDWeGKz0VltS72VpSJ9kuXifIjF3DLW7AwS21BIqm+kafwQANoTfOOwd/p7rJI8BvCULeLhMwYZvelDCVXkbMWoHwHu8Kkagd+lYdlnRNmdRmHpxNQqpOGCD16xCdiLPohy9Ovi4DnO7uMyNhTW65aw2FTPz7JKDWJRRJNUsnKxFTGEo6SMJLJv+bKJyJW147TVz22af549WnGZaLKTK0Exv2/ETUgZBIHjui9aMfduEvgR63IvYjOdm0o2HLqUHUgR7pbc1+sDennCfy3QCl/AVzlafBlJ9lo0J7f5bTWgku+7mdZ0IlyQKoxpRoMKt1j9JDN7CqkCB6PQRJn+4htjZ654MNBUNjMf1bwA+u9qZkT7T35pkmK/pKFylevhUF3Wj+Tq7WMGqNaPeTrJjqQkvHKQqlGVy3yRtMK17MV2ZU+M8wEVI+6wCnchJnwQ8gVI8utqe2+DOR9vwDhF11uvGrK4UZb3X6n9hzrhseQLzHyJcxcNP6j/x0ze+Ohn4fW3jB1UWfYZLAeHru9ieT2LvxcdqVyyl4G2BIqnf9dDrTsVnpQFJnmT5yAw2el6jB+eJZx1uhsbQH//gjqHoQn8B9sheEdlv0BE6zbjFj2ur2RFPQEttNmxoZJc2RHx7Uqk8FKQ4iYtX+KtmPTpNBHSDNLvD2nHd8mzg+/S1SGy+e4ggjRWXC4miIhY931JJE8g92pIFLDHYv3rUUNZ2BwgpwWbjJSVQFNZZpQGAxBz643kdVqN/SZyCJFjugj9P4feFYuUhm4nTQp4EVwrlUjOnO2L+V+ujrPv1I/fL gPvPP1Or IqCPJsGmdw1LYKSrGft/SkodjIjQ+ovlebyEHXCMbs0mqub5WldY1bba4DbyGxVQatD3XTqCCb46cQc7iL46fMlqGZgv4NZp4c5IjH+ZlqdTui388+sMtGchrYqHTFRic0f/UhqNuGxoTqG/eNipAhDm6zi/glM6SpHtX65PlSe2okA+vnthPXsA6Z0hEeEyBgnLQSO64W9GF2c3zn3wk9cFHkSw7OO5Kh5/8L187gV2TuPEBFeCkXlB7LerHnLCIcDzsr5fveUkGffDUlqzM8PZurLlfBYz6/PSx2Fpmu0fkgY9S5zd2RWxUgbqkMHB/xH/TstsPjlJRq+ZARQ1aKn9Ebg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, 2025-01-21 at 10:45 +0100, Peter Zijlstra wrote: > On Sun, Jan 19, 2025 at 09:40:13PM -0500, Rik van Riel wrote: >=20 > >=20 > > +static inline void __invlpgb(unsigned long asid, unsigned long > > pcid, > > + =C2=A0=C2=A0=C2=A0=C2=A0 unsigned long addr, u16 extra_count, > > + =C2=A0=C2=A0=C2=A0=C2=A0 bool pmd_stride, unsigned long flags) > > +{ > > + u32 edx =3D (pcid << 16) | asid; > > + u32 ecx =3D (pmd_stride << 31) | extra_count; > > + u64 rax =3D addr | flags; > > + > > + /* INVLPGB; supported in binutils >=3D 2.36. */ > > + asm volatile(".byte 0x0f, 0x01, 0xfe" : : "a" (rax), "c" > > (ecx), "d" (edx)); > > +} >=20 > So asid is always 0 (for now), but I'd feel better if that was a u16 > argument, less chance funnies when someone starts using it. >=20 > We should probably mask or WARN on addr having low bits set, and > flags > should then be a u8 or something. Done and done. Thank you for the suggestions. --=20 All Rights Reversed.