Re: [PATCH v4 4/4] memcg: implement memory thresholds

["Kirill A. Shutemov" <kirill@shutemov.name>]

On Mon, Dec 28, 2009 at 6:42 AM, Daisuke Nishimura
<nishimura@mxp.nes.nec.co.jp> wrote:
> It would be a nitpick, but my patch(http://marc.info/?l=linux-mm-commits&m=126152804420992&w=2)
> has already modified here.
>
> I think it might be better for you to apply my patches by hand or wait for next mmotm
> to be released to avoid bothering Andrew.
> (There is enough time left till the next merge window :))

I'll rebase it later.

> (snip)
>
>> +static void __mem_cgroup_threshold(struct mem_cgroup *memcg, bool swap)
>> +{
>> +     struct mem_cgroup_threshold_ary *thresholds;
>> +     u64 usage = mem_cgroup_usage(memcg, swap);
>> +     int i, cur;
>> +
> I think calling mem_cgroup_usage() after checking "if(!thresholds)"
> decreases the overhead a little when we don't set any thresholds.
> I've confirmed that the change makes the assembler output different.

Thanks.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>