Re: [BUG?] [PATCH] soft limits and root cgroups

["Kirill A. Shutemov" <kirill@shutemov.name>]

On Mon, Dec 7, 2009 at 8:41 PM, Kirill A. Shutemov <kirill@shutemov.name> wrote:
> Currently, mem_cgroup_update_tree() on root cgroup calls only on
> uncharge, not on charge.
>
> Is it a bug or not?

Any comments?

> Patch to fix, if it's a bug:
>
> diff --git a/mm/memcontrol.c b/mm/memcontrol.c
> index 8aa6026..6babef1 100644
> --- a/mm/memcontrol.c
> +++ b/mm/memcontrol.c
> @@ -1366,13 +1366,15 @@ static int __mem_cgroup_try_charge(struct mm_struct *mm
>                        goto nomem;
>                }
>        }
> +
> +done:
>        /*
>         * Insert ancestor (and ancestor's ancestors), to softlimit RB-tree.
>         * if they exceeds softlimit.
>         */
>        if (mem_cgroup_soft_limit_check(mem))
>                mem_cgroup_update_tree(mem, page);
> -done:
> +
>        return 0;
>  nomem:
>        css_put(&mem->css);
>

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>