From: Mike Kravetz <mike.kravetz@oracle.com>
To: Wei Yang <richardw.yang@linux.intel.com>, Yang Shi <shy828301@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Linux MM <linux-mm@kvack.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mm/migrate.c: also overwrite error when it is bigger than zero
Date: Fri, 17 Jan 2020 17:38:10 -0800 [thread overview]
Message-ID: <cc48623f-329b-ec43-a85a-d9a914ca87bc@oracle.com> (raw)
In-Reply-To: <20200117234829.GA2844@richard>
On 1/17/20 3:48 PM, Wei Yang wrote:
> This is another point I think current code is not working well. And actually,
> the behavior is not well defined or our kernel is broken for a while.
>
> When you look at the man page, it says:
>
> RETURN VALUE
> On success move_pages() returns zero. On error, it returns -1, and sets errno to indicate the error
>
Is this from your migrate_pages(2) man page?
The latest version of the migrate_pages(2) man page in the git repo has this
for RETURN VALUE.
RETURN VALUE
On success migrate_pages() returns the number of pages that could not
be moved (i.e., a return of zero means that all pages were successfully
moved). On error, it returns -1, and sets errno to indicate the error.
--
Mike Kravetz
next prev parent reply other threads:[~2020-01-18 1:38 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-17 7:45 Wei Yang
2020-01-17 22:27 ` Wei Yang
2020-01-17 23:30 ` Yang Shi
2020-01-17 23:48 ` Wei Yang
2020-01-18 1:38 ` Mike Kravetz [this message]
2020-01-19 2:17 ` Wei Yang
2020-01-18 4:56 ` Yang Shi
2020-01-19 2:41 ` Wei Yang
2020-01-19 5:54 ` Yang Shi
2020-01-18 5:32 ` Yang Shi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cc48623f-329b-ec43-a85a-d9a914ca87bc@oracle.com \
--to=mike.kravetz@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=richardw.yang@linux.intel.com \
--cc=shy828301@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox