From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0508DC38A2D for ; Tue, 25 Oct 2022 02:55:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 68CB980008; Mon, 24 Oct 2022 22:55:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6159D80007; Mon, 24 Oct 2022 22:55:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4B61A80008; Mon, 24 Oct 2022 22:55:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 3774E80007 for ; Mon, 24 Oct 2022 22:55:08 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 0C3A01C61A7 for ; Tue, 25 Oct 2022 02:55:08 +0000 (UTC) X-FDA: 80057955096.21.746BF0E Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by imf08.hostedemail.com (Postfix) with ESMTP id 184AE160003 for ; Tue, 25 Oct 2022 02:55:06 +0000 (UTC) Received: from canpemm500002.china.huawei.com (unknown [172.30.72.56]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4MxGkh1B6lzHtv1; Tue, 25 Oct 2022 10:54:52 +0800 (CST) Received: from [10.174.151.185] (10.174.151.185) by canpemm500002.china.huawei.com (7.192.104.244) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Tue, 25 Oct 2022 10:55:03 +0800 Subject: Re: [PATCH 2/3] mm: memory-failure: avoid pfn_valid() twice in soft_offline_page() To: Kefeng Wang CC: , , Naoya Horiguchi , Andrew Morton References: <20221021084611.53765-1-wangkefeng.wang@huawei.com> <20221021084611.53765-2-wangkefeng.wang@huawei.com> From: Miaohe Lin Message-ID: Date: Tue, 25 Oct 2022 10:55:03 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <20221021084611.53765-2-wangkefeng.wang@huawei.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.151.185] X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To canpemm500002.china.huawei.com (7.192.104.244) X-CFilter-Loop: Reflected ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1666666507; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ePMXvLN+m5+LAdXI9xF9wseNqpY4zUZoX3MHaVkRRzg=; b=ZB2XHV8ufBnyX2AfJdkWRk930ofxJ8iVwOLN3kNuNidqpCc/krVYOTi6wZ6AnYI8Sx6r47 iGGAhNvsjm4gP5Wc9GZH7N7ajhKYfvrgviIcdsQIhbV63jUEB4KonbvwiwJjf7gGwm0TQt 0blZW42+C47UAKG7xUPt18eNuZT4bqY= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=none; spf=pass (imf08.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.188 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1666666507; a=rsa-sha256; cv=none; b=cSZu0yvh0GnebOzAFVBZ9OxmneHnwy1EB+B/3gsC2mUQgdDBJoXfGelbmmDGsL/JIC4/p+ RHxImD071hYfN+27e8OKO7vMKwUUF+4OSnrO0Js69QQdVQkJHSwAdq+iBIFxPwfgt6PEMU j2j44akVi+k+EfYp1sfiyNeLlyWtT98= Authentication-Results: imf08.hostedemail.com; dkim=none; spf=pass (imf08.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.188 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com X-Stat-Signature: ge6nabi1pi78bsdykc3op7b6chybdbfw X-Rspamd-Queue-Id: 184AE160003 X-Rspamd-Server: rspam07 X-Rspam-User: X-HE-Tag: 1666666506-55535 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2022/10/21 16:46, Kefeng Wang wrote: > Simplify WARN_ON_ONCE(flags & MF_COUNT_INCREASED) under !pfn_valid(). > > Signed-off-by: Kefeng Wang Reviewed-by: Miaohe Lin Thanks, Miaohe Lin