From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0BB3CC7EE2A for ; Fri, 27 Jun 2025 16:10:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9F77C6B00BB; Fri, 27 Jun 2025 12:10:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9A8A96B00C1; Fri, 27 Jun 2025 12:10:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 86FCF6B00C4; Fri, 27 Jun 2025 12:10:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 6FB156B00BB for ; Fri, 27 Jun 2025 12:10:03 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 1E480120F52 for ; Fri, 27 Jun 2025 16:10:03 +0000 (UTC) X-FDA: 83601667086.26.F7AF4A2 Received: from mail-pf1-f178.google.com (mail-pf1-f178.google.com [209.85.210.178]) by imf19.hostedemail.com (Postfix) with ESMTP id F23851A000F for ; Fri, 27 Jun 2025 16:10:00 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=broadcom.com header.s=google header.b=QeG6lfoh; spf=pass (imf19.hostedemail.com: domain of florian.fainelli@broadcom.com designates 209.85.210.178 as permitted sender) smtp.mailfrom=florian.fainelli@broadcom.com; dmarc=pass (policy=quarantine) header.from=broadcom.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751040601; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=6tajG5R3MCsrP/w0wwPMIBf3LF9dc2Wm7Uf1cjFJKdc=; b=qEKVvIeWjIngO9/NxXMSSMq+TpDCrf6koS1d+m8yBNi622Cslk/K87m9gBITU/sSQTiqK1 QPa/MCO1ARf8bTdZ8BOq1Vqrs/BrUkXk+NV2a4eZ4CMUbTDlnd/ENdwXYCfCxE3UGBoWpl tf2/Xe9HMssg9IdzPZQiS3mZGowD+7U= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1751040601; a=rsa-sha256; cv=none; b=8d8RO6t7ZxL04USMRfuE7iGwAhWb5qldP61hk1zYSLilYlteNe9D+5d7pNSYxBwUHW1ctm 1FFwprWCm+86M8Ac5RVFh/PfUTxbivC8QE+pHpdptYzuBJ+QtCzh/6ci7Bon8YfEJU0jXt G6CsNXp1p0byZCw+EXLSdto5TujiMVE= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=broadcom.com header.s=google header.b=QeG6lfoh; spf=pass (imf19.hostedemail.com: domain of florian.fainelli@broadcom.com designates 209.85.210.178 as permitted sender) smtp.mailfrom=florian.fainelli@broadcom.com; dmarc=pass (policy=quarantine) header.from=broadcom.com Received: by mail-pf1-f178.google.com with SMTP id d2e1a72fcca58-748d982e92cso1994359b3a.1 for ; Fri, 27 Jun 2025 09:10:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1751040600; x=1751645400; darn=kvack.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=6tajG5R3MCsrP/w0wwPMIBf3LF9dc2Wm7Uf1cjFJKdc=; b=QeG6lfohp7JEyJxv+M7xIM+KvlcCCuBsatuYpAJxfiLYEyBsju8UgezBXouqb7w5CW 9JHTeIfjAQ7K14Yv5efu8AkldCZjUjP5Fku//SUl4IHf1hOD5irNyFfkRWM5JbvdPwd7 51DWZezxg62OO0hZnNTP7WF/7gJoBCPz7ethU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751040600; x=1751645400; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=6tajG5R3MCsrP/w0wwPMIBf3LF9dc2Wm7Uf1cjFJKdc=; b=oYhxviAlFQLr20/TMAhTzfZA/+S2IT2pOX6JobR6BrfTirw7dv6dMrrfcbRBJeKdwk EqPIpB5uFNrIFsBBsD0WXaXcYJVXoNm7RUQ+cBsFyWj1aPOKWAKMzyNubqviWovrjZz7 Uplx6BA8y42Yuhym+0Zc22yRMSZ1LBdKoIO62v5KSEJtzPSAeF3vQ2oPFXTAfXSTyVMR a5u7hhUSu6G7OzEo2DGb9HD2Svapa+ispfY95X3tYAWpU/ZpBrGPSYHLCzMsMsZYHWGN +Cy0MFKGvWL4BZkUuOFPh0f+b9D6r1eO+j/w5tnlB/e1TABUL3APhU9lLFNqHOGHKcR7 VfHw== X-Forwarded-Encrypted: i=1; AJvYcCW2rj6O8O+VLzJy8yrRjymDjP25Pa7T4+1P75iq9PxPnUQIF6ZrUb5VcDPzMxdHiGHocW1MJu6O+g==@kvack.org X-Gm-Message-State: AOJu0YyP63emK2H2Z/NsVoLDVqdyq1kXJ+hV1gmJNkDVQ5hn4fAxqQqA beNZJKrWIBGf+oZsR8q72wEexLlwjkY/tC9O4wVd2YL5WNe8PrMnsSEKBca6JbVpzg== X-Gm-Gg: ASbGncs0TpnIZFuu1RhzY74B+mGAY8tLraZyRn4tApXiUnlBNxV25BqZze3Nvgs2i4/ QllPKU4wTPzAT3Kt+ALKOCve0LvaqY9ZmaXK7KC1aKyOVOK+kelg2ulP0+rVywBYjsCX1csKZYQ sqGfR34xdMvuGI7hGlOeFeCmX9bHyD2njk5iUK1jgjmJ65uXoL/ajgEjU7surtTpJwL3WNdoTtX ipaADoTE8QpkLRvjnDjGhl9zE1QWNGuPATPP1Tw6+q5I21e4kXJd3FIRv5K96GFJad86i0wi+mn aQDMjnBq+qOAhDUKDG7cHb2PlS5hFFtHqJwnAvW3fnamkfRoekKGYUPZRHVRwRdw+yi+AzeiuTF e7KYAsDSvDlhHmUrBsu2BLcwh6w== X-Google-Smtp-Source: AGHT+IGphu6TPIxsadsg8AJvhSvpk9h0/WSLUUO4UG0XTFbdDPP5hlzrX20zsMC3uarGOiW78rocGg== X-Received: by 2002:a17:902:f709:b0:235:779:edea with SMTP id d9443c01a7336-23ac465d24fmr64232725ad.38.1751040599657; Fri, 27 Jun 2025 09:09:59 -0700 (PDT) Received: from [10.67.48.245] ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-23acb2e1b3esm18966805ad.35.2025.06.27.09.09.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 27 Jun 2025 09:09:58 -0700 (PDT) Message-ID: Date: Fri, 27 Jun 2025 09:09:53 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 00/16] MAINTAINERS: Include GDB scripts under their relevant subsystems To: Jan Kara Cc: "Liam R. Howlett" , linux-kernel@vger.kernel.org, Jan Kiszka , Kieran Bingham , Michael Turquette , Stephen Boyd , Dennis Zhou , Tejun Heo , Christoph Lameter , Greg Kroah-Hartman , "Rafael J. Wysocki" , Danilo Krummrich , Petr Mladek , Steven Rostedt , John Ogness , Sergey Senozhatsky , Ulf Hansson , Thomas Gleixner , Andrey Ryabinin , Alexander Potapenko , Andrey Konovalov , Dmitry Vyukov , Vincenzo Frascino , Andrew Morton , Luis Chamberlain , Petr Pavlu , Sami Tolvanen , Daniel Gomez , Kent Overstreet , Anna-Maria Behnsen , Frederic Weisbecker , Alexander Viro , Christian Brauner , Uladzislau Rezki , Matthew Wilcox , Kuan-Ying Lee , Ilya Leoshkevich , Etienne Buira , Antonio Quartulli , Illia Ostapyshyn , "open list:COMMON CLK FRAMEWORK" , "open list:PER-CPU MEMORY ALLOCATOR" , "open list:GENERIC PM DOMAINS" , "open list:KASAN" , "open list:MAPLE TREE" , "open list:MODULE SUPPORT" , "open list:PROC FILESYSTEM" References: <20250625231053.1134589-1-florian.fainelli@broadcom.com> Content-Language: en-US From: Florian Fainelli Autocrypt: addr=florian.fainelli@broadcom.com; keydata= xsBNBFPAG8ABCAC3EO02urEwipgbUNJ1r6oI2Vr/+uE389lSEShN2PmL3MVnzhViSAtrYxeT M0Txqn1tOWoIc4QUl6Ggqf5KP6FoRkCrgMMTnUAINsINYXK+3OLe7HjP10h2jDRX4Ajs4Ghs JrZOBru6rH0YrgAhr6O5gG7NE1jhly+EsOa2MpwOiXO4DE/YKZGuVe6Bh87WqmILs9KvnNrQ PcycQnYKTVpqE95d4M824M5cuRB6D1GrYovCsjA9uxo22kPdOoQRAu5gBBn3AdtALFyQj9DQ KQuc39/i/Kt6XLZ/RsBc6qLs+p+JnEuPJngTSfWvzGjpx0nkwCMi4yBb+xk7Hki4kEslABEB AAHNMEZsb3JpYW4gRmFpbmVsbGkgPGZsb3JpYW4uZmFpbmVsbGlAYnJvYWRjb20uY29tPsLB IQQQAQgAywUCZWl41AUJI+Jo+hcKAAG/SMv+fS3xUQWa0NryPuoRGjsA3SAUAAAAAAAWAAFr ZXktdXNhZ2UtbWFza0BwZ3AuY29tjDAUgAAAAAAgAAdwcmVmZXJyZWQtZW1haWwtZW5jb2Rp bmdAcGdwLmNvbXBncG1pbWUICwkIBwMCAQoFF4AAAAAZGGxkYXA6Ly9rZXlzLmJyb2FkY29t Lm5ldAUbAwAAAAMWAgEFHgEAAAAEFQgJChYhBNXZKpfnkVze1+R8aIExtcQpvGagAAoJEIEx tcQpvGagWPEH/2l0DNr9QkTwJUxOoP9wgHfmVhqc0ZlDsBFv91I3BbhGKI5UATbipKNqG13Z TsBrJHcrnCqnTRS+8n9/myOF0ng2A4YT0EJnayzHugXm+hrkO5O9UEPJ8a+0553VqyoFhHqA zjxj8fUu1px5cbb4R9G4UAySqyeLLeqnYLCKb4+GklGSBGsLMYvLmIDNYlkhMdnnzsSUAS61 WJYW6jjnzMwuKJ0ZHv7xZvSHyhIsFRiYiEs44kiYjbUUMcXor/uLEuTIazGrE3MahuGdjpT2 IOjoMiTsbMc0yfhHp6G/2E769oDXMVxCCbMVpA+LUtVIQEA+8Zr6mX0Yk4nDS7OiBlvOwE0E U8AbwQEIAKxr71oqe+0+MYCc7WafWEcpQHFUwvYLcdBoOnmJPxDwDRpvU5LhqSPvk/yJdh9k 4xUDQu3rm1qIW2I9Puk5n/Jz/lZsqGw8T13DKyu8eMcvaA/irm9lX9El27DPHy/0qsxmxVmU pu9y9S+BmaMb2CM9IuyxMWEl9ruWFS2jAWh/R8CrdnL6+zLk60R7XGzmSJqF09vYNlJ6Bdbs MWDXkYWWP5Ub1ZJGNJQ4qT7g8IN0qXxzLQsmz6tbgLMEHYBGx80bBF8AkdThd6SLhreCN7Uh IR/5NXGqotAZao2xlDpJLuOMQtoH9WVNuuxQQZHVd8if+yp6yRJ5DAmIUt5CCPcAEQEAAcLB gQQYAQIBKwUCU8AbwgUbDAAAAMBdIAQZAQgABgUCU8AbwQAKCRCTYAaomC8PVQ0VCACWk3n+ obFABEp5Rg6Qvspi9kWXcwCcfZV41OIYWhXMoc57ssjCand5noZi8bKg0bxw4qsg+9cNgZ3P N/DFWcNKcAT3Z2/4fTnJqdJS//YcEhlr8uGs+ZWFcqAPbteFCM4dGDRruo69IrHfyyQGx16s CcFlrN8vD066RKevFepb/ml7eYEdN5SRALyEdQMKeCSf3mectdoECEqdF/MWpfWIYQ1hEfdm C2Kztm+h3Nkt9ZQLqc3wsPJZmbD9T0c9Rphfypgw/SfTf2/CHoYVkKqwUIzI59itl5Lze+R5 wDByhWHx2Ud2R7SudmT9XK1e0x7W7a5z11Q6vrzuED5nQvkhAAoJEIExtcQpvGagugcIAJd5 EYe6KM6Y6RvI6TvHp+QgbU5dxvjqSiSvam0Ms3QrLidCtantcGT2Wz/2PlbZqkoJxMQc40rb fXa4xQSvJYj0GWpadrDJUvUu3LEsunDCxdWrmbmwGRKqZraV2oG7YEddmDqOe0Xm/NxeSobc MIlnaE6V0U8f5zNHB7Y46yJjjYT/Ds1TJo3pvwevDWPvv6rdBeV07D9s43frUS6xYd1uFxHC 7dZYWJjZmyUf5evr1W1gCgwLXG0PEi9n3qmz1lelQ8lSocmvxBKtMbX/OKhAfuP/iIwnTsww 95A2SaPiQZA51NywV8OFgsN0ITl2PlZ4Tp9hHERDe6nQCsNI/Us= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: F23851A000F X-Stat-Signature: sxusakdyhyzasydh1k5ffkeeg79cqn6h X-Rspam-User: X-HE-Tag: 1751040600-89367 X-HE-Meta: U2FsdGVkX19nNdO8gc2gIeCl7EEO+z1iADjxFuxjkjZikDKt2+ThcKVUKEF9WXMOLm5NJ8lYOnVy0NnKiVRv4WLHkVdUvDSv3lKe90FaiTrtRfxiFrGaXLDCGMqMTAipNHwQk5TAt/LvIUsu5z49i9xWYGUR738DuC/WQY8MmBk3QUMZqRbCrLD2SkFamHfFB6a0MZnNrfhV7Mb1/U7UN8gcWmI0jhX7LoHXNisg+e2p6ZgU2o1HzuNBompchpdInBzFXo6T3FjDOKSFvaowY8Yb1Rzf9c2OC+2nAhffpR1/sFn6PW33ULs2Dz50YFdt8QLB2lS6zwOWIbbcJt4DviL3ozrxnMJPk12fSPAlNEqvkfCGwP2nPHTUsLxz4qf6Fmla0/J03YuNUo6qXBBi2X/RPQC4/Us5wdK3rnZ5E1UMkyhq1KDS3Iyt/eY4pfVzc0NrdwAEp17DNfVGWnkcZ6lAyjMsr9/mMIKVfwO1hMfAtIVzXeQXOl+U/ryq1gOR20pXJBF+VgoHSpnghWPUUuUv0IwsVYsyDYCi/2D82XNxCJA03tDbL1SbxfETaqQU2OBtzg3jHjddYFdqe+vt1XGRKrwaL3r38TyE31SWzCJpy8l7AIS8Oa64CIHJsdwaqmcO7f4SFfQsqX09iP6ogzvpu+0jRBE6LLXqIlQMDHzxLiwN+y400DpvLnX89Nlvv6z3EJkA7WxfkJyViInUFq+nIQl6vEnnMnDUbKxEiDkiasILxiR50pv5f/t+nHALeD37DGNu50xNRxgpCXPyt/RLehJjBqq7srBERTGYOPUMrOKEKC5BgVglsaLuUIQtCCpPEHcrOpibzg5IWbRvsGbozoi4o9N2M4dEwYbXDT1hsZukEm9j75V2KxIvKYra9kAv3jFRy8tVbtzmlvgU44MsxbAuwN2wJ8lhTfQBsZZJ93DsMX6aPON8GcHMNjIkBZin3CvNsC+Mi3oVWOo TLuPjbeT OcZ1qu47QEiK0V9KJOLd8a5WQeqzhHcFccgXwl9VbanICDRw06qTQuL8KJkL96hXDhHRboZ9qR0PYnqtrNnIh0kDQbG3OUJs/Fqykk4gkWXrAxp9z6ZPvxofDluqgcLRMaRjg9ctZxQIw81DmKfD4e8V/bozf9kwl0kiu4WuB+W++d/PquUsIlYqnOKtVm6Y97Yior+SCzqOSK/KlpGQZcWNuKe++t9FVhbuzQLTdgHUgdkUqbUiHaRH0DzdZCjAOqdgboW4fB7zUzqfvCFwGZM1VxAPWt5xaITh8Qy+hUjpO+5gji5Vh77tZqAsmIV0J8J1w5yZjyD6CTEbXLRdS5V5i0arw9OkSA+gE+EWmk7YniZt0ponMoKSE4JvTU8HlLsf6LdE464SuOZ9p2lRVPIIrWHXzg1ZQHtixi2mlqI9acmkWp0ZvHs72KQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 6/27/25 00:55, Jan Kara wrote: > On Thu 26-06-25 09:39:36, Florian Fainelli wrote: >> On 6/26/25 09:17, Liam R. Howlett wrote: >>> * Florian Fainelli [250625 19:13]: >>>> Linux has a number of very useful GDB scripts under scripts/gdb/linux/* >>>> that provide OS awareness for debuggers and allows for debugging of a >>>> variety of data structures (lists, timers, radix tree, mapletree, etc.) >>>> as well as subsystems (clocks, devices, classes, busses, etc.). >>>> >>>> These scripts are typically maintained in isolation from the subsystem >>>> that they parse the data structures and symbols of, which can lead to >>>> people playing catch up with fixing bugs or updating the script to work >>>> with updates made to the internal APIs/objects etc. Here are some >>>> recents examples: >>>> >>>> https://lore.kernel.org/all/20250601055027.3661480-1-tony.ambardar@gmail.com/ >>>> https://lore.kernel.org/all/20250619225105.320729-1-florian.fainelli@broadcom.com/ >>>> https://lore.kernel.org/all/20250625021020.1056930-1-florian.fainelli@broadcom.com/ >>>> >>>> This patch series is intentionally split such that each subsystem >>>> maintainer can decide whether to accept the extra >>>> review/maintenance/guidance that can be offered when GDB scripts are >>>> being updated or added. >>> >>> I don't see why you think it was okay to propose this in the way you >>> have gone about it. Looking at the mailing list, you've been around for >>> a while. >> >> This should probably have been posted as RFC rather than PATCH, but as I >> indicate in the cover letter this is broken down to allow maintainers like >> yourself to accept/reject >> >>> >>> The file you are telling me about seems to be extremely new and I needed >>> to pull akpm/mm-new to discover where it came from.. because you never >>> Cc'ed me on the file you are asking me to own. >> >> Yes, that file is very new indeed, and my bad for not copying you on it. >> >> I was not planning on burning an entire day worth of work to transition the >> GDB scripts dumping the interrupt tree away from a radix tree to a maple >> tree. All of which happens with the author of that conversion having >> absolutely no idea that broke anything in the tree because very few people >> know about the Python GDB scripts that Linux has. It is not pleasant to be >> playing catch when it would have take maybe an extra couple hours for >> someone intimately familiar with the maple tree to come up with a suitable >> implementation replacement for mtree_load(). >> >> So having done it felt like there is a maintenance void that needs to be >> filled, hence this patch set. > > I can see that it takes a lot of time to do a major update of a gdb > debugging script after some refactoring like this. OTOH mandating some gdb > scripts update is adding non-trivial amount of work to changes that are > already hard enough to do as is. This really should have been posted as RFC, because I can see how posting this as PATCH would be seen as coercing maintainers into taking those GDB scripts under their umbrella. > And the obvious question is what is the > value? I've personally never used these gdb scripts and never felt a strong > need for something like that. People have various debugging aids (like BPF > scripts, gdb scripts, there's crash tool and drgn, and many more) lying > around. Those are valuable tools in the tool box, but GDB scripts can work when your only debug tool accessible is JTAG for instance, I appreciate this is typically miles away from what most of the kernel community does, but this is quite typical and common in embedded systems. When you operate in that environment, having a decent amount of debugger awareness of what is being debugged is immensely valuable in saving time. > I'm personally of an opinion that it is not a responsibility of > the person doing refactoring to make life easier for them or even fixing > them and I don't think that the fact that some debug aid is under > scripts/gdb/ directory is making it more special. That is really the question that I am trying to get answered with this patch series. IMHO as a subsystem maintainer it is not fair to be completely oblivious to scripts that live in the source tree, even if you are not aware of those. > So at least as far as I'm> concerned (VFS, fsnotify and other filesystem related stuff) I don't plan > on requiring updates to gdb scripts from people doing changes or otherwise > actively maintain them. vfs.py script is beyond trivial, the largest and most complicated IMHO is mapletree.py which had to be recently developed to continue to support parsing the interrupt descriptor tree in the kernel, I can maintain that one now that I know a lot more than I ever wished I knew about maple trees. So really the burden is not as big as it may seem but it's fair not to be taking on more work as a maintainer, I get that. Thanks for your feedback! -- Florian