From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F1E58C02183 for ; Fri, 17 Jan 2025 11:02:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3A39D280002; Fri, 17 Jan 2025 06:02:11 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 35494280001; Fri, 17 Jan 2025 06:02:11 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 21B9E280002; Fri, 17 Jan 2025 06:02:11 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 034B7280001 for ; Fri, 17 Jan 2025 06:02:10 -0500 (EST) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 8D4241C8EB7 for ; Fri, 17 Jan 2025 11:02:10 +0000 (UTC) X-FDA: 83016654420.15.361F15B Received: from mail-ej1-f46.google.com (mail-ej1-f46.google.com [209.85.218.46]) by imf29.hostedemail.com (Postfix) with ESMTP id 86AD0120007 for ; Fri, 17 Jan 2025 11:02:08 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=MMG4kMSv; spf=pass (imf29.hostedemail.com: domain of usamaarif642@gmail.com designates 209.85.218.46 as permitted sender) smtp.mailfrom=usamaarif642@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1737111728; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=EA5M3bAfFnzDsmtQjt8A8lchVa11A3dw+btjzntpGUM=; b=HeB8ey6gPrw4Inq1ao+R9tCzxEQFSsgZt8TQK54z9tF+CWypG0G4AX9JvgczoLfUs6dWYf BRmXeMXfdXZRDe0+T027ovIU+RJjm+xFhixrfVPSNGq9RUb1kFtr4LEdP+aymYzpRLAqrX SMUtyJsP30dFj0i2sAywdqwhmVXvUJY= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=MMG4kMSv; spf=pass (imf29.hostedemail.com: domain of usamaarif642@gmail.com designates 209.85.218.46 as permitted sender) smtp.mailfrom=usamaarif642@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1737111728; a=rsa-sha256; cv=none; b=elAlj+ZENhLm2pv2opAHu7EtwQBVGXhUWmvgg55WhuonN3iAvQWkfp4+CHQSxBjgN9etMh r3Y4Tv1Q0jI2+gO35b9Ir7L+WKyHzkUA7cz78FQTkAVCOh23eMTdha3fsT7FtLJ4Uatr57 3mNXM2ROO8UGJcVXY6aZi/2Jr4RctRY= Received: by mail-ej1-f46.google.com with SMTP id a640c23a62f3a-aaf900cc7fbso328037866b.3 for ; Fri, 17 Jan 2025 03:02:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1737111727; x=1737716527; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=EA5M3bAfFnzDsmtQjt8A8lchVa11A3dw+btjzntpGUM=; b=MMG4kMSvR0I8iOqgiApU28cTT0kAkeHUnDWJSfbn7YXUyoXDrhuex9+/szxoBq+lVy Z6NEj/h0h14sM/9m13Dq0ZoQTEnYGMRho2pnZk1Tn2o5iHhxnqL4Hk8YOTsJEpCbRBNB iuOGbYtz1ily2YEt1PyyTeKhIQXdr5OhMHQLgD2fkykTlKxCSjuS7GptWWFNl9lW2l6X V9d1Qedhb28DXDm0I8GfWq/nKRoYSehRCLWgIPnpZnTbJ0EulYvhgAR+qUwVrn2815jO PhRxPSDsEvh6Ti4oY4IPxmFCx0Svkfr37Y7Em7YJQ6uIt8LbVjSTBj99VByUGYhrFZJ9 qtJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737111727; x=1737716527; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=EA5M3bAfFnzDsmtQjt8A8lchVa11A3dw+btjzntpGUM=; b=OfXbL+giSdCEYs9Pf2Cj1msY2+1Stz46TMn7Bb9byBzWS+faY4nQroQl7swlVe4bVb +FmzScKmhoyUonXbrvW/6yQU4JY1oiCcdAU+tGixQOBFGmdlII8sEjwc3Ok0CBgzfPJB 8Svprw9nKI7CJ95Vse6Hp1r9DgHLm7sLBTWnguZbVk3H01T4JlLrWIIOlHnb7PIDySJn Ilc4jbwXgmQ10rYOa9EGxCQ6Pd5eOFGFgurFcDnfor5l6cIUgqtL1eqQ7fKwUSxA1H5j AJYuI+ibrvZoTDbpGH8rzQl0F+uZgAZuwK4qLecdi108pqXFZRNB5+7xq0W+Rd1ABlE1 FNKA== X-Forwarded-Encrypted: i=1; AJvYcCWm/G4Mho76TBZoiXmJyfRAL1f0zqThHQcmfq2wqD7ulFMz8b3TDRMmDV7wvvBnSbdN1US7iSpVQg==@kvack.org X-Gm-Message-State: AOJu0Yx1X/DUfCn5KQVXK3iAX0vww1KCuC9tz/6SJ8y1s/h/hbC6Ae0f z87E/FVeOlCg9AzpsIsesfEqmcvRpwumB3Za2ypPK+X9Y7YjuswG X-Gm-Gg: ASbGncszNEXsFPZoZX6BewhmU3rOD4Lc9DJgSH+cTpr1200IdxBQKFDI66fQo0BdmDO 8BbF9THwiE2xU7RW9zArkuGMsERc5v3PGZC2Rm1HW7ApA83+S2PzE3Aa1ePMS6gsWedDocfOVZP X0kf3sPya5n/ekefn51guLIv43qOg1Zr/CIJ0/mIdFlKpX+BeeNzRYyHBKzS3mUIKhuofMxrILK eIKjW73LEoUM8UvKqK74SlCD7Gh5jUpWOoJ4LauhTYPQFjO4ogyd/xtPa0HHvmEBAPT53yCTy6v vCzuWkWOTmgY++Z0CuWMpgsNeJ8= X-Google-Smtp-Source: AGHT+IEGC1ZgARi46+pC7dCZTldk4y179bi/5kRfniOiHqeArKAwsMI4uPcGua64Xo+9gL6bJpqkzw== X-Received: by 2002:a17:907:1b1b:b0:aac:619:e914 with SMTP id a640c23a62f3a-ab38b10cf76mr214477366b.16.1737111726555; Fri, 17 Jan 2025 03:02:06 -0800 (PST) Received: from ?IPV6:2a03:83e0:1126:4:829:739b:3caa:6500? ([2620:10d:c092:500::7:c5e]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ab384f87d7bsm149916266b.128.2025.01.17.03.02.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 17 Jan 2025 03:02:06 -0800 (PST) Message-ID: Date: Fri, 17 Jan 2025 11:02:05 +0000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [v1 2/2] mm/damon: introduce DAMOS filter type hugepage To: SeongJae Park Cc: akpm@linux-foundation.org, damon@lists.linux.dev, linux-mm@kvack.org References: <20250116190538.60331-1-sj@kernel.org> Content-Language: en-US From: Usama Arif In-Reply-To: <20250116190538.60331-1-sj@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 86AD0120007 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: jmazjwziz9qqtee3cuos3wau3y4ff54s X-HE-Tag: 1737111728-251893 X-HE-Meta: U2FsdGVkX19krd7hAO3+OsGiNuHZn7w/2eAYO5AUA0l0FPRjIifcm38j71H5h+xQji90TFftJW7efBNsqVOKBMi8kg38TMD4me1FBXRcFGNY6lnKeBa4ine0vP/smmODKH0FKq0LwzJxwwLU3+z4uVKdx9zuAIPFahzmODCVrC4uUFO2Dc7HEvr1KmBR/9LijQKgirW6oev6vOc03rEGNFTauT5NzthRiKzZHMdGUyF6muYMjROLugEUXzqFck/m91dZAiDCMEGOFZNWZcLH8c0clepg+dkPTKF+TQOM2d0f8mGM8Se+eC7bjQspJ4VOmaUvo8rKUHSJwQXtJEzeQjUlD3cN4iJNVi3Ajk1kPDaqlP8NY81dV4s6hY1Zhu8Zj1Yh5asqMQ0UOqVD/eERZlJyJvoEwqTcD6mAg02i2zfzbK+EV+nIATazhZCGA5+Vc3MARasJEl4t9G5M87ukFowM9b/6hg8CUr8dmpjdfJIdL5MBhNbPXq927WP6hcDT1Sl1OUn4uWSg0vxm8+PiINR8+/pqrW31cJuQW46bFWum1EKWcypXT/YNwdC5HvK4nYR/RMPEeQVBgA5gtd0GjCySoePi3PvqzOz+kgfs5/pTivU/hUWeFaKTgldrh0d1bwyWOUR/6yPfVkTrDmBkywrNaC8fuRjDofYZakXevmw5Ejn6l4bFUJEYa5nCIbXCebW0DHWaaJgKaXTtj9Eih5i+A0eOxBXU/8/CuBGSdTvyhcyBu+dnUB21AE+838lc0wU77qIkdqNgFy/xhoJktLMMmWEbivwuYcWW5y1NVnSxnMwAVv+6abnPu00p8QGHfi5cINYzB1JBtaRD7VcU2vx8RQgzLjqBkZASo0Ji+LnSkKojuMUlerzb5eAHl6lSZT+BWta3iY25bkFpJW17jneuEXpsV5pad18RYcmkEEirHEqxgIwh4Yt1qU46Gl0oTyNSQ8NGnQQNzmMpTiY kwLiN3hg oVNX87yx/aGfpdFe1C1RpdVw7Kp+ce/iTGPfFIsfOKpMY8b5pu/DfDhPiRixGjA/vlnS4DbPa7esE4ib+z/RCdRupzDM5txjDnvSRRdwlVwjt0SkMyYfzoVr+JcZWI02KhGHrbnwHnktXUGyAfhwqhQ0FBt2pkh3tcFKvJov/1GmCXrRWFV9Aqap4pkTyO9EhB8GZVFGCGqxdOgRkesdAOHuZjjAm8entJFwl6i5fdUZfiYNKLrP+f1/7HWml3LIw9TcLZ+scwPGgtTNQY8sMF9ljevIGidAllO2uuMXAa9Vl8FQcOaHVb+3bCpGrH9eMn6Wd+dDZXPuM2MD3VKoOBJeDVKrnacAeNggxjclLxLCjwZpfDtyuizjJthK1PHWkd1jvGnT9WWUU2f8OMBtSCv6ouN9YZltOYCx2lXgV4rSQbO8Wpp2Y89oz+a9SJNeJp+vKb98w4LhlPX2v8PKaV1Dz9bYsQCUTVy+7owAE4oS/j1MQA2y7AVKRnIPizWI9/mc+ X-Bogosity: Ham, tests=bogofilter, spamicity=0.265235, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 16/01/2025 19:05, SeongJae Park wrote: > On Thu, 16 Jan 2025 14:44:36 +0000 Usama Arif wrote: > >> diff --git a/mm/damon/paddr.c b/mm/damon/paddr.c >> index c0ccf4fade24..a9e69179d45c 100644 >> --- a/mm/damon/paddr.c >> +++ b/mm/damon/paddr.c >> @@ -222,6 +222,9 @@ static bool damos_pa_filter_match(struct damos_filter *filter, >> if (matched) >> damon_folio_mkold(folio); >> break; >> + case DAMOS_FILTER_TYPE_HUGEPAGE: >> + matched = folio_size(folio) == HPAGE_PMD_SIZE; >> + break; > > This will make build fails when CONFIG_PGTABLE_HAS_HUGE_LEAVES is not set, like > below: > > /include/linux/compiler_types.h:542:45: error: call to ‘__compiletime_assert_321’ declared with attribute error: BUILD_BUG failed > 542 | _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__) > | ^ > [...] > /include/linux/huge_mm.h:111:35: note: in expansion of macro ‘HPAGE_PMD_SHIFT’ > 111 | #define HPAGE_PMD_SIZE ((1UL) << HPAGE_PMD_SHIFT) > | ^~~~~~~~~~~~~~~ > /mm/damon/paddr.c:321:48: note: in expansion of macro ‘HPAGE_PMD_SIZE’ > 321 | matched = folio_size(folio) == HPAGE_PMD_SIZE; > | ^~~~~~~~~~~~~~ > > > This simple test might help you reproducing it: > https://github.com/damonitor/damon-tests/blob/master/corr/tests/build_i386.sh > > What about enclosing the entire case with > > #if defined(CONFIG_TRANSPARENT_HUGEPAGE) || defined(CONFIG_HUGETLB_PAGE) ? > Ah Thanks for pointing this out! Would #if defined(CONFIG_PGTABLE_HAS_HUGE_LEAVES) be better?