From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C6106C8303C for ; Wed, 9 Jul 2025 02:55:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4A7886B00B0; Tue, 8 Jul 2025 22:55:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 458906B00B1; Tue, 8 Jul 2025 22:55:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 36F3E6B00B2; Tue, 8 Jul 2025 22:55:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 25B5B6B00B0 for ; Tue, 8 Jul 2025 22:55:19 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id C7F8A53BE3 for ; Wed, 9 Jul 2025 02:55:18 +0000 (UTC) X-FDA: 83643209916.22.8A8C8D2 Received: from out30-132.freemail.mail.aliyun.com (out30-132.freemail.mail.aliyun.com [115.124.30.132]) by imf28.hostedemail.com (Postfix) with ESMTP id CB506C0012 for ; Wed, 9 Jul 2025 02:55:15 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=nxxhCeYl; dmarc=pass (policy=none) header.from=linux.alibaba.com; spf=pass (imf28.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.132 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1752029717; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Igjpbs2IFvXqbYourUEIXZWbcdP5LNhfPWCOH6TZgg0=; b=U+2FXH6N/MgdWHfk8qafx6a/aIicM5KXTsB8Iln0VqxtN9v43RdX631VcSWmw+Gf39MqCL 51hcXyaOFsRtZmMYDolKfdvibWx7ceDT9DRZN1iyvsuV6RtMmVnh7F8fkoYel04AMS5GQx cbLZ8dQjE4OlX7MUbsoPfB68yFo6K0c= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1752029717; a=rsa-sha256; cv=none; b=yypmguJbx06K68McO7L7YjXcB4fHrSrC6VK+0VjSIJl/I46CPnqB3BkP4lf9wwvZ4/pqpm fJOs7FS0yEv3SbqD2bDQa4bGqUV47WVhUfaaCnFUyjl4fNGzo15lgTebncO1uua89k5GII 7/r42hmzSy5hrfxgSLu3uj1xr8elltQ= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=nxxhCeYl; dmarc=pass (policy=none) header.from=linux.alibaba.com; spf=pass (imf28.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.132 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com DKIM-Signature:v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.alibaba.com; s=default; t=1752029713; h=Message-ID:Date:MIME-Version:Subject:To:From:Content-Type; bh=Igjpbs2IFvXqbYourUEIXZWbcdP5LNhfPWCOH6TZgg0=; b=nxxhCeYlGo02v4qBt1bcQEhYShGYGr2weH70pdFhJWqufpqqmkXFSw2Tqw1MX5WUVbalgoVvue5nVfmpp6GC1goFpZsq+KxHRj8+gzp0Mh1EQvfzX8C+EPsJ04wKrZGJhp4VALaDtcsTT3/SCS6/kFi0V9/DYggMp9ABvOCAXyg= Received: from 30.74.144.112(mailfrom:baolin.wang@linux.alibaba.com fp:SMTPD_---0WiVurL8_1752029709 cluster:ay36) by smtp.aliyun-inc.com; Wed, 09 Jul 2025 10:55:10 +0800 Message-ID: Date: Wed, 9 Jul 2025 10:55:09 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] selftests/mm: fix split_huge_page_test for folio_split() tests. To: Zi Yan , Andrew Morton , linux-mm@kvack.org Cc: David Hildenbrand , Lorenzo Stoakes , "Liam R. Howlett" , Nico Pache , Ryan Roberts , Dev Jain , Barry Song , Shuah Khan , linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org References: <20250709012800.3225727-1-ziy@nvidia.com> From: Baolin Wang In-Reply-To: <20250709012800.3225727-1-ziy@nvidia.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: CB506C0012 X-Stat-Signature: 5cnhu4gwimn1sti3x6u15tca9u7rnjkg X-Rspam-User: X-Rspamd-Server: rspam06 X-HE-Tag: 1752029715-662048 X-HE-Meta: U2FsdGVkX1/0b30zNdKpNP1CIdNTz4twHcMoMDbDSpkcY1NbYzsIugzdePhS8Z3bJGhKy9uq4Y1sP/LiEBHzysfuyMBf/zM5aC/wlOmIWUxB+RGlyE51S91PnIWLwFTDUl3cenX4eCORKFEWsZQUiy14KX3fs2y++vjH3AR3nVxLfQa8vRwKhIWEMYvAShVDJ0a2UF8YL//3G+NRtnloGpq3ZgLq9OhWPRrnQHle+vOBUaSBaEc36FSglGZb2olwGO146OofZJ/N84LpsCDMYMwafe70+FP6k0Ni9a3HWXBgVN2WDBml5+eZ0D3DJU8e1G+UrEQIpiLhbBBUp1i3xFfYGQnAovFHQkiYLDFAD0em0a/4y/Co+KKSEbRTjStH47pcH7kc+So86cp5Kf9JkKegtCsJgtvvDVi5gYi3Axjq9xvo5Vjdmc8NW1QgT8us6T9RJ8hpWWQ5JtgQfL2eFaw2NIezRIw177i5Hqa8/XGZt7NquWVvADY7k54TkrvwT5gQH+73yWpiGAIiNAC9XD0uY3zWQLy4alrT0et9XY8pLLzUnCKeTp9ji0DUHRa6Qlz+CDtNkvUxONfe9oQw1E2lJQsr2ucW2hHo9CTl4F/OuarpprWt2wCJM9BRh7azgfqi2x2ot3dZdFbxKOea3eWtdux0IcAT9xM+davaU3YPDIdsaHl7xKh2Xs4f+4J0Bc2gc+KiZiShvoegyjBcU931OnYH3EhSTon6VNXRaoai5Fxl2eO16WdiT4MiP33wnwyxJY4Y8EF9bdiKok/KOmAvA/yhEKbKUgkZEHOyJeV5ddY4OqMAOB//Tn326LjxIrfHdmBKOvqMca2PazZM+N2dpiS5+Wfj8eYyYV903zP4bdspXTyVw1xFZDIALpEil9AXzpJIiWaJI8mjrdjr9o/LBuwO/rP2R6TvT+g85GBP/4imeCM65XZIpT3DN+lwfdAwPMiYMJbPTQ8pWY9 rGk2YLo3 GLmL0pvGm9p9iBwylTa00l4Q+DECsK7Ioijvnv7FIda1KdDss/Fc0K0GLAjvSJNjEBxGFIqeE1NmUr6O7UjWwc3PFgqeRfeo9QKqJlBjj0/GOtlXXCRCh7jAfuBwrS/PWplcCqbN7e0fhcwqKEd+it4EY2yqrAs+L9bDA9gHrP7NN2SdvehaOVJ8Y1U8s8O0qwl2wxzLF0sfLGVPoCIFL4edyIKUmp2Yz2dy/Obknz+V5+aXVoHmGsXMydXcyyb2Gt0bHFRelAlI3J5YPbmAkZy+d5aJkimSpF5Sv4zpjAFX98R1XjNI+ew5H1wmgb+2XLoERcvkIZDZJeJ5vYHJshpr/NNbaJiDfTJuIuSiShKLAZ4VSVqeiqiwO/CXdfR/GfVWx X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2025/7/9 09:27, Zi Yan wrote: > PID_FMT does not have an offset field, so folio_split() tests are not > performed. Add PID_FMT_OFFSET with an offset field and use it to perform > folio_split() tests. > > Fixes: 80a5c494c89f ("selftests/mm: add tests for folio_split(), buddy allocator like split") > Signed-off-by: Zi Yan LGTM. Tested-by: Baolin Wang > --- > tools/testing/selftests/mm/split_huge_page_test.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/tools/testing/selftests/mm/split_huge_page_test.c b/tools/testing/selftests/mm/split_huge_page_test.c > index aa7400ed0e99..f0d9c035641d 100644 > --- a/tools/testing/selftests/mm/split_huge_page_test.c > +++ b/tools/testing/selftests/mm/split_huge_page_test.c > @@ -31,6 +31,7 @@ uint64_t pmd_pagesize; > #define INPUT_MAX 80 > > #define PID_FMT "%d,0x%lx,0x%lx,%d" > +#define PID_FMT_OFFSET "%d,0x%lx,0x%lx,%d,%d" > #define PATH_FMT "%s,0x%lx,0x%lx,%d" > > #define PFN_MASK ((1UL<<55)-1) > @@ -483,7 +484,7 @@ void split_thp_in_pagecache_to_order_at(size_t fd_size, const char *fs_loc, > write_debugfs(PID_FMT, getpid(), (uint64_t)addr, > (uint64_t)addr + fd_size, order); > else > - write_debugfs(PID_FMT, getpid(), (uint64_t)addr, > + write_debugfs(PID_FMT_OFFSET, getpid(), (uint64_t)addr, > (uint64_t)addr + fd_size, order, offset); > > for (i = 0; i < fd_size; i++)