From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 70151EB64DA for ; Mon, 19 Jun 2023 07:41:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CCD888D0002; Mon, 19 Jun 2023 03:41:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C7DC48D0001; Mon, 19 Jun 2023 03:41:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B1E568D0002; Mon, 19 Jun 2023 03:41:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 9E0D68D0001 for ; Mon, 19 Jun 2023 03:41:25 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 666F9404BB for ; Mon, 19 Jun 2023 07:41:25 +0000 (UTC) X-FDA: 80918702130.10.B6865E0 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf18.hostedemail.com (Postfix) with ESMTP id 270241C001E for ; Mon, 19 Jun 2023 07:41:21 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=eRYUz2Fp; spf=pass (imf18.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1687160482; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=EqswxOYBmgCx1H0OtTMAtQLEByiEVXOzTtZ2FdWBrdg=; b=WRb1q0J1dwOiHEtPoJinP+cQUrLJD4rl1X50XOqwCcq20Zcc0ftlLwblDkmetyKhnR8kSn GUiAbeVz7+M9XtpGoTahnWXD4GpvXj04vLKLgbRx4MJwT0dPOn9frNJ5OzD0c5gSFz3ook fYqVZK5wlSadhvcyZLbU2x8fX9M9PHk= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=eRYUz2Fp; spf=pass (imf18.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1687160482; a=rsa-sha256; cv=none; b=LYBVYErFtMUZpN5koAoLH7a8HD3qwHoCXYWJN4VzOIB1V2y5lICLm0FvoRXCVba5+oewUe Jui83U33+gBfBytoZIPkv6/J7buRf6IDbfGNBo+DZ033wRprZnoLLZkyrUivo5pnBvFBwN 3YdW/cCbxzqes18RynG5ObFdwrFHElo= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1687160481; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=EqswxOYBmgCx1H0OtTMAtQLEByiEVXOzTtZ2FdWBrdg=; b=eRYUz2FpKloWff17jRJhaagrP1nKer+Xu2D3T44EWAFKgiTeX80wIOeQwMLzdpKpgK7d5j jqKA69GplQSYg/SLZ+J9Lk1gfOvZceMRevmeL9BlPtg/cKfp5aUsxUNtONyqXWcPoiI9ph /ma7VrR5Dwadivu+MM9gQbha/E0ho9A= Received: from mail-lf1-f71.google.com (mail-lf1-f71.google.com [209.85.167.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-381-01stDkLTOymUQSJrgEUYkw-1; Mon, 19 Jun 2023 03:41:19 -0400 X-MC-Unique: 01stDkLTOymUQSJrgEUYkw-1 Received: by mail-lf1-f71.google.com with SMTP id 2adb3069b0e04-4f658076c93so1986365e87.0 for ; Mon, 19 Jun 2023 00:41:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687160478; x=1689752478; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=EqswxOYBmgCx1H0OtTMAtQLEByiEVXOzTtZ2FdWBrdg=; b=VMYeFJCmYbLLLHmSEN9EpKBnn23QdF20NhIzt4QR56B9Er/teh5ziCF1W6b6L2vrbT s7HUyXYLL7QTibbbFQaKohc+LmXabfYauKf3Vr1oimP3NHttRwARtsXJlHn3DtaKMmyA 3Ngfovgh8BD0rON6Gy8lBtp6j9C5beGngOxJxkOKxT8QUsnK1ICtgQ1sHwgIez52SP6P EusgLpsNUcp0ZzKk+oQAFNK11KeQ8rC+2VscLSfTuf8mYurOQt8bFuQ6sWNGzzmq3I97 83EJA9CenAkpgcihaNg4QpcsgC7t9NZmj26UILBcbcV1eUaA638xZQICcXxp28qAGhyZ Ep3Q== X-Gm-Message-State: AC+VfDweYWoU1p6ingMl6S/nicghyEbZdDrAvauIanntubBrKkbP1B5w t1I7FeasD6alogG4CLC6tDdrbDLF/z+ioitBcQ1ItpvwMlyaPqR1ev6+RPB9A1Qj6z3+rOWGJpm KftZgVD0hUdA= X-Received: by 2002:a19:6909:0:b0:4f8:6d54:72fb with SMTP id e9-20020a196909000000b004f86d5472fbmr1049637lfc.62.1687160478475; Mon, 19 Jun 2023 00:41:18 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5HNHZ8/JvZilW7FHs81e5kgKVsECuxDLsfEiF7YmZueXU3jXNGQCNTjN77BhxFyBFc35X8sA== X-Received: by 2002:a19:6909:0:b0:4f8:6d54:72fb with SMTP id e9-20020a196909000000b004f86d5472fbmr1049624lfc.62.1687160477940; Mon, 19 Jun 2023 00:41:17 -0700 (PDT) Received: from ?IPV6:2003:cb:c72f:7100:cede:6433:a77b:41e9? (p200300cbc72f7100cede6433a77b41e9.dip0.t-ipconnect.de. [2003:cb:c72f:7100:cede:6433:a77b:41e9]) by smtp.gmail.com with ESMTPSA id v4-20020a5d6784000000b0030fbf253c82sm22235978wru.104.2023.06.19.00.41.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 19 Jun 2023 00:41:17 -0700 (PDT) Message-ID: Date: Mon, 19 Jun 2023 09:41:16 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH stable 5.10] mm/memory_hotplug: extend offline_and_remove_memory() to handle more than one memory block To: mawupeng , gregkh@linuxfoundation.org Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, richard.weiyang@linux.alibaba.com, mst@redhat.com, jasowang@redhat.com, pankaj.gupta.linux@gmail.com, mhocko@kernel.org, osalvador@suse.de References: <20230619065121.1720912-1-mawupeng1@huawei.com> <2023061926-monoxide-pastor-fa3b@gregkh> From: David Hildenbrand Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 270241C001E X-Rspam-User: X-Stat-Signature: u7h9i5hg6niuy1n8pyeewj56ytqf6fxz X-Rspamd-Server: rspam01 X-HE-Tag: 1687160481-854931 X-HE-Meta: U2FsdGVkX182gxPR46t3BgY3TbTDw7+DpC5aBViiZjCm+E8mW+zwqEkWBORde6YLXEzbIBomwawG3TcopaUdYgHQW80Dkf/7zf7EDk2AFE8pe1AAx/GuqHQTUSsO7OXeY2ztIXNsd42JxGygXcoj1ECodaQvArc+Jr+Yd4XwGW2Avft53e+VODhWyvzovUbiOKLOfTiFYRi5KQaBBpeb9PBCVSzkQfxn39j/Dl3MpWlW78m5gxrEMKfQnU18jET2nKuUc4nro6iVKk2Q4qtWxAenJ/UDXmjHcX6d66ma8F74xUA0xlwsr20QTN7M6wo/RxQ0sGIfS1Sb9i80txUEvsYv8NnYM22Y4mTvcd+QQK7vLHed4w0c7a8sIFAIefACug+tF20U83GzMBrqUYYdcIiW9SiFN1++ecvtrLDwUJ+IzJBbxYKMdJd29wuYeFM/Lrsg+CSeIQ5ikkeFjIeGspdIjx13FZWMlKxP+5E4q64sIkSGfUavZDrVMCZ/QFVjjQoL8t3l2fqmtrFCeBg5W0L8v4q9SQ/bspqnmMyQHeBxUHUoK9zIUcGF6Pd5KsgzFhksYKzggPJZ6cKJI6RPl+kHArNwLPd2MtBHANFgKh541XF9lzKSs5LKOFK+Hbn2RQGwIWfhpq9N25KkwPESmJByG9nA1aYuCdW/fKi3EFuQHbTqv+k0mQEBvjvNCMU9BBw1LQUEcqmxd01tz0xBK7qeoZuZSqGF8RgrAUupmd7y1dqXt8/Sri9aD0MrrKNEji4jT0yRmS3e1ZZdrQNP+o5jj0yzB3whyAzITK7Aoah5K2btzXwT/bXfQ+GvQMye2QIBqqpBbkGNaigvtFM7jnYFhkY2gCEc/7zFSfGrAS617u78UJPx8/KYwohk8XWsLkilQwufhAEHsKOpAM5BPlLGX6Vi4jlL0qH9N99qKuVtXNHuNP1vbTUGnjtbnpAMy+xxztNiI5PA4IHCTCW 1eJBTFGO f0Bpo7obNhBzILWd17LqBgFcNkT2gi7xi0rSVYB/FLCFL0TxqnJ9yzTExhAcmxVrd4zjmhGGpPy+jqnc+li2LyfbV9wdCsWo35ikgaOBAtZyzIOWk+hrWbI+zyYqboL175b5Xv9XbaZ2OXr96xiTVpGL0iDM3ZtfMTLp5QLZcY+h2Nx5erXZz14sAS60o/S/asu3Gmqjc912Kxr9cYO13/jjd3t+oueIZetI4f481dFmBEGGGvDORjYaXkrvprtSPP5iK3k4MDDym1BN8CgC/cJTLu3BoA/jxJVxTFS46NlFXgi3xjqx0wZYk51AmelcsTFufR2HHs+aQCFSPsDAsMydouwgMY9AzTjzdVX4B/ulcOov919+G4J04DIJGscO8Z2eiu7+tM0CN77JPupXY2xAqXUQWspQFpMCLoHKq8GoviAY0Ul212KIlupHEmF6CcFYqUJ4TuYhQIczpWZji1TtgdVVgvrdi1UYFiyWfwSrqI8TsuXVwYlEM7lBOeUlQWtqb87J7b3BzUtBEYgbaQhg6w5JexvBLQR23OdVF5+naoogj1whAaUsar1lnWWuQoqUUJdMpm8LSJz3HOjUyNVOaPW6O6PP2NCoBN+Ujpvw7wDdp+tTPprgXOOFdsGxnAE4njc4pXs7FTe9y1A4NMY4UiRVG5rw0YITvRTWYdpLI3r1r6TgkTOeecPeIN2EC+Zh0+6jIUKphwkA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 19.06.23 09:22, mawupeng wrote: > > > On 2023/6/19 15:16, Greg KH wrote: >> On Mon, Jun 19, 2023 at 02:51:21PM +0800, Wupeng Ma wrote: >>> From: David Hildenbrand >>> >>> commit 8dc4bb58a146655eb057247d7c9d19e73928715b upstream. >>> >>> virtio-mem soon wants to use offline_and_remove_memory() memory that >>> exceeds a single Linux memory block (memory_block_size_bytes()). Let's >>> remove that restriction. >>> >>> Let's remember the old state and try to restore that if anything goes >>> wrong. While re-onlining can, in general, fail, it's highly unlikely to >>> happen (usually only when a notifier fails to allocate memory, and these >>> are rather rare). >>> >>> This will be used by virtio-mem to offline+remove memory ranges that are >>> bigger than a single memory block - for example, with a device block >>> size of 1 GiB (e.g., gigantic pages in the hypervisor) and a Linux memory >>> block size of 128MB. >>> >>> While we could compress the state into 2 bit, using 8 bit is much >>> easier. >>> >>> This handling is similar, but different to acpi_scan_try_to_offline(): >>> >>> a) We don't try to offline twice. I am not sure if this CONFIG_MEMCG >>> optimization is still relevant - it should only apply to ZONE_NORMAL >>> (where we have no guarantees). If relevant, we can always add it. >>> >>> b) acpi_scan_try_to_offline() simply onlines all memory in case >>> something goes wrong. It doesn't restore previous online type. Let's do >>> that, so we won't overwrite what e.g., user space configured. >>> >>> Reviewed-by: Wei Yang >>> Cc: "Michael S. Tsirkin" >>> Cc: Jason Wang >>> Cc: Pankaj Gupta >>> Cc: Michal Hocko >>> Cc: Oscar Salvador >>> Cc: Wei Yang >>> Cc: Andrew Morton >>> Signed-off-by: David Hildenbrand >>> Link: https://lore.kernel.org/r/20201112133815.13332-28-david@redhat.com >>> Signed-off-by: Michael S. Tsirkin >>> Acked-by: Andrew Morton >>> Signed-off-by: Ma Wupeng >>> --- >>> mm/memory_hotplug.c | 105 +++++++++++++++++++++++++++++++++++++------- >>> 1 file changed, 89 insertions(+), 16 deletions(-) >>> >> >> Why is this needed in 5.10.y? Looks like a new feature to me, what >> problem does it solve there? >> >> thanks, >> >> greg k-h > > It do introduce a new feature. But at the same time, it fix a memleak introduced > in Commit 08b3acd7a68f ("mm/memory_hotplug: Introduce offline_and_remove_memory()" > > Our test find a memleak in init_memory_block, it is clear that mem is never > been released due to wrong refcount. Commit 08b3acd7a68f ("mm/memory_hotplug: > Introduce offline_and_remove_memory()") failed to dec refcount after > find_memory_block which fail to dec refcount to zero in remove memory > causing the leak. > > Commit 8dc4bb58a146 ("mm/memory_hotplug: extend offline_and_remove_memory() > to handle more than one memory block") introduce walk_memory_blocks to > replace find_memory_block which dec refcount by calling put_device after > find_memory_block_by_id. In the way, the memleak is fixed. > > Here is the simplified calltrace: > > kmem_cache_alloc_trace+0x664/0xed0 > init_memory_block+0x8c/0x170 > create_memory_block_devices+0xa4/0x150 > add_memory_resource+0x188/0x530 > __add_memory+0x78/0x104 > add_memory+0x6c/0xb0 > Makes sense to me. Of course, we could think about a simplified stable fix that only drops the ref. -- Cheers, David / dhildenb