From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 44619C369B2 for ; Thu, 17 Apr 2025 13:26:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8004928008F; Thu, 17 Apr 2025 09:26:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7B031280088; Thu, 17 Apr 2025 09:26:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6295A28008F; Thu, 17 Apr 2025 09:26:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 4492E280088 for ; Thu, 17 Apr 2025 09:26:49 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 383C7161753 for ; Thu, 17 Apr 2025 13:26:50 +0000 (UTC) X-FDA: 83343610980.15.81EEE68 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf07.hostedemail.com (Postfix) with ESMTP id C8C5E40007 for ; Thu, 17 Apr 2025 13:26:47 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=DAI5lqfX; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf07.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1744896407; a=rsa-sha256; cv=none; b=q1yPg1IuyM2crYGdYr50zld1ldKUdbv3Mqz9ijAHeKEczGfuEE2AO2LS83H7d6ZZMk6Fcp 6nktocA86XfATG0XqtYlBG0OlPZqVJUsR5hcNiqiOBOPrpoRphLO5rqS4odIkWVSFYtGtM FrO3akn8WWmlbsRWb1E2Brg4kdn9VCI= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=DAI5lqfX; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf07.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1744896407; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=T/uHlC6UoBPrjU6+QaaVuSN4oPRWaY8QJta9DsekY80=; b=Z8zo8oEG4IXto/ebeJvMmjhbprLMji06UNNsIcXY7wfz4I7bQpEuRgwD5GcUr1E8tlp5uB AVh9XBQYLW+i+ibtg+LXNBgPVJrxymn5dk4gX4KNxquR5eZ3ajm95cy4KmZXnEY1lKGk4K Nw8RLhv+SBhFOILAN9nY6R6QIjA/Xmg= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1744896406; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=T/uHlC6UoBPrjU6+QaaVuSN4oPRWaY8QJta9DsekY80=; b=DAI5lqfXJslhC5ft44Peiop+g3g4+vM7ZjurP1TaaRpftXvBxiPpEcXXTh7E/61vTeHzmS iR4tPQ/SLFBuNyhKnJbyKRv/ZRDIC4Q9VGrYCWflqBbWFhbFMLv5nbXM7EKw3VHkSv5Vjg aKAhDpezvwQ2Q1FxjqIH6R4a7IRYcqc= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-593-zhCUrXVaPE6oApBJSupLCQ-1; Thu, 17 Apr 2025 09:26:39 -0400 X-MC-Unique: zhCUrXVaPE6oApBJSupLCQ-1 X-Mimecast-MFC-AGG-ID: zhCUrXVaPE6oApBJSupLCQ_1744896396 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-43f405810b4so4194945e9.1 for ; Thu, 17 Apr 2025 06:26:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744896396; x=1745501196; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=T/uHlC6UoBPrjU6+QaaVuSN4oPRWaY8QJta9DsekY80=; b=WtH4zQDMmmyUUUwIO5Dla9HpJDLQ95tmbgdwLWuFXZMZVELn070HJJDyI0K0awhzcq Fe79CsYiHjZsxV3mPkmffFRtD+ZURZEAUJCA69geLwus2drKCibiGjI3npDZYdZz0bsU 2ohkmpBA0dQhFEvp/QpoN542un5R51S1+5Dhn/DVDF1ugavpoKSBLmAK5l3/jZ77Qnlw riHrEzmbitgyeZyXl+e4oDy2CrRrMxsJSNIQ7/udymYpltWbTVgzHobr7j3db6kf8BAJ B2vvkUQPMqIiL/OueE2LXBCZ64ZsRjv+W/cifyOyZPZDyEOZooc6RXYaNi7rb7/I0J6D aKHg== X-Forwarded-Encrypted: i=1; AJvYcCVZ/jEBIuIx1IzY1M9qcV8UoIuoZihoochIQSezltcKwTM04Rt/KQ8u6CIxU4b3y3f1GYvw0cD8Tw==@kvack.org X-Gm-Message-State: AOJu0YyXka9OZvH+6Z3vwZlS90j6Nk5m7Hu9ybF6sRA/hAaY3fUM52/Y mi092MgcIR4feAj/kXROPWaraCkui8LLfXG9SsqyZEwEyJbde3G98vTbP+IhxuVyFl1p6boFnPQ 4f/726Nf8/TrLk+rC2xNVQ/OrxY9EQFfHZGAbXJccRK2WSb9i X-Gm-Gg: ASbGncutRFU0Px1oG+hvuCSIDplrk3ZPTE22kxGjIebUCqxNauX4CIEg9TD0P+znXGl sYO6xQ8Kf0ZmXYLaQm8nVGqX3n5r8sP78anBnODQuu44fdt2Zk1WsDthAEN67xIhrb7ncgWIvKb ilX1IRkUDFVRtMQ030rJWl7uZ2P7lG5X47iofF1rSvhs/UgLTgZhUm3Z1Q1yUJT4k8jjfd7AJQq FQK32zrHwKHi4HntrzMCcAeCfsFrsrPegN7mudT6h1CJKnH7DazpvytO5waVqFOdETPiKhSnwkU 91x5co07p4kiUG163uw+wqrzwTqAs8SE3U/FYJnqx+mnb+UcUyTprLFwMfaAnH6lUz8azKsEqTj udbDSTsVd+SVN7JPrr7NpslC9qryIfXhqYLfdYDk= X-Received: by 2002:a05:600c:1e0d:b0:43d:4e9:27ff with SMTP id 5b1f17b1804b1-4405d5fcd26mr60199305e9.7.1744896396413; Thu, 17 Apr 2025 06:26:36 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGdxIJvd+ZnofZRyyQ+HPKreEByoTfd527QFM1n5sKoIq0Bk40WD2AI3yY5l1G9EQICX7Jr+Q== X-Received: by 2002:a05:600c:1e0d:b0:43d:4e9:27ff with SMTP id 5b1f17b1804b1-4405d5fcd26mr60199045e9.7.1744896395980; Thu, 17 Apr 2025 06:26:35 -0700 (PDT) Received: from ?IPV6:2003:cb:c706:2700:abf9:4eac:588c:adab? (p200300cbc7062700abf94eac588cadab.dip0.t-ipconnect.de. [2003:cb:c706:2700:abf9:4eac:588c:adab]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4405b50b964sm54487825e9.27.2025.04.17.06.26.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 17 Apr 2025 06:26:35 -0700 (PDT) Message-ID: Date: Thu, 17 Apr 2025 15:26:34 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/1] mm/rmap: add CONFIG_MM_ID guard for folio_test_large_maybe_mapped_shared() To: Lance Yang Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Mingzhe Yang References: <20250417124908.58543-1-ioworker0@gmail.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: l-p3EyKgu9w38Q7eWY4kckoruRmjhq1qJfI9HbkaBlM_1744896396 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: C8C5E40007 X-Rspam-User: X-Rspamd-Server: rspam07 X-Stat-Signature: duh73rusrgawqq6u6wpjzi5aqfaprp46 X-HE-Tag: 1744896407-611776 X-HE-Meta: U2FsdGVkX1/FXMn5kFECfaLOz/6rYGq4PfKlFvA43gAjqNwUaFx0H6qS9AUiJ8PGNnJHHMMxplxkFiFXVHRVabTyN22sVK5Al1Ny8G0R9qvQ13oDeeeVVEUtUjpCrV0S/uu5zCKrifwQKfdklFEVAwaIq6aAZJiWpNajVzy488ai/6kqKCk/fM/Kk7BZ3OvYlfogUODVo4wOuv1Rf9l9gLnYiMCYsNzrdoA0nWCq480gOW6zR+M2+W2l5jvCcjeddWDkQ698UMtmAS9uIymzYXUvR19SR8M0+ytbIpSJEVMK0pfhIk1KGxCVFWA/NGhI44wjDBDFJo7yeFtorySAqY3AEJC7G/te62QQ/PnkWKlIPeDuSIlLkJ/b6vABYRbri+5I/JWs4qlsZw99ImwfQAGlf5xFc0JOG4we3lys2ynlaNuDK7+/gzxDzd1URM0CSycGMHGqeWPys3yJtugFWUXmgUDCImlascSN3klDOn7Y8+sZGLHURWuvWX4wRgJU2ktQxINc9KcZJ+sXcuxQktBFmh+rEqjxjRUitNYzGFzlGWvdKG2wgJE8D7X1n93HsOU2tUFuhzi7MTeN8xLLdm8PlZmSLHaj23FbGXv7Mge381+j7BDfS6rkqEGDwE2zxf4CC5Qq+x7/aNjKlK891Rj3QYwhWPxoGdQV3fewpBKbbiC5hnfT0T+V8Rp7+L2QthPwPelyxTzpWicIVyFNqm6qhcJ4auftjAykLSCPC6Y4EHx93aK8qRrjr/4GVmvjBKgOHHfUzNidRSIn5qKYhUebHl3hIvKlm0W9Src6uTPXxCAzm+0QoQCke5aY/7T9aoE96B/S7H0W0k1KT32bvhzRYMb/yXyp5jzp99kDgDXiwD4GN1Z7F8ojyKsY2mI4qfWY83PCKUgY33d4kVJZoWlZM7lV0wo5M+Ly0qFlJBkqlju2sGeGgRcC5l3q5JfNhG8NEFGKOtTL3VogMob tZvTDd2G ih9NBGQWvWjyMPS544+ozRzZ63zm6YpPfwoiA6EyI2hoCa/OMEAz1FfUqFL0K1GG4Z0WKmPqX/EYcWEm1HPjOIgviDZs7/1QaPgLTQSKiatgueSDyOe+cg/WRFSzwcC2bpJsIfHrs/3FARhdbIyXWq7tcKhsCk1jRYWzjwr12i6gR9jXeSBrAVHqk+2EuzYXRx8ONjQ8Ag+nqJrOae2dPxn3TfZ2URA6SzrqeFN8kilo0tcpP4ajPOwCP3xVDXyWzrQpTz/Ay/D2SUXJNEvtKwcANRUYO/5LpVO7ZOMHpPR38HXUP1lSdR3PE7wZdqqFtbq2xlT5NC1kjBpEhQTkiT8xXiuRGEKVWzfJfucszClQJjUlwR95jgmJE5Dt85ctxcm9767KVrnejNOHWy4Lv5rbMSjt3+lzBoQyUAg0ipyRphCOITgEErzQXEaoTsPfpMViaa10ao2GrmDUIhGZzrM44gXg4KJocI2HBccQgr6wVtXfAQ5dX6g+K0U6ymWqnIzfJGrzSexwnBI68S5H9VzGUaIToS1A9z8tVscvMIYt5kuw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 17.04.25 15:24, Lance Yang wrote: > Hi David, > > Thanks for taking the time to review! > > On Thu, Apr 17, 2025 at 8:56 PM David Hildenbrand wrote: >> >> On 17.04.25 14:49, Lance Yang wrote: >>> Add a compile-time check to make sure folio_test_large_maybe_mapped_shared() >>> is only used with CONFIG_MM_ID enabled, as it directly accesses the _mm_ids >>> field that only works under CONFIG_MM_ID. >>> >>> Suggested-by: David Hildenbrand >>> Signed-off-by: Mingzhe Yang >> >> ^ should that be here? > > Yep, that's my email too ;p Best to stick to only one here -- same individual :) -- Cheers, David / dhildenb