From: David Hildenbrand <david@redhat.com>
To: Lance Yang <ioworker0@gmail.com>
Cc: akpm@linux-foundation.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, Mingzhe Yang <mingzhe.yang@ly.com>
Subject: Re: [PATCH 1/1] mm/rmap: add CONFIG_MM_ID guard for folio_test_large_maybe_mapped_shared()
Date: Thu, 17 Apr 2025 15:26:34 +0200 [thread overview]
Message-ID: <cc0d709a-3d9d-4802-b9ff-898cf7e5012f@redhat.com> (raw)
In-Reply-To: <CAK1f24mkswwY71EKourpw1y-KiFi08OkGzZSBkutoj+UCgbLMg@mail.gmail.com>
On 17.04.25 15:24, Lance Yang wrote:
> Hi David,
>
> Thanks for taking the time to review!
>
> On Thu, Apr 17, 2025 at 8:56 PM David Hildenbrand <david@redhat.com> wrote:
>>
>> On 17.04.25 14:49, Lance Yang wrote:
>>> Add a compile-time check to make sure folio_test_large_maybe_mapped_shared()
>>> is only used with CONFIG_MM_ID enabled, as it directly accesses the _mm_ids
>>> field that only works under CONFIG_MM_ID.
>>>
>>> Suggested-by: David Hildenbrand <david@redhat.com>
>>> Signed-off-by: Mingzhe Yang <mingzhe.yang@ly.com>
>>
>> ^ should that be here?
>
> Yep, that's my email too ;p
Best to stick to only one here -- same individual :)
--
Cheers,
David / dhildenb
next prev parent reply other threads:[~2025-04-17 13:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-17 12:49 Lance Yang
2025-04-17 12:56 ` David Hildenbrand
2025-04-17 13:24 ` Lance Yang
2025-04-17 13:26 ` David Hildenbrand [this message]
2025-04-17 14:29 ` Lance Yang
2025-04-17 22:02 ` Andrew Morton
2025-04-18 7:26 ` Lance Yang
2025-04-18 10:38 ` David Hildenbrand
2025-04-18 11:40 ` Lance Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cc0d709a-3d9d-4802-b9ff-898cf7e5012f@redhat.com \
--to=david@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=ioworker0@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mingzhe.yang@ly.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox