From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CAD1DC47DDF for ; Thu, 1 Feb 2024 12:26:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5F2E86B0075; Thu, 1 Feb 2024 07:26:20 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5A2C66B0078; Thu, 1 Feb 2024 07:26:20 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 46BD06B007B; Thu, 1 Feb 2024 07:26:20 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 396B46B0075 for ; Thu, 1 Feb 2024 07:26:20 -0500 (EST) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 0F20FC089D for ; Thu, 1 Feb 2024 12:26:20 +0000 (UTC) X-FDA: 81743157720.07.B813BE9 Received: from madrid.collaboradmins.com (madrid.collaboradmins.com [46.235.227.194]) by imf02.hostedemail.com (Postfix) with ESMTP id 30AAC80011 for ; Thu, 1 Feb 2024 12:26:17 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=collabora.com header.s=mail header.b=YBchkCDA; dmarc=pass (policy=quarantine) header.from=collabora.com; spf=pass (imf02.hostedemail.com: domain of usama.anjum@collabora.com designates 46.235.227.194 as permitted sender) smtp.mailfrom=usama.anjum@collabora.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1706790378; a=rsa-sha256; cv=none; b=ebb4t30iSKZNNj3x4+MfkmluoIDbzXi4zXmVfl5CX87AHZZTW3cxSXP5E/xbcz6UfHEx0b PQPkrAh4SQLYdCMHWW2myteJZJunRWnfJaMlJArPH771ox8nkh3G2vS7KFSRXQ/5pUeVhu SN/bhpthlMf6lsTMKJJtPPj8L2Bs0+E= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=collabora.com header.s=mail header.b=YBchkCDA; dmarc=pass (policy=quarantine) header.from=collabora.com; spf=pass (imf02.hostedemail.com: domain of usama.anjum@collabora.com designates 46.235.227.194 as permitted sender) smtp.mailfrom=usama.anjum@collabora.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706790378; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=hCE9VvGVwg1Z0mlUzv7txZQUlZjgeH/sFn0saqJAizI=; b=MV05lLXMopxlIkCpHlF9+hAa52kHnOi6tN8QcCaxbUydwjw5f8+J6F3u7QdwHw4aisdpSe WBUk0gefdKYHvNcl2eM5MIRuWtfDVNaB+zI/37UAd7o8TorhELaTSP+eE9v68SWGr8gS77 9wGxfg5rGjs4K2AFTwl1+omlp7BCals= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1706790376; bh=xg5m8felV7XMNg/ecDkG5YxQXJFG4fqtcpiToAp0aE4=; h=Date:Cc:Subject:To:References:From:In-Reply-To:From; b=YBchkCDA2ADPFyOfIaAPy6VfbCxUA4woSvmMFqErTo/eGM/o30X1zghyQjFY0MyhC +N/s5HqRyxsxFa9WaUiFkMM0Cpq+4q/cJ42osL+jI3wYtAbDqZP3O4f8iaETpuvJcF 7FgHlcoLM9zjnDrHj9HvP5WGkstsqsaRiTSCltqLKdMNuKXcfFseCdNd4w++c+YoHD cKPj6DLJSkAajiW7Q91EGgq5GX2xNLgjTkQvn46sdcYgHnk6MbSX9RV/Wq9tyczwK8 o++yH6dXavwI/AGaM+llvlTbNveYyvTaCdvZIHaXY51EfrF3Scr1vzj0mJ55RSbUzz iiEPRBWeMU0jw== Received: from [100.66.47.90] (cola.collaboradmins.com [195.201.22.229]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: usama.anjum) by madrid.collaboradmins.com (Postfix) with ESMTPSA id 159F5378047F; Thu, 1 Feb 2024 12:26:13 +0000 (UTC) Message-ID: Date: Thu, 1 Feb 2024 17:26:29 +0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Cc: Muhammad Usama Anjum , kernel@collabora.com, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 5/5] selftests/mm: run_vmtests.sh: add missing tests Content-Language: en-US To: Ryan Roberts , Andrew Morton , Shuah Khan References: <20240125154608.720072-1-usama.anjum@collabora.com> <20240125154608.720072-6-usama.anjum@collabora.com> From: Muhammad Usama Anjum In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 30AAC80011 X-Stat-Signature: 4tnkg46feqdb4yy57diudqfpdcwyysae X-HE-Tag: 1706790377-958209 X-HE-Meta: U2FsdGVkX1/u5B9iToMenCHTSEdxDNPuGiRvME710UdYsbhzcn7mEZL0X3q/mxxblHzDkBcRqtblPHus6uzLDP2NDhixd5+5nSl6e1b7rCiYJNM2S2SiihDIk5YE/vlGSFmvCiq7MhgN29s1gq98oBq0eSHBuHLUxwQYR2CzA/YHrp8Ys0/Kbj9iQLgsH2MuyQE1yROtiR5VNFt8wKQm/1VcYChjtD1h4Ks8nM2bdK92QfwW0X5zxOxmtDLFaBkW93/B99Vo3FXUUf5jfE7bTbm5w19+bU93lfrCEFlsSYFyANNGHzF9RFGusVnNbQx5MRIVjc0JNlKezGeII3Z004NukYrGDST6z7yyQKRpPuUNLEfEBjOL/5hzNJzdEdmSJfRY0lI8ScG/atKTgP6nPuGnxYeLkiUTlPB0vRovGLIOPJU/nYG3c1Jk6ObJg2zolwlglkTRpokvWLnDUQFXJsS2JtYy64C/JcIB53Vm+5wPANps5ttG3QPNuKW3eAZHsjLkeeveen+B2Kwh2WkVCUbW+trQuwaskOPq70zNc2WiCH9FN/OCRFMCPj+HL5dKQSWLdQE+Pbqo2sxn7UL+PM/pew3EQKWX3/LDzyOVWeEadMZkuhhyNQwNNNKR1lHkzvx9Zx3RPcVRZ9ULDm9zR1NNIQcrasQwTwJ2UETyXFjMxVISGFInHp6kBvynmZxUl++cC3dWNax12/6E1SvO++6dTcIFdk+/XHzJYEtD6hIHzMV8A/GE2hg9MzqMaPviwjRUwQjequYxCDtM1arC75Bwp9T779+OaWLkGy3yO7HRLRRRNWw6H7YxdniCJMmH1SxjiNRQDFZD5LM8xJqPDS2C2RSvaDI+cVvRjYpZ1A1oBo0K9HsznVa7hfKIBBDys6cH5R7akg32KcQX7Og7dTsJZtb/BqKEWY7seqd5HHLnJnVUj+Og8rlJVhkNHklc5S+M3A2zWkZ13nhwkuK VlccuGqx 9vIDwOmDrq+eupayv86D/RbB7IzlAa1oEYvmb57r8MJaMZjxmq0+Qu56ZwAduP1p23pe4b5Wfw4mzL+oLy1MrauCyyeWQl8pOWZ1JjRivZUuXQ4sd1CETFVoRDIao63bD7oTZv7+emUT4kIZ4UZUpe0y01d5EV9UEIhd4/3H56b7uzq1lWMdFuD1uDgw0GL4i5lbvCdS2Seen2uq0fbwfvG/nWoibpVWHjoMzNfnSVMZwIsMxpz1IGxgA/rGo+ZkCtFdt0JERVN3LujT7gsSxOFJYJxXJ/Tk2q/G5+ErHYH6kh5wHHnBEwYdEgq/P1fKfgyv2eQiJA47kXzoQAuwnZH5zY8mnffmTXT8s5axwRiars5UvMVLZ6GNhjHlBbIehE2/r1CU2nY+ytfYINICtuUNIlg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000007, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2/1/24 5:11 PM, Ryan Roberts wrote: > On 25/01/2024 15:46, Muhammad Usama Anjum wrote: >> Add missing tests to run_vmtests.sh. The mm kselftests are run through >> run_vmtests.sh. If a test isn't present in this script, it'll not run >> with run_tests or `make -C tools/testing/selftests/mm run_tests`. >> >> Cc: Ryan Roberts >> Signed-off-by: Muhammad Usama Anjum >> --- >> Changes since v1: >> - Copy the original scripts and their dependence script to install directory as well >> >> Changes since v2: >> - Add a comment >> - Move tests down in the file >> - Add "-d" option which poisons the pages and aren't being useable after >> the test >> --- >> tools/testing/selftests/mm/Makefile | 5 +++++ >> tools/testing/selftests/mm/run_vmtests.sh | 8 ++++++++ >> 2 files changed, 13 insertions(+) >> >> diff --git a/tools/testing/selftests/mm/Makefile b/tools/testing/selftests/mm/Makefile >> index 2453add65d12f..f3aec7be80730 100644 >> --- a/tools/testing/selftests/mm/Makefile >> +++ b/tools/testing/selftests/mm/Makefile >> @@ -114,6 +114,11 @@ TEST_PROGS := run_vmtests.sh >> TEST_FILES := test_vmalloc.sh >> TEST_FILES += test_hmm.sh >> TEST_FILES += va_high_addr_switch.sh >> +TEST_FILES += charge_reserved_hugetlb.sh >> +TEST_FILES += hugetlb_reparenting_test.sh >> + >> +# required by charge_reserved_hugetlb.sh >> +TEST_FILES += write_hugetlb_memory.sh >> >> include ../lib.mk >> >> diff --git a/tools/testing/selftests/mm/run_vmtests.sh b/tools/testing/selftests/mm/run_vmtests.sh >> index e373d592dbf5c..a0f37e4438937 100755 >> --- a/tools/testing/selftests/mm/run_vmtests.sh >> +++ b/tools/testing/selftests/mm/run_vmtests.sh >> @@ -19,6 +19,7 @@ usage: ${BASH_SOURCE[0]:-$0} [ options ] >> -t: specify specific categories to tests to run >> -h: display this message >> -n: disable TAP output >> + -d: run destructive tests > > You probably want to clarify the behaviour for -a (all). I guess providing -a > should NOT run destructive tests unless -d is also explicitly provided. > >> >> The default behavior is to run required tests only. If -a is specified, >> will run all tests. >> @@ -79,6 +80,7 @@ EOF >> } >> >> RUN_ALL=false >> +RUN_DESTRUCTIVE_TEST=false > > Either call this RUN_DESTRUCTIVE (my preference) or at least make it plural > (RUN_DESTRUCTIVE_TESTS). > >> TAP_PREFIX="# " >> >> while getopts "aht:n" OPT; do >> @@ -87,6 +89,7 @@ while getopts "aht:n" OPT; do >> "h") usage ;; >> "t") VM_SELFTEST_ITEMS=${OPTARG} ;; >> "n") TAP_PREFIX= ;; >> + "a") RUN_DESTRUCTIVE_TEST=true ;; > > The help you added says the option is -d, but this is looking for -a, and > conflicting with the existing -a=all option. Sorry, that's a typo. I'll resolve your above comments with fix patch as well. > >> esac >> done >> shift $((OPTIND -1)) >> @@ -304,6 +307,11 @@ CATEGORY="process_mrelease" run_test ./mrelease_test >> CATEGORY="mremap" run_test ./mremap_test >> >> CATEGORY="hugetlb" run_test ./thuge-gen >> +CATEGORY="hugetlb" run_test ./charge_reserved_hugetlb.sh -cgroup-v2 >> +CATEGORY="hugetlb" run_test ./hugetlb_reparenting_test.sh -cgroup-v2 >> +if $RUN_DESTRUCTIVE_TEST; then >> +CATEGORY="hugetlb" run_test ./hugetlb-read-hwpoison >> +fi >> >> if [ $VADDR64 -ne 0 ]; then >> > > -- BR, Muhammad Usama Anjum