From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6427AC02198 for ; Thu, 13 Feb 2025 02:54:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 973B8280001; Wed, 12 Feb 2025 21:54:23 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 923DA6B008C; Wed, 12 Feb 2025 21:54:23 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7EB1C280001; Wed, 12 Feb 2025 21:54:23 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 613016B008A for ; Wed, 12 Feb 2025 21:54:23 -0500 (EST) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 0E5711C6098 for ; Thu, 13 Feb 2025 02:54:23 +0000 (UTC) X-FDA: 83113402806.25.E4478B6 Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) by imf30.hostedemail.com (Postfix) with ESMTP id 2671080005 for ; Thu, 13 Feb 2025 02:54:20 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=d0oaY+Jg; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf30.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.214.181 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739415261; a=rsa-sha256; cv=none; b=uX8Ymx3vl6JLTGL43Rak66GQp2+wU6u9bPGBP5IQOEipHD5vOneT3ehR6kEdysH1pN7Uju baCA/jttLc/opwuXDuHau7b5yTzjWNzfe4thbv94dbHa1Ll8kzFXKqc7Rs7jiR1psMKqAc pw13UO0X9/rc+pP7sLmsPXmUTt/nm+Q= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=d0oaY+Jg; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf30.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.214.181 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739415261; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=FkEPKUK4TubZ6Z6+0k4LQ0SxXfbAAf7UoZRYB0nxrs0=; b=3vUJSOvVoCn4r0BfCb8oQ+4epTFi8dZ86jHOZwJEDLUOlW12TmQisDqjCbZN9qBOSQWOSQ Q5uD6eTN8brk3Og3WzH1nopezLya979yW63A+cq2Blot88MTOcxQplxjOeHeLcEzmIVQSP 0Fqbq9+oefX6bfxPMCMohjq/75qLz4Q= Received: by mail-pl1-f181.google.com with SMTP id d9443c01a7336-220c8f38febso5857475ad.2 for ; Wed, 12 Feb 2025 18:54:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1739415260; x=1740020060; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=FkEPKUK4TubZ6Z6+0k4LQ0SxXfbAAf7UoZRYB0nxrs0=; b=d0oaY+Jg73Fn9B4jvapmIVXUh6SOskUj1jdNjE7P0lchxGdaCcqAuuZqY3d9j54eok HfEKhy3JuEow0THDeOdBg16mg4ihPSGnkqiPIxbclWrsoJ3M2K80PH5oeMJYpLPcmmRu OZ82t9SYA7QS3ct62HEzwO3xGZ2KouTuSYnaU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739415260; x=1740020060; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=FkEPKUK4TubZ6Z6+0k4LQ0SxXfbAAf7UoZRYB0nxrs0=; b=ABD6D7G/kXt90HE0DUcDQR32ljVDLD1nevceAVp47y1bsEWeme71cUWNcvOBKudBTw NlzMwcDxIdenM8jkyKVJ6eC7tr6lZCelgb+67v2Vbw0IMerzOhDVgwCUPG8nK7XiaDba frybLV+1zspI7ll3XXfqe7T3U2eIAW7sVT2WkhO+TNP3d/zSkpEaIX6ruQyvIYc7xgfj uC2pEEpLCtlXYXC7/6d9qRLBOZ4mPDTSzGExycKZRNhjSJ3yGLOIP6bR4FNsWwHV5hJN a3MR3rh+439pDqVvL08d3CBtOYgSvRZ480Eq7CQLEugVyN29H2DjuHFmoNUTCsi3P3hy AcFw== X-Forwarded-Encrypted: i=1; AJvYcCX1e5F9l7qyb2aRPUf0+gy1r+xVko3JAgOoe+knza4N7HFLeOPvPYwCt/DqmFgdR2j2KBr4H297mg==@kvack.org X-Gm-Message-State: AOJu0YyCGAxOZO7JNpo/2e2JFA2oYCTvbll9fk5eY7/2mvtYiADpOKSD MIKNxCrh9Mpql95jiaFdUUC/cHUoG2Koz3fcWOCSfGjTUzeabz8JdbXgOBjA+A== X-Gm-Gg: ASbGncvUAbG3vZvPrgxBxG4cWahDoL6IMLQ4QC5oSY5StNR+gBoi8tdtkqkTqLG3ZWZ TRaSASeoOhtWiTRNOIS+6NgC8j/XxxKuIHtNFI1kyMuQeVl2BF1DICl72ssmbVocsCggMPtZuRf 5bZQoGHsAzfRffc20O5aM8IDOGes74fty+tuEl7TqWW/siMH39vML5UpV98D+SIIIoHuHQaWt6E ubhlnAs83C2f5faBiSyVY16T/tbg2D065Hgob6fFhydHE3DuMuR4+w4Mb0llXHp5Ud9Opppnh7v c+slUKIFi3xlkOqIAn8= X-Google-Smtp-Source: AGHT+IF359UMSOwJG5zyuaB6ecGZdxQbBzDMlQGReXoiCgo2R2yvu3zOnQgdn1+e1o6JRf3jPuZh0A== X-Received: by 2002:a17:902:f643:b0:216:57a6:2887 with SMTP id d9443c01a7336-220bdf15c1cmr85751915ad.21.1739415260009; Wed, 12 Feb 2025 18:54:20 -0800 (PST) Received: from google.com ([2401:fa00:8f:203:3ed3:97ce:5f5f:1f61]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-220d545d54fsm2340115ad.141.2025.02.12.18.54.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Feb 2025 18:54:19 -0800 (PST) Date: Thu, 13 Feb 2025 11:54:14 +0900 From: Sergey Senozhatsky To: Yosry Ahmed Cc: Sergey Senozhatsky , Andrew Morton , Kairui Song , Minchan Kim , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 10/18] zsmalloc: factor out pool locking helpers Message-ID: References: <20250212063153.179231-1-senozhatsky@chromium.org> <20250212063153.179231-11-senozhatsky@chromium.org> <5htndqx74yv2lq2zr2odozrrbi5cz6zizn3vk4uosobn4ceoji@5zuknjmi26f6> <28ed23c00effdd531a9e027feb0bc08e22fc677d@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <28ed23c00effdd531a9e027feb0bc08e22fc677d@linux.dev> X-Rspam-User: X-Rspamd-Queue-Id: 2671080005 X-Rspamd-Server: rspam12 X-Stat-Signature: tssjgxy9k57n7qynqmj113g1y6sqdgsq X-HE-Tag: 1739415260-168050 X-HE-Meta: U2FsdGVkX1/aBCHpBGcOt04diJEYsWn86gEn35fYMSwYfFZdIPU7FRtgUrg4fiWfG1IxGHWd0jEFdC+M+RHVJ2ldwuXAK1Tp9kHQvDz1FBgistu7h8Expj21dHGVcM4F7zR4h8HL6YBx1l6psq4wDfBWtHt693j2Qml1BEAZcsZuO96F6KxXt2uK0us7H94QEpiyYlb1Oz59HzOeRc6Q4+F0IiTKdDPjPlJ98fJEC1yxDMyTCTD+4ePXW0SPgvJ/LTZaFvbuHxlWKoY8qwrssGctmNMiegA7I6nlH0lQ0OcHjggsKlVczZHq050aRhIZ4C+2GPTvq8DbItUq260TkeQZoN3vtIxuKbPeAmSufjl6wcjTP2d3STi6SVMXNWccylaBNdsN9wEDFVK7u3HPAgHHD/sZpdPpVbefIteD+WEgbYlWDa2yL277LxrubyfGQR/Fd/jDCJtPYPvfFuJqhktYEjnoN/4e7ugVW/5QhWnQtlgMuAiAzGomqQ/MdzfrMU4p9RlBf2Hb/aU+XxRcu0k8M+wdoAYnNAvEQsVlDkDSWHl8PP3DQTqdCS3Sv7IvfBBGuKTzx5vSIQwuhJ7jfCx9Bedd2BLPhylhQYXoKd/jFiAPDFWMe8LClAstzykk1/W3liqACHZ81mD+6O6G3NNa68ZoffRzfwX5cf0sY1MGJD+v4ur/YeVvcCkP/DEGQsbDskwx/qg0VtVX61Ro2GFNxuPFOqI+aUkDkspNlaYK4mPafixNK/K6ozXUPoKIHf1cePPpswHju6ny5yFj0PhjXnUxaRthCJz8C88NkaRQ+gO6maG2x5nLmOoVakiukuobRzl1M3tvxpksmrxIWogplnKNG1OR0NIGIChbijd/sSIP5qHhCm2F+XwCT0ze9YIvFPOeZDeHwTVada1JexlOl/KDwjT/PtJnN3vzI6BeqGMK5u0ZhxNrf9hNkhkAqSdJw1SwbZedVd47/29 yIXyjGbL BUhpjYFvA9t2QCtaT1hxKec+bKyPwG2NWjRstpk7gHqA+NJ8zWwILznZz/YL9+wwUvJqMFH7pT8RMkGpJiKJ3AdXsRdct7vmLF4N7eovyVBLEtexgAod1TWIfCfHBEVnXGNpnaLDRcsV7Iz+X5B6+2IrUFGStTUYq++Fw+39fYVonvlhg5QZJWubBMQhTKR2CbNY+2sUp2FANZDhjGQqbiY7nitowI1HTvJDnJkCxtLmo1RfLJFZGp7DKJRsu2ldhF1yhULsEgwSUeDSf45BB+1adOvMMr4igXdkL/kuutf5IcbYcbz5GSW3FYNymWcWdYgiZHYqzPVxb1o3tMOZ9Cw2dbhaLu+DBQ+4IGVS2eDU/gcc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.024022, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On (25/02/13 01:12), Yosry Ahmed wrote: > > I want to hide the details, keep them in one place and at some > > > > point *in the future* have the same "locking rules" as for zspage > > > > lock. Also *possibly* throwing a couple of lockdep assertions. > > > > So I'd prefer to abstract all of these. > > > I'd prefer to introduce the abstractions when they are needed tbh. Right now they just make the code less readable. OK, gone now. I think I didn't screw things up resolving the conflicts.