From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4A95C38A02 for ; Sat, 29 Oct 2022 02:35:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F39656B0072; Fri, 28 Oct 2022 22:35:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EE8EC6B0073; Fri, 28 Oct 2022 22:35:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DD7986B0074; Fri, 28 Oct 2022 22:35:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id D08326B0072 for ; Fri, 28 Oct 2022 22:35:34 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id A2748A0493 for ; Sat, 29 Oct 2022 02:35:34 +0000 (UTC) X-FDA: 80072420988.03.9D5BB5D Received: from szxga03-in.huawei.com (szxga03-in.huawei.com [45.249.212.189]) by imf05.hostedemail.com (Postfix) with ESMTP id A5CA7100021 for ; Sat, 29 Oct 2022 02:35:32 +0000 (UTC) Received: from canpemm500002.china.huawei.com (unknown [172.30.72.53]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4Mzk394c1DzFqRL; Sat, 29 Oct 2022 10:32:37 +0800 (CST) Received: from [10.174.151.185] (10.174.151.185) by canpemm500002.china.huawei.com (7.192.104.244) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Sat, 29 Oct 2022 10:35:26 +0800 Subject: Re: [PATCH RFC 1/2] mm: Always compile in pte markers To: Peter Xu , , CC: Huang Ying , Andrew Morton , HORIGUCHI NAOYA , David Hildenbrand , Andrea Arcangeli References: <20221024204830.1342169-1-peterx@redhat.com> <20221024204830.1342169-2-peterx@redhat.com> From: Miaohe Lin Message-ID: Date: Sat, 29 Oct 2022 10:35:26 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <20221024204830.1342169-2-peterx@redhat.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.151.185] X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To canpemm500002.china.huawei.com (7.192.104.244) X-CFilter-Loop: Reflected ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1667010934; a=rsa-sha256; cv=none; b=HHW1mDmw1tzP+P6I6e4zyOUX8AbdV5Im5Z7gLpKHpTT6WFvUZiM2XTPYnf/3z5nyKj21PM FXZaP+sZVDNbsFzvaiJkGSIhKk1zd4x/aBEI0tXbSPoRiVBZg3CX6AeWZqspgvzEFadP9n 8l3CVov/Sol6q7Icu5Vgar1Daf1cx1o= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=none; spf=pass (imf05.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.189 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1667010934; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CeQV8/Lv12Vv3wq6wefed/NUxqrgozVpHYnLSwvXhqM=; b=Qhop/Y3gISkX1CF3AB98HDmcra6+mzRTJyHQE3uBnsdvpcSxde1w3abDjXMQT0EYHI/j3r XNRGEFbbW66uT9mdaImUOMNUCMxgNMNQRrkAB2n95v5kyAOLcd/ziwdAj7pa26/EfhPHj7 FWTZwvoUIUTBEluZs+9b+dhubfJB90M= Authentication-Results: imf05.hostedemail.com; dkim=none; spf=pass (imf05.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.189 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: A5CA7100021 X-Stat-Signature: xohj7usnw9wog8a96ojgpji35zff764e X-Rspam-User: X-HE-Tag: 1667010932-299789 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2022/10/25 4:48, Peter Xu wrote: > The PTE markers code is tiny and now it's enabled for most of the > distributions. It's fine to keep it as-is, but to make a broader use of > it (e.g. replacing read error swap entry) it needs to be there always > otherwise we need special code path to take care of !PTE_MARKER case. > > It'll be easier just make pte marker always exist. Use this chance to > extend its usage to anonymous too by simply touching up some of the old > comments, because it'll be used for anonymous pages in the follow up > patches. > > Signed-off-by: Peter Xu Many thanks for your work. Reviewed-by: Miaohe Lin Thanks, Miaohe Lin