From: Miaohe Lin <linmiaohe@huawei.com>
To: Peter Xu <peterx@redhat.com>, <linux-kernel@vger.kernel.org>,
<linux-mm@kvack.org>
Cc: Huang Ying <ying.huang@intel.com>,
Andrew Morton <akpm@linux-foundation.org>,
HORIGUCHI NAOYA <naoya.horiguchi@nec.com>,
David Hildenbrand <david@redhat.com>,
Andrea Arcangeli <aarcange@redhat.com>
Subject: Re: [PATCH RFC 1/2] mm: Always compile in pte markers
Date: Sat, 29 Oct 2022 10:35:26 +0800 [thread overview]
Message-ID: <cbbb7a4d-1c96-1102-45fc-5f0ffb329518@huawei.com> (raw)
In-Reply-To: <20221024204830.1342169-2-peterx@redhat.com>
On 2022/10/25 4:48, Peter Xu wrote:
> The PTE markers code is tiny and now it's enabled for most of the
> distributions. It's fine to keep it as-is, but to make a broader use of
> it (e.g. replacing read error swap entry) it needs to be there always
> otherwise we need special code path to take care of !PTE_MARKER case.
>
> It'll be easier just make pte marker always exist. Use this chance to
> extend its usage to anonymous too by simply touching up some of the old
> comments, because it'll be used for anonymous pages in the follow up
> patches.
>
> Signed-off-by: Peter Xu <peterx@redhat.com>
Many thanks for your work.
Reviewed-by: Miaohe Lin <linmiaohe@huawei.com>
Thanks,
Miaohe Lin
next prev parent reply other threads:[~2022-10-29 2:35 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-24 20:48 [PATCH RFC 0/2] mm: Use pte marker for swapin errors Peter Xu
2022-10-24 20:48 ` [PATCH RFC 1/2] mm: Always compile in pte markers Peter Xu
2022-10-29 2:35 ` Miaohe Lin [this message]
2022-10-24 20:48 ` [PATCH RFC 2/2] mm: Use pte markers for swap errors Peter Xu
2022-10-25 15:31 ` David Hildenbrand
2022-10-25 15:44 ` Peter Xu
2022-10-29 2:49 ` Miaohe Lin
2022-10-25 3:01 ` [PATCH RFC 0/2] mm: Use pte marker for swapin errors Huang, Ying
2022-10-25 15:08 ` Peter Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cbbb7a4d-1c96-1102-45fc-5f0ffb329518@huawei.com \
--to=linmiaohe@huawei.com \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=david@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=naoya.horiguchi@nec.com \
--cc=peterx@redhat.com \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox