From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 168BDC25B4F for ; Sun, 12 May 2024 17:12:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9A1A96B0196; Sun, 12 May 2024 13:12:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9529C6B0197; Sun, 12 May 2024 13:12:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 818A76B0198; Sun, 12 May 2024 13:12:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 6452C6B0196 for ; Sun, 12 May 2024 13:12:19 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id F11B41C0B92 for ; Sun, 12 May 2024 17:12:18 +0000 (UTC) X-FDA: 82110387156.14.101C69F Received: from relay2-d.mail.gandi.net (relay2-d.mail.gandi.net [217.70.183.194]) by imf27.hostedemail.com (Postfix) with ESMTP id 283084000D for ; Sun, 12 May 2024 17:12:16 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=none; spf=pass (imf27.hostedemail.com: domain of alex@ghiti.fr designates 217.70.183.194 as permitted sender) smtp.mailfrom=alex@ghiti.fr; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1715533937; a=rsa-sha256; cv=none; b=n0lWmnqFo5i9tgwlVBSIFayXEjgdH9IMCPWoRCB7vOl2k0jwibE6+xg11Grrrdi1kraIxb CteiEwmqLcgZbIq6ylX3oCOAJ4z8Ceo+d8PbQUEmr4HL5hkxshAgr8JvD88ov1o331HafS GwFkzTpgfIu0uO1JKhHqU9FTRh6b1cM= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=none; spf=pass (imf27.hostedemail.com: domain of alex@ghiti.fr designates 217.70.183.194 as permitted sender) smtp.mailfrom=alex@ghiti.fr; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1715533937; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=r1FxZ4SpT96GevNw3j4CHa7RwSLprV1wehQjF7UvVtw=; b=hYPX9yXve1+3HfvY6Ejk1gJQbo62s3Lm68zI7zOXd0AL6dJgCoF/eePN7a/Lp/PZR5Hhls GWGG8+3XmuuucEITBoJbig1xBKil8GlSBq4K/+tLukCHdStmZLH2I/rnX0d+vopNOHySV5 IBpMOly76cQkAwgb5pOw/V/i3rYMaLc= Received: by mail.gandi.net (Postfix) with ESMTPSA id B9EE740007; Sun, 12 May 2024 17:11:03 +0000 (UTC) Message-ID: Date: Sun, 12 May 2024 19:10:59 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 20/29] riscv/kernel: update __show_regs to print shadow stack register Content-Language: en-US To: Deepak Gupta , paul.walmsley@sifive.com, rick.p.edgecombe@intel.com, broonie@kernel.org, Szabolcs.Nagy@arm.com, kito.cheng@sifive.com, keescook@chromium.org, ajones@ventanamicro.com, conor.dooley@microchip.com, cleger@rivosinc.com, atishp@atishpatra.org, bjorn@rivosinc.com, alexghiti@rivosinc.com, samuel.holland@sifive.com, conor@kernel.org Cc: linux-doc@vger.kernel.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-kselftest@vger.kernel.org, corbet@lwn.net, palmer@dabbelt.com, aou@eecs.berkeley.edu, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, oleg@redhat.com, akpm@linux-foundation.org, arnd@arndb.de, ebiederm@xmission.com, Liam.Howlett@oracle.com, vbabka@suse.cz, lstoakes@gmail.com, shuah@kernel.org, brauner@kernel.org, andy.chiu@sifive.com, jerry.shih@sifive.com, hankuan.chen@sifive.com, greentime.hu@sifive.com, evan@rivosinc.com, xiao.w.wang@intel.com, charlie@rivosinc.com, apatel@ventanamicro.com, mchitale@ventanamicro.com, dbarboza@ventanamicro.com, sameo@rivosinc.com, shikemeng@huaweicloud.com, willy@infradead.org, vincent.chen@sifive.com, guoren@kernel.org, samitolvanen@google.com, songshuaishuai@tinylab.org, gerg@kernel.org, heiko@sntech.de, bhe@redhat.com, jeeheng.sia@starfivetech.com, cyy@cyyself.name, maskray@google.com, ancientmodern4@gmail.com, mathis.salmen@matsal.de, cuiyunhui@bytedance.com, bgray@linux.ibm.com, mpe@ellerman.id.au, baruch@tkos.co.il, alx@kernel.org, david@redhat.com, catalin.marinas@arm.com, revest@chromium.org, josh@joshtriplett.org, shr@devkernel.io, deller@gmx.de, omosnace@redhat.com, ojeda@kernel.org, jhubbard@nvidia.com References: <20240403234054.2020347-1-debug@rivosinc.com> <20240403234054.2020347-21-debug@rivosinc.com> From: Alexandre Ghiti In-Reply-To: <20240403234054.2020347-21-debug@rivosinc.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-GND-Sasl: alex@ghiti.fr X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 283084000D X-Stat-Signature: c9mqu8irqo3p8oz6eppki1byozp63iei X-HE-Tag: 1715533936-121825 X-HE-Meta: U2FsdGVkX192uFr0C+gaCK6fyAxelYe34RSQhUDcR6eZXkOfIAJnooue462yhjhI0BzQP77+wWarGTRH8gpLQAJEpEJ6GKyBKyqrGSOv7it4oHNJqR4+VH0tAeHlfiBpjFbSMa9W7xlall2hkjQTg4/UPPILDntNAp7Xq6lyCpYcLSD2wWTHOPT9PL+7/g88laHyHJLGaUbuKnDBtY6/vQdnXQR2ybB5LBG9RBARZbTYpHdfZ4zTP1/ppPOtaq5C4JqhW2bu+lPSwPIMu/Oflo7j5Z11e8NmbSTFMWknzZ92gRjpEFfBgO9FJhxwypF0pfKrzNWyduGmEpBGDwDDT3hVkJD+kRT3k/886hu2z4i8uqXj5R2/MlHGhApVvLaPs00E2KlcZH1Q4/XJTOYff5JSyuV8jCgXz+tF61nCYWDUZHxsgeySGw8Eg37rC0gZJownrcmXL5giJ6wAQ3hzx1CJj4cnWYyJR/GN7948wVEBFGT/QJYAGhnd2khOmgT53qenGEhNK8APG+4HVoiISn1x3C/YJMurSWQRXE1PJUMY4Wh3w77zzgcxJaj2XpKc0SLLrkOS7MjgEBhSSWyvH99r7Snk3XCpsXI/Xs7oAoAGiaqCwEnMQuhLU5bM1QjEKr8PQU+aWmNLTsOrxo/XKoG+x/DnWZ6idWA2TF2h2VLcFELpNCucXVR83rLmRp/GPvkS7ehsJIz11eOxb9F7x8ybHVqQZo1AtVmwupfA0FTveAMYq7lvZmEpAXJGI6Z0fURvEnG5LdxupqBd14WHRE53bAUMNVxqeOmLpvEa08+M7LYhFyO7TwO+preQ49m0M+apfig3gwfVwH+78EwNoQE9B5jiI9MVw90QeXNdGCMPylM5lz5fhqdis6lbLSOao39hR3EeVIzwZlJQ7/SKMwBWNaDKJ634CX/jEkBo/1LMZFe0q7fOqW+UQ64UutEZ+6u03A1v50xoWds+WtL oiDgwH5S dFhbvX3/6uKncPVaA98QDIlAzj/PtEJZPnbpTz6ieu8/BlrEwBeZSvSdHClaqAZBs7MhLghF45EQM0a22x1aKW5p/UsPQitWyAxRb/5CgLE22CkvSUkoUMEOWwF8aagPbu7hu6W98zBYb7vAxW3V9yan+RuDKz/6ieWEhqqutL1PMvRdhSy2DBwMqPNIEXqhJ/O+rdSTd3HVIr1xsiUH8JbHVATJKaJHBUUza1Bu5VGGjIIpULzIDV9sW/6gV74Uh7hcjCuuhLfa/Ho0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000009, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 04/04/2024 01:35, Deepak Gupta wrote: > Updating __show_regs to print captured shadow stack pointer as well. > On tasks where shadow stack is disabled, it'll simply print 0. > > Signed-off-by: Deepak Gupta > --- > arch/riscv/kernel/process.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/riscv/kernel/process.c b/arch/riscv/kernel/process.c > index ebed7589c51a..079fd6cd6446 100644 > --- a/arch/riscv/kernel/process.c > +++ b/arch/riscv/kernel/process.c > @@ -89,8 +89,8 @@ void __show_regs(struct pt_regs *regs) > regs->s8, regs->s9, regs->s10); > pr_cont(" s11: " REG_FMT " t3 : " REG_FMT " t4 : " REG_FMT "\n", > regs->s11, regs->t3, regs->t4); > - pr_cont(" t5 : " REG_FMT " t6 : " REG_FMT "\n", > - regs->t5, regs->t6); > + pr_cont(" t5 : " REG_FMT " t6 : " REG_FMT " ssp : " REG_FMT "\n", > + regs->t5, regs->t6, get_active_shstk(current)); > > pr_cont("status: " REG_FMT " badaddr: " REG_FMT " cause: " REG_FMT "\n", > regs->status, regs->badaddr, regs->cause); Reviewed-by: Alexandre Ghiti