From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8BE9AC282EC for ; Mon, 17 Mar 2025 10:09:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 66E20280002; Mon, 17 Mar 2025 06:09:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 61ED1280001; Mon, 17 Mar 2025 06:09:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4BFFA280002; Mon, 17 Mar 2025 06:09:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 2F2E1280001 for ; Mon, 17 Mar 2025 06:09:41 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 3FFFA81BA7 for ; Mon, 17 Mar 2025 10:09:41 +0000 (UTC) X-FDA: 83230621362.30.BE8E82A Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf29.hostedemail.com (Postfix) with ESMTP id 913B7120006 for ; Mon, 17 Mar 2025 10:09:38 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=2zqCNa3k; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=ZnSs9nuF; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=2zqCNa3k; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=ZnSs9nuF; spf=pass (imf29.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1742206178; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=3Xq7lBKy5lPmzEwBcsRowSYenNgBJYixD9T0ziVEtAY=; b=vUtMM+ZcG0H1ImEo1EynGFYO6BEDTZYWo6UZ5q21rCnrhU4eJlwgnep3YX0Ouyp5xDqRA5 tyKKt1PKnNGbE8m+xe+jIFoVk8DKTSNo1PDi56VLU9fpHePAyl4om3GOlJ0hE/ZGrtyNVd 5Sl9t7cH23UIreITmrEL5/x1cck8lqc= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1742206178; a=rsa-sha256; cv=none; b=ztGOtXtAsGkbJeoi1dxwRxR3JJW0+iq7V6szgkwzxgnSUUkWKzHuR0DRQmbXHjJoFxPWVG R/fe1NJPHkHAojd06pg1BGxaxJcRyWoWa5R5LxIUWmsqks1ezmkjIy6es/WSRUl1Xn/S5B bFPCAsC73oOBogIO/XAgK75zTuWZKeY= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=2zqCNa3k; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=ZnSs9nuF; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=2zqCNa3k; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=ZnSs9nuF; spf=pass (imf29.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id C79C721A9A; Mon, 17 Mar 2025 10:09:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1742206176; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3Xq7lBKy5lPmzEwBcsRowSYenNgBJYixD9T0ziVEtAY=; b=2zqCNa3kOVVBSVca1eFpmuD2rauprLsaCT8uTN/qFLPOeMTXGiTS9CaD4OeQvhwEJq1gso ofI8IPJ+SvfaMp1x4Gu13/5lFeHK7hA5FgfKrOtBZS3QIh2NdLrilv4ga4Quh/VqsU+IUt jqQhTomHtMeYnTnv8IzfxnfvaJodeuY= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1742206176; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3Xq7lBKy5lPmzEwBcsRowSYenNgBJYixD9T0ziVEtAY=; b=ZnSs9nuFD0z+rG2M8LU8sWQX3IW8ha2hxgwarPk0hSgs1pxan4YEvYoz3z5837YDFSdmn1 rqxTVt50H90QMwCQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1742206176; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3Xq7lBKy5lPmzEwBcsRowSYenNgBJYixD9T0ziVEtAY=; b=2zqCNa3kOVVBSVca1eFpmuD2rauprLsaCT8uTN/qFLPOeMTXGiTS9CaD4OeQvhwEJq1gso ofI8IPJ+SvfaMp1x4Gu13/5lFeHK7hA5FgfKrOtBZS3QIh2NdLrilv4ga4Quh/VqsU+IUt jqQhTomHtMeYnTnv8IzfxnfvaJodeuY= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1742206176; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3Xq7lBKy5lPmzEwBcsRowSYenNgBJYixD9T0ziVEtAY=; b=ZnSs9nuFD0z+rG2M8LU8sWQX3IW8ha2hxgwarPk0hSgs1pxan4YEvYoz3z5837YDFSdmn1 rqxTVt50H90QMwCQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 77728132CF; Mon, 17 Mar 2025 10:09:36 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id FW3OHOD012cIHQAAD6G6ig (envelope-from ); Mon, 17 Mar 2025 10:09:36 +0000 Message-ID: Date: Mon, 17 Mar 2025 11:09:36 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RFC v2 01/10] slab: add opt-in caching layer of percpu sheaves Content-Language: en-US To: Suren Baghdasaryan Cc: "Liam R. Howlett" , Christoph Lameter , David Rientjes , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, Uladzislau Rezki , linux-mm@kvack.org, linux-kernel@vger.kernel.org, rcu@vger.kernel.org, maple-tree@lists.infradead.org References: <20250214-slub-percpu-caches-v2-0-88592ee0966a@suse.cz> <20250214-slub-percpu-caches-v2-1-88592ee0966a@suse.cz> From: Vlastimil Babka In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspamd-Action: no action X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 913B7120006 X-Stat-Signature: d57e5pyanf7qr3xb5xz99njfmcy5eyqs X-HE-Tag: 1742206178-448977 X-HE-Meta: U2FsdGVkX19qWSoi9O5EkYZ8dNncdAXf2QsAcgFVlx9l0NwTumpZo0YZiCo6oigMbyHrcdSCgYpYoqOXoVSApWd6JqObs29TQfCBrk8A8hlYqOOsgICHCeITwlHbWZmVlEa6IKWsrtzBWvti+Ndi1PkAwDSAYNefOSrUaQukkFXbILU+MA/Z7Lq/4XXMtTr2Tc5DDbeFwqzj1tY9dteJjShX0ZqGrdcsDOBA7ghmLpQRyQRWgg1WGjGqWdM/sfO8XUdN8c3CGyHRHb9dQOIRb+fufYsCaIac1/9SRtsxih1I1rZdgxe7iz8uxiQ3ZI+UfCTNjgl1l+QspooPeRWVDaen0f5LALraJXi+sqbnKnl2uAWzV68slR2+SvNZCj+4/2/BsEb/GNRtd1LHETSNMHTggLm1HmjIhBwE2eF8wjVvhRMQQ64ewk0EQvIPSaCujUofYu8bJ9B0HueZBElqg/FPAs9yLnChKH6G0RB7o3ywMrE+iJu8O01sn/IGjo1Kpi2whw5LIhHP3IJwl++/3WN3V1xBcs4g8d1rp61zwzxf9sEDKJYSRQancTgDYR9+xy33LI26u3jxaq8FSGMU3yv02Grfou8cz0C/AmHxKj9ljVARVL1dkGRr46Z0Yauk+9DrY57azUyKTaF7YDjx37eNVk5eKkZR52CJ8KENF44u5nMRJAYPCYfAo/9fMrJ54b/p0ltBmFgQ5IOIYR2or6l756UBODRMP7mnIgWKDgYiANuUcbjEOCHOlz76CuTcg9oBJpi+3uPsWXl0xPdUidKQYY0HMk1XKx34YZ5KkgmS9lDvgMcK/4JyHI4rkbkiP5in24tkLO66L6prDpQO6WKCSSGOFvQrVkSoILhnBCO/pRFxxFkXyw+VefegTOYEm0Ji87yU4CgpfwXjxL6zndQH+dZFI1P8sgzDGcOcMJ/Gbq98HE/F9YHfpsN5RMTFMp1rhYaLhaDr8B3wdJ9 4P2VTvai 1hY+KPNclGbbM7JvXqQjYIIbClTAm32fDR0VIxhtgIoYJpYPqbWSbxDZSJZkLdAc/NP+wSIoVDqzSyLyuTBWwsMzdRkloNad+rv7UUBU4po7er1VAcEcyUnVOtuqfFxjM2CwfzDgxcSTAW0H3WFWIKEU8rIT6wqFsNRETVw3xQFjaiDicJEH+lmEmD//JDpd1uYv/A6THyhQ6GLeV+Gv71F1TRENJyZ3ILE3+Hk3dv1rD5s4+qCq8XGgr6aRZpGtInmoe8Slcuniv/3qurB4iGXNrAHmVqXLBDFr9LNXPkrDdF0+fNafNhxPt8Ckx0x6R1OH1s5sAKwvfB5JBaW+LdkcmtdoqY8XnA+mtjHg1Zgac4WQk+ON7SPXsjJ/Sk7INmtuH X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 3/12/25 16:14, Suren Baghdasaryan wrote: > On Wed, Mar 12, 2025 at 7:58 AM Vlastimil Babka wrote: >> > I find the program flow in this function quite complex and hard to >> > follow. I think refactoring the above block starting from "pcs = >> > this_cpu_ptr(s->cpu_sheaves)" would somewhat simplify it. That >> > eliminates the need for the "got_empty" label and makes the >> > locking/unlocking sequence of s->cpu_sheaves->lock a bit more clear. >> >> I'm a bit lost, refactoring how exactly? > > I thought moving the code above into a function above starting from > "pcs = this_cpu_ptr(s->cpu_sheaves)" into its own function would > simplify the flow. But as I said, it's a nit. If you try and don't > like that feel free to ignore this suggestion. OK did it and although I didn't manage to remove the got_empty label, it's better and I realized I can handle the cases there in a better order and add one extra possible fallback in the unlikely cases. Please check the result when I send v3? thanks >> >> >> + } >> >> + >> >> +do_free: >> >> + pcs->main->objects[pcs->main->size++] = object; >> >> + >> >> + local_unlock_irqrestore(&s->cpu_sheaves->lock, flags); >> >> + >> >> + stat(s, FREE_PCS); >> >> +}