From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9AFFEC3DA4A for ; Fri, 9 Aug 2024 16:48:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 11B426B0085; Fri, 9 Aug 2024 12:48:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0CBAB6B00A1; Fri, 9 Aug 2024 12:48:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id ED5206B00A2; Fri, 9 Aug 2024 12:48:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id C867F6B0085 for ; Fri, 9 Aug 2024 12:48:24 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 6A3DE1A12A0 for ; Fri, 9 Aug 2024 16:48:24 +0000 (UTC) X-FDA: 82433290128.24.4BA311D Received: from mail-il1-f176.google.com (mail-il1-f176.google.com [209.85.166.176]) by imf23.hostedemail.com (Postfix) with ESMTP id 52404140016 for ; Fri, 9 Aug 2024 16:48:22 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=google header.b=A4pKWvfl; spf=pass (imf23.hostedemail.com: domain of skhan@linuxfoundation.org designates 209.85.166.176 as permitted sender) smtp.mailfrom=skhan@linuxfoundation.org; dmarc=pass (policy=none) header.from=linuxfoundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1723222050; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=XIBS2fiq1eabJ4IYCoixxVdAtJaZLZJZMFj7PGFDm3c=; b=kZXHg4lYTDeP1PEmZaa/jgVO3Q4sIfrEfE1APH+kyYCjeAHLuKmMMo9HSJftOH9bVkADmd VZLGPXY62uFSf2YW+WPO8lj9CaOqb4cZJZuMwmsqvqaCQQ4ImhyAgiAt0MF6k4+pcZUB68 9RXd8qv91MEMxC8fwcKj2ZTVPdHiMt4= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=google header.b=A4pKWvfl; spf=pass (imf23.hostedemail.com: domain of skhan@linuxfoundation.org designates 209.85.166.176 as permitted sender) smtp.mailfrom=skhan@linuxfoundation.org; dmarc=pass (policy=none) header.from=linuxfoundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1723222050; a=rsa-sha256; cv=none; b=JWijRxgqQrGi+4Uadhr/VqMY06RqZy9iALZiHNAmSXvj+dBSSBntZ1iUBHkHsf++bL1Opr 65CJLpSH3palDlg4lPhsGYkhiWmp3ZITdY8JYtUyCs/BmtJSfxUkHmjfJ9f2bGzHFhs9QV TLFP1ln1gz08H2uysimeSfzpKeR7KwM= Received: by mail-il1-f176.google.com with SMTP id e9e14a558f8ab-39b2cead848so1059985ab.0 for ; Fri, 09 Aug 2024 09:48:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; t=1723222101; x=1723826901; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=XIBS2fiq1eabJ4IYCoixxVdAtJaZLZJZMFj7PGFDm3c=; b=A4pKWvfluUt9bwOc7zgwRh3CEcxcQy9yD0UZc+dgQaRd6d3J824+llx+OnOzqpNcCh cD51DchgzDGu+UTbEGePw82jZd60hRXQZ1JuLtZxIeA/P7rNmMiLMCgBGxISTEUy6a9U euItrGFAY65rGr0h6rrNqusk/ylxkPQHedpT8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723222101; x=1723826901; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=XIBS2fiq1eabJ4IYCoixxVdAtJaZLZJZMFj7PGFDm3c=; b=TPtZkJKMgsxrHPeNchPBjbonypU/PGW2q/d67R6c5TkAOtbuWxF1CV5lXVi0Ozu5Ve VBP0EFRge2Mw//hITJfInuKot6jmV8iIXnZzzlAgZFM+4kH0ppP1bHhKtxK6NJ+KozQv EFPv3MJWdepq4XRbl98UBVwiZFXAWO4j/udDGGoviWyY8NwzGvL74OhXVMBNtTRE3XcQ Aki1yPz+Stw5vZHDUbKYEGaHhPyYw9bRMHgTn1KAPZNZLyYF2JX/MIW5H4NyleoCVV0V 4hN4LFhQbJwtb/Ydm7rFM9TS0+a9K+BuEWSyuXzcyNzOzuw0H+mf+l1WC0pL1nOUswiY uLOQ== X-Forwarded-Encrypted: i=1; AJvYcCVorWbnopRWxIpstk3hp3KJ6unCOYCfuQYE/BIRmMZQuzqvnHDtvRppzrPXrnd2Iwgx9h918QYzQN1hOu6NCUvLxkQ= X-Gm-Message-State: AOJu0YzGyOmaSwBoA9ybCdNytGM3ueYrA5eDgH6dFZyGHmNuQaaFIB+W VyZKCrP8zK23CN4EMKMhMK97GvwNeoXmBqYAMGUkSOB37P8FjjUahMDQhD479Xo= X-Google-Smtp-Source: AGHT+IEPtXUbZewJJPbHdH3NNNItqquYGOjjEuRG2n0DfjjJa+ymgUHQYn2ADond5MgNHtrhIJmfAA== X-Received: by 2002:a05:6e02:2193:b0:39a:eac8:9be8 with SMTP id e9e14a558f8ab-39b7a40deb6mr15291675ab.1.1723222101188; Fri, 09 Aug 2024 09:48:21 -0700 (PDT) Received: from [192.168.1.128] ([38.175.170.29]) by smtp.gmail.com with ESMTPSA id e9e14a558f8ab-39b20a9ab7fsm65210735ab.6.2024.08.09.09.48.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 09 Aug 2024 09:48:19 -0700 (PDT) Message-ID: Date: Fri, 9 Aug 2024 10:48:18 -0600 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] selftests: memfd_secret: don't build memfd_secret test on unsupported arches To: Muhammad Usama Anjum , Andrew Morton , Shuah Khan , Paul Walmsley , Palmer Dabbelt , Albert Ou , James Bottomley , Mike Rapoport Cc: kernel@collabora.com, stable@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, Shuah Khan References: <20240809075642.403247-1-usama.anjum@collabora.com> Content-Language: en-US From: Shuah Khan In-Reply-To: <20240809075642.403247-1-usama.anjum@collabora.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: srfe3pb6josqdke1z3eawipwnm9b5pjq X-Rspam-User: X-Rspamd-Queue-Id: 52404140016 X-Rspamd-Server: rspam02 X-HE-Tag: 1723222102-577501 X-HE-Meta: U2FsdGVkX19PMyml7s2THsphIybssB7des+EauNug6dWY382YPJSmTbCCKpRnTSO/0usb53OzQ8a5iRhKt8bHjDJA3CDrU/dqyuIbcXgd5FTubHqYe8FDmqLj+nctU1gFdUylrBE00mTD2Jd2byNMyfMAfbaXxn7PKWbdCED1LS5tp2I5bXIeSXKYRcd78NXbhbEIBzX9rAc2Ry0xk+z9dwuP7/s3RSVdFoCAmqfqTclVznpasALu4zbZHjtJY0WYI5PYCWEYgCa42lla7xNg0nRE8DStj45ax4qsBdI7ZmhfucsEY8tWIwl7oX0xHAgG3Zsc8F4I9Q2+K98ioMbx51kJSq1ZkhcivCdQ2bCJRonVFC/iISdoxiDHOaUHzfzO/FWfwO1bZ0TshjUpVH8PLOPn8B1hru1IzGg2Ley9orMQ46PeI5Cz6FaO1qT2e091Hk2I7IVaBowoZ2flNaQsAXh43yO5TVua9MEoiN3rBDKWh23c7h3OnnUPnRATZH1os0inM404uIRAJAWGus/OZ/QQAAJw7oHRAQs9oYQU/1CFcxmXBOxobSmVWYccp2v0TsoJUBgsoOYugyY/yQG2LPd6MXd3ZbrLgvuD8q6GKFa+VjRWhsf+MwDbx16oozMTPUmXBFWx8bUrTm4rzxUu48WXBKObOND67L+dt4mpqHEc21tiPXHaAzzMuMlKkXKPu2cP9PVuawS5fAPU97vP6kkN/b919hxZ09Dov1MPwAnAZ00B61wLLMLGyhCIW0aBAYse/OXrPxfTUJRQxgr+/EE4OcJeEAymey9ZqQs8hFKXtM9hpndOb4PgXo//ow3fqxB62Mx2sV81iBpYPtGio7/4Ynul4ffiGq2586OEmbisF9FMqn0eJxImlkP5zVzJ9l7nstb5SUBb/m5fyu3/YBkVEG/Za4VtNhyES5MDC7iE9eLNdSqUfF6wTU8obUR+fK3/rJ9IfWbIaP7c2/ 9MGzKXYh 6PWiVYT7H7rUuRMlQ04A7b56ItEvlFDopgZTUP8BQbNzucAW0ZNIEe4c+CIqXeh/bhF/IE/WJOyo7Oj3cUqMEarrLe3FD/yfNa830FEtVZAlIrHuPlIDjX2qtvY7lFfrHaFj+5UzNgHCgqkifA1URKVSCwfb2VvpB5MxhmAE9hDfOfixqDt4lZphCkDRyM22T3h62RC5fXhG084HQpJopGQqdVwQX08A8Icf1O2GCxA3DcYurux1kOmJDar/QfcUg382u0sULYbDGtE1vIgy/lXDC2DE+GR1LVvIfjf1F9T0Kh5b6EFNXshsna6zE3LFGh+s2Q0pCIQpTfODYW33tmVDeC/iCnuLRGjyON50zyGmNYOR5xjfEUyU45Xc1GedcUWNzLFXouN/uQ0PHex9ZQYUspUsKmpl8nPYTVYFi0xdkJdxEd0Zm9VvQ0VBhp8EEYIyKQlxnIufH2Rqt/SQRiTtOAsnYNuUmt4kAYgBFCDObtA7Huk6bp95KDQL6wI8sNiDobJQDwXyun2qJW+1fTIKrgS/Em+u+kDpeGG3e9Ryc3Gk= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 8/9/24 01:56, Muhammad Usama Anjum wrote: > [1] mentions that memfd_secret is only supported on arm64, riscv, x86 > and x86_64 for now. It doesn't support other architectures. I found the > build error on arm and decided to send the fix as it was creating noise > on KernelCI. Hence I'm adding condition that memfd_secret should only be > compiled on supported architectures. Good find. Please include the build error in the commit log. > > Also check in run_vmtests script if memfd_secret binary is present > before executing it. > > [1] https://lore.kernel.org/all/20210518072034.31572-7-rppt@kernel.org/ > Cc: stable@vger.kernel.org > Fixes: 76fe17ef588a ("secretmem: test: add basic selftest for memfd_secret(2)") > Signed-off-by: Muhammad Usama Anjum > --- > tools/testing/selftests/mm/Makefile | 2 ++ > tools/testing/selftests/mm/run_vmtests.sh | 3 +++ > 2 files changed, 5 insertions(+) > > diff --git a/tools/testing/selftests/mm/Makefile b/tools/testing/selftests/mm/Makefile > index 1a83b70e84535..4ea188be0588a 100644 > --- a/tools/testing/selftests/mm/Makefile > +++ b/tools/testing/selftests/mm/Makefile > @@ -53,7 +53,9 @@ TEST_GEN_FILES += madv_populate > TEST_GEN_FILES += map_fixed_noreplace > TEST_GEN_FILES += map_hugetlb > TEST_GEN_FILES += map_populate > +ifneq (,$(filter $(ARCH),arm64 riscv riscv64 x86 x86_64)) > TEST_GEN_FILES += memfd_secret > +endif > TEST_GEN_FILES += migration > TEST_GEN_FILES += mkdirty > TEST_GEN_FILES += mlock-random-test > diff --git a/tools/testing/selftests/mm/run_vmtests.sh b/tools/testing/selftests/mm/run_vmtests.sh > index 03ac4f2e1cce6..36045edb10dea 100755 > --- a/tools/testing/selftests/mm/run_vmtests.sh > +++ b/tools/testing/selftests/mm/run_vmtests.sh > @@ -374,8 +374,11 @@ CATEGORY="hmm" run_test bash ./test_hmm.sh smoke > # MADV_POPULATE_READ and MADV_POPULATE_WRITE tests > CATEGORY="madv_populate" run_test ./madv_populate > > +if [ -x ./memfd_secret ] > +then > (echo 0 | sudo tee /proc/sys/kernel/yama/ptrace_scope 2>&1) | tap_prefix > CATEGORY="memfd_secret" run_test ./memfd_secret > +fi > > # KSM KSM_MERGE_TIME_HUGE_PAGES test with size of 100 > CATEGORY="ksm" run_test ./ksm_tests -H -s 100 Reviewed-by: Shuah Khan thanks, -- Shuah