From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 209EDC48BD1 for ; Wed, 9 Jun 2021 11:18:27 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id C3D6261364 for ; Wed, 9 Jun 2021 11:18:26 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C3D6261364 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id D80BA6B006E; Wed, 9 Jun 2021 07:18:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D09A86B0070; Wed, 9 Jun 2021 07:18:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B83C76B0071; Wed, 9 Jun 2021 07:18:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0026.hostedemail.com [216.40.44.26]) by kanga.kvack.org (Postfix) with ESMTP id 83AA16B006E for ; Wed, 9 Jun 2021 07:18:25 -0400 (EDT) Received: from smtpin13.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 20A9E180AD817 for ; Wed, 9 Jun 2021 11:18:25 +0000 (UTC) X-FDA: 78233936970.13.86FD218 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf23.hostedemail.com (Postfix) with ESMTP id 4C596A000241 for ; Wed, 9 Jun 2021 11:18:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1623237504; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5D2f0RDMNoW7UtQkRweMkgymnt4in4bolBggOQUTyEQ=; b=XdibKVCSNqe6NSsjL0b00/F5RBoIXPArHPPU/FKcb1AX2te9P+AW/Fetf8vhTdDdktO6hh bRI9Ca2C/I/55pEBP7JI1GVBakXltFVhBiiqPFH5uwBmyTeQvVsZ/nFx05s6bj+vECQjna EmyJmtNp4Gn/bqvWnDRThf7Ko3cERb8= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-544-PYzf9RC8NdmslYRmMMcKgA-1; Wed, 09 Jun 2021 07:18:23 -0400 X-MC-Unique: PYzf9RC8NdmslYRmMMcKgA-1 Received: by mail-wm1-f70.google.com with SMTP id a19-20020a1c98130000b02901960b3b5621so727232wme.8 for ; Wed, 09 Jun 2021 04:18:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=5D2f0RDMNoW7UtQkRweMkgymnt4in4bolBggOQUTyEQ=; b=NW5+KHz/UmxrWqJSpV8nAimRyaJvgCU14Z6c1joD2lMSDReDEQlkB8r64WueJflz4Y nE3xvhfpQB6GFfb80uNM1WnyeEUwJcLrVAMpidgSLETdl0L3XgWrFIRNBjJUybRtESfp 4i9rGr0DEhmU5279GjntTpGbdmyYVoajqIw7Wty5va+ING/hIWzquwhKcIQoGXUk9vIm uVpdIvT8LRAOYnJDX4AvunF6T98Phk30DbUWbZIpXnfUy9ZxBuUJPebJSX+fOnoAn8FH ZvoM4Ip/uxe+DHTOnRz6Rd25be98el16y7FfAQjftP2pzXxQ+gB7T1nYaRZpgZHrvDWA vMHw== X-Gm-Message-State: AOAM53091/EzmtpbnPq7LuOqb1Ity9/AYBlRPuyQbUwM7jZjx5BDup72 4sJHCEU3x9r5xoNcG+AYk5PuEVKEfIIzZR+UYqjvYw6MlDpBOIun450fUZ+xdg5MjwxYQt+09kK 4JWdNtb+Bc6Q= X-Received: by 2002:adf:e389:: with SMTP id e9mr27427045wrm.424.1623237501923; Wed, 09 Jun 2021 04:18:21 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwxOLZzQ5/x7hlD+8shRSv+b5ugVVvpIrozrvEwykG0k3f1jFUc3fyD9nSe/yijhIjCFM9mNQ== X-Received: by 2002:adf:e389:: with SMTP id e9mr27427036wrm.424.1623237501773; Wed, 09 Jun 2021 04:18:21 -0700 (PDT) Received: from [192.168.3.132] (p5b0c611d.dip0.t-ipconnect.de. [91.12.97.29]) by smtp.gmail.com with ESMTPSA id q3sm23778565wrz.71.2021.06.09.04.18.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 09 Jun 2021 04:18:21 -0700 (PDT) Subject: Re: [PATCH] mm/nommu: unexport do_munmap() To: Liam Howlett , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , Andrew Morton References: <20210604194002.648037-1-Liam.Howlett@Oracle.com> From: David Hildenbrand Organization: Red Hat Message-ID: Date: Wed, 9 Jun 2021 13:18:21 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <20210604194002.648037-1-Liam.Howlett@Oracle.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=XdibKVCS; dmarc=pass (policy=none) header.from=redhat.com; spf=none (imf23.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 170.10.133.124) smtp.mailfrom=david@redhat.com X-Rspamd-Server: rspam02 X-Stat-Signature: 8z1ocad6d9co1w35feowimrjnwtqri6w X-Rspamd-Queue-Id: 4C596A000241 X-HE-Tag: 1623237501-190383 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 04.06.21 21:40, Liam Howlett wrote: > do_munmap() does not take the mmap_write_lock(). vm_munmap() should be > used instead. > > Signed-off-by: Liam R. Howlett > --- > mm/nommu.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/mm/nommu.c b/mm/nommu.c > index 0997ca38c2bd..3a93d4054810 100644 > --- a/mm/nommu.c > +++ b/mm/nommu.c > @@ -1501,7 +1501,6 @@ int do_munmap(struct mm_struct *mm, unsigned long start, size_t len, struct list > delete_vma(mm, vma); > return 0; > } > -EXPORT_SYMBOL(do_munmap); > > int vm_munmap(unsigned long addr, size_t len) > { > Reviewed-by: David Hildenbrand -- Thanks, David / dhildenb