From: David Hildenbrand <david@redhat.com>
To: Liam Howlett <liam.howlett@oracle.com>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] mm/nommu: unexport do_munmap()
Date: Wed, 9 Jun 2021 13:18:21 +0200 [thread overview]
Message-ID: <cb975b7f-b8f0-dc33-7a5c-c488157ecf6e@redhat.com> (raw)
In-Reply-To: <20210604194002.648037-1-Liam.Howlett@Oracle.com>
On 04.06.21 21:40, Liam Howlett wrote:
> do_munmap() does not take the mmap_write_lock(). vm_munmap() should be
> used instead.
>
> Signed-off-by: Liam R. Howlett <Liam.Howlett@Oracle.com>
> ---
> mm/nommu.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/mm/nommu.c b/mm/nommu.c
> index 0997ca38c2bd..3a93d4054810 100644
> --- a/mm/nommu.c
> +++ b/mm/nommu.c
> @@ -1501,7 +1501,6 @@ int do_munmap(struct mm_struct *mm, unsigned long start, size_t len, struct list
> delete_vma(mm, vma);
> return 0;
> }
> -EXPORT_SYMBOL(do_munmap);
>
> int vm_munmap(unsigned long addr, size_t len)
> {
>
Reviewed-by: David Hildenbrand <david@redhat.com>
--
Thanks,
David / dhildenb
prev parent reply other threads:[~2021-06-09 11:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-04 19:40 Liam Howlett
2021-06-05 14:36 ` Matthew Wilcox
2021-06-09 11:18 ` David Hildenbrand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cb975b7f-b8f0-dc33-7a5c-c488157ecf6e@redhat.com \
--to=david@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=liam.howlett@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox