From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6C38AC433B4 for ; Fri, 30 Apr 2021 01:39:37 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id D3534611F1 for ; Fri, 30 Apr 2021 01:39:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D3534611F1 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 4610F6B006C; Thu, 29 Apr 2021 21:39:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 436936B006E; Thu, 29 Apr 2021 21:39:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2FF296B0070; Thu, 29 Apr 2021 21:39:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0175.hostedemail.com [216.40.44.175]) by kanga.kvack.org (Postfix) with ESMTP id 168D96B006C for ; Thu, 29 Apr 2021 21:39:36 -0400 (EDT) Received: from smtpin01.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id B5C08181AF5C2 for ; Fri, 30 Apr 2021 01:39:35 +0000 (UTC) X-FDA: 78087326310.01.C5C3649 Received: from szxga05-in.huawei.com (szxga05-in.huawei.com [45.249.212.191]) by imf12.hostedemail.com (Postfix) with ESMTP id 3B9BCEF for ; Fri, 30 Apr 2021 01:39:23 +0000 (UTC) Received: from DGGEMS414-HUB.china.huawei.com (unknown [172.30.72.58]) by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4FWZhh5KJfzPvMk; Fri, 30 Apr 2021 09:36:20 +0800 (CST) Received: from [10.174.176.174] (10.174.176.174) by DGGEMS414-HUB.china.huawei.com (10.3.19.214) with Microsoft SMTP Server id 14.3.498.0; Fri, 30 Apr 2021 09:39:29 +0800 Subject: Re: [PATCH v2 1/5] mm/huge_memory.c: remove dedicated macro HPAGE_CACHE_INDEX_MASK To: David Hildenbrand , CC: , , , , , , , , , , , , References: <20210429132648.305447-1-linmiaohe@huawei.com> <20210429132648.305447-2-linmiaohe@huawei.com> From: Miaohe Lin Message-ID: Date: Fri, 30 Apr 2021 09:39:29 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Language: en-US X-Originating-IP: [10.174.176.174] X-CFilter-Loop: Reflected Authentication-Results: imf12.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=huawei.com; spf=pass (imf12.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.191 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com X-Rspamd-Server: rspam03 X-Stat-Signature: bwuo3fopirfsewnrfd83i9zfxixyxbqq X-Rspamd-Queue-Id: 3B9BCEF Received-SPF: none (huawei.com>: No applicable sender policy available) receiver=imf12; identity=mailfrom; envelope-from=""; helo=szxga05-in.huawei.com; client-ip=45.249.212.191 X-HE-DKIM-Result: none/none X-HE-Tag: 1619746763-536809 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2021/4/29 22:48, David Hildenbrand wrote: > On 29.04.21 15:26, Miaohe Lin wrote: >> Rewrite the pgoff checking logic to remove macro HPAGE_CACHE_INDEX_MAS= K >> which is only used here to simplify the code. >> >> Reviewed-by: Yang Shi >> Reviewed-by: Anshuman Khandual >> Signed-off-by: Miaohe Lin >> --- >> =C2=A0 include/linux/huge_mm.h | 6 ++---- >> =C2=A0 1 file changed, 2 insertions(+), 4 deletions(-) >> >> diff --git a/include/linux/huge_mm.h b/include/linux/huge_mm.h >> index 9626fda5efce..0a526f211fec 100644 >> --- a/include/linux/huge_mm.h >> +++ b/include/linux/huge_mm.h >> @@ -152,15 +152,13 @@ static inline bool __transparent_hugepage_enable= d(struct vm_area_struct *vma) >> =C2=A0 =C2=A0 bool transparent_hugepage_enabled(struct vm_area_struct = *vma); >> =C2=A0 -#define HPAGE_CACHE_INDEX_MASK (HPAGE_PMD_NR - 1) >> - >> =C2=A0 static inline bool transhuge_vma_suitable(struct vm_area_struct= *vma, >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 unsigned long h= addr) >> =C2=A0 { >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 /* Don't have to check pgoff for anonym= ous vma */ >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 if (!vma_is_anonymous(vma)) { >> -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 if (((vma->vm_start >> PAG= E_SHIFT) & HPAGE_CACHE_INDEX_MASK) !=3D >> -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (v= ma->vm_pgoff & HPAGE_CACHE_INDEX_MASK)) >> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 if (!IS_ALIGNED((vma->vm_s= tart >> PAGE_SHIFT) - vma->vm_pgoff, >> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0 HPAGE_PMD_NR)) >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0 return false; >=20 > I'd have used >=20 > if (!IS_ALIGNED(PHYS_PFN(vma->vm_start) - vma->vm_pgoff, >=20 It's because I want keep the code style consistent with hugepage_vma_chec= k(). There is similiar code in hugepage_vma_check(): return IS_ALIGNED((vma->vm_start >> PAGE_SHIFT) - vma->vm_pgoff, HPAGE_PMD_NR); > Reviewed-by: David Hildenbrand Many thanks for review! >=20