From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C3C15C282EC for ; Mon, 17 Mar 2025 19:25:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 95614280002; Mon, 17 Mar 2025 15:25:17 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 90792280001; Mon, 17 Mar 2025 15:25:17 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7CD5D280002; Mon, 17 Mar 2025 15:25:17 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 5E7AA280001 for ; Mon, 17 Mar 2025 15:25:17 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 4C2C755D44 for ; Mon, 17 Mar 2025 19:25:17 +0000 (UTC) X-FDA: 83232021474.16.DCC07B2 Received: from shelob.surriel.com (shelob.surriel.com [96.67.55.147]) by imf09.hostedemail.com (Postfix) with ESMTP id 6F31E14001F for ; Mon, 17 Mar 2025 19:25:15 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf09.hostedemail.com: domain of riel@shelob.surriel.com designates 96.67.55.147 as permitted sender) smtp.mailfrom=riel@shelob.surriel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1742239515; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=JOUycSmepedZyreMKBcy/aJBF9qR36IXmmYVz6OHokc=; b=QGwiR7SBZ6nb8CIBmhxFLHV6OrX0ketT8O//sKkB+Y4XtBf6+KAPXG+zeYkwSLu7/wNhbC clZIUBAL6aKYbNYEErPriejHjFAtEqCM6A/q1hQhw4tqS2Ha3AaFZn6V4sZ00liPF//MJ9 jznwHWJxkQuXPVJHuBohKNDXlMwQHXw= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1742239515; a=rsa-sha256; cv=none; b=N1harR63I+qAA8rAjgwVcGQqeRMna8exgCcikywk9XC8+lQpOabpvtL8MkJtkES3NcB0pv UA3LrjE3rKlJBfyFQ7wI4FuJx2vf1c1GosAUcROuKbun4UjcLw2Y7zlMxGv8SheeUf+o0g rKC5S4gi2prAuJ4fc0DuZmDPh1eCE38= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf09.hostedemail.com: domain of riel@shelob.surriel.com designates 96.67.55.147 as permitted sender) smtp.mailfrom=riel@shelob.surriel.com Received: from fangorn.home.surriel.com ([10.0.13.7]) by shelob.surriel.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.97.1) (envelope-from ) id 1tuG0T-000000001DY-1CqJ; Mon, 17 Mar 2025 15:20:13 -0400 Message-ID: Subject: Re: [PATCH] mm: Optimize TLB flushes during page reclaim From: Rik van Riel To: Vinay Banakar Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, akpm@linux-foundation.org, willy@infradead.org, mgorman@suse.de, Wei Xu , Greg Thelen Date: Mon, 17 Mar 2025 15:20:13 -0400 In-Reply-To: References: <135b6d6fad6083bfd11a9dc98fad69756b51c59d.camel@surriel.com> Autocrypt: addr=riel@surriel.com; prefer-encrypt=mutual; keydata=mQENBFIt3aUBCADCK0LicyCYyMa0E1lodCDUBf6G+6C5UXKG1jEYwQu49cc/gUBTTk33A eo2hjn4JinVaPF3zfZprnKMEGGv4dHvEOCPWiNhlz5RtqH3SKJllq2dpeMS9RqbMvDA36rlJIIo47 Z/nl6IA8MDhSqyqdnTY8z7LnQHqq16jAqwo7Ll9qALXz4yG1ZdSCmo80VPetBZZPw7WMjo+1hByv/ lvdFnLfiQ52tayuuC1r9x2qZ/SYWd2M4p/f5CLmvG9UcnkbYFsKWz8bwOBWKg1PQcaYHLx06sHGdY dIDaeVvkIfMFwAprSo5EFU+aes2VB2ZjugOTbkkW2aPSWTRsBhPHhV6dABEBAAG0HlJpayB2YW4gU mllbCA8cmllbEByZWRoYXQuY29tPokBHwQwAQIACQUCW5LcVgIdIAAKCRDOed6ShMTeg05SB/986o gEgdq4byrtaBQKFg5LWfd8e+h+QzLOg/T8mSS3dJzFXe5JBOfvYg7Bj47xXi9I5sM+I9Lu9+1XVb/ r2rGJrU1DwA09TnmyFtK76bgMF0sBEh1ECILYNQTEIemzNFwOWLZZlEhZFRJsZyX+mtEp/WQIygHV WjwuP69VJw+fPQvLOGn4j8W9QXuvhha7u1QJ7mYx4dLGHrZlHdwDsqpvWsW+3rsIqs1BBe5/Itz9o 6y9gLNtQzwmSDioV8KhF85VmYInslhv5tUtMEppfdTLyX4SUKh8ftNIVmH9mXyRCZclSoa6IMd635 Jq1Pj2/Lp64tOzSvN5Y9zaiCc5FucXtB9SaWsgdmFuIFJpZWwgPHJpZWxAc3VycmllbC5jb20+iQE +BBMBAgAoBQJSLd2lAhsjBQkSzAMABgsJCAcDAgYVCAIJCgsEFgIDAQIeAQIXgAAKCRDOed6ShMTe g4PpB/0ZivKYFt0LaB22ssWUrBoeNWCP1NY/lkq2QbPhR3agLB7ZXI97PF2z/5QD9Fuy/FD/jddPx KRTvFCtHcEzTOcFjBmf52uqgt3U40H9GM++0IM0yHusd9EzlaWsbp09vsAV2DwdqS69x9RPbvE/Ne fO5subhocH76okcF/aQiQ+oj2j6LJZGBJBVigOHg+4zyzdDgKM+jp0bvDI51KQ4XfxV593OhvkS3z 3FPx0CE7l62WhWrieHyBblqvkTYgJ6dq4bsYpqxxGJOkQ47WpEUx6onH+rImWmPJbSYGhwBzTo0Mm G1Nb1qGPG+mTrSmJjDRxrwf1zjmYqQreWVSFEt26tBpSaWsgdmFuIFJpZWwgPHJpZWxAZmIuY29tP okBPgQTAQIAKAUCW5LbiAIbIwUJEswDAAYLCQgHAwIGFQgCCQoLBBYCAwECHgECF4AACgkQznneko TE3oOUEQgAsrGxjTC1bGtZyuvyQPcXclap11Ogib6rQywGYu6/Mnkbd6hbyY3wpdyQii/cas2S44N cQj8HkGv91JLVE24/Wt0gITPCH3rLVJJDGQxprHTVDs1t1RAbsbp0XTksZPCNWDGYIBo2aHDwErhI omYQ0Xluo1WBtH/UmHgirHvclsou1Ks9jyTxiPyUKRfae7GNOFiX99+ZlB27P3t8CjtSO831Ij0Ip QrfooZ21YVlUKw0Wy6Ll8EyefyrEYSh8KTm8dQj4O7xxvdg865TLeLpho5PwDRF+/mR3qi8CdGbkE c4pYZQO8UDXUN4S+pe0aTeTqlYw8rRHWF9TnvtpcNzZw== Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.54.3 (3.54.3-1.fc41) MIME-Version: 1.0 X-Rspam-User: X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 6F31E14001F X-Stat-Signature: wjf4xd9mzu6ddcth3xxi66w8srkwpgd7 X-HE-Tag: 1742239515-668731 X-HE-Meta: U2FsdGVkX1/RboKFShvB8LxE0jj4f2baZRBBwN9WbdgnQJ3wasg7ORwNy3vk/ZGWY1uLF1LS9SvvBTXI4Ej+yA4+FrLv3LJrVKrKoG1SjuT+CDvBW/OcCodmrQ3lfPYvvu2qc9/0itAtXMU853BSRM0J5ezlkvFZc68LMx3VPf1RVra/iG+ym3FFjwHeZavvDIQJjlYkjDLILUL9MxpQoPRk8TxAN2fKRMqP4wZ8uGvAOpala7mRL1kEWpMlfBQ++l6z+coFdBKL0TXJfUTZ4S7Ql9r9oIS7BMXK8zhCf1w37QQlKepRO0qG5MCLqi/pAmuGieDZWiFjw+z2oNMEWNL5QrFoJGqH6eJdRf0Dlxx1miChpqjZGW6oUoNsOIiTRhiQjexIErO9b/IWXTXLemGPZ4/AvxxWsVw30mWCJESkB9Pa1fUcUvFfzYCOiGMHvb1spqtkWTooF72Q5kZnEy19VyIEY8SwmkarPe2L4fn2k5Cy4VRSCVnrQL4JYP77V7Zwh+nFUojIdnry8BcU9pAF8McN87/w2QaGxyLe1151RrBu0/LkEk2MI8rsr/9xBWBZYsDxtbBlZXpDeT72+1PwjCN9D6tHDJrwXJ0O0yREYAXWQsOKsRhpOTDF8CNusIXGjok5dEujrfRYGf6jUyt41U2HvHTJlUgRnLsEl4WZ+4QP8mLI8Fhcst3gOW6FaUilp5y1uJCbbB7BIFDrn1NoDyqD8lY3g/7pDuuwpy6uVJ5ud+XxQnOFzCFNJ++SKx1UJOGQ7F4ZvWAzpUizaT4+qxMv3VfGycHgkQ55MyAkt5PlcRIgilamc8V/Ks+9jSY+Y2AzG1/fvMBrRdsFfCWAYWAwf1L3H9RE1khtVEY212fuKSZn9gGn0Wp1tPPsuBlaIMEb55/04pWJu3e3NQWBgUpZDz4shkdZ2FhpMpHbGgLqkCk89MSq/btgFt6FvBtpnPBblq6JYGkMXTO FYby1bbJ nOElD8RVdz9Sksu/IPzLrw3DMEcKyHIvcDI4QCrWZgJWLF0bFdMEgaIeYiETifW0jXe/5a/2uPESMf62E64usORQriFPMbEGX45aIQWLmd6hAFy6dJOY69NaOs+7IozCOgpyEcDpyyPeD7AtjHwqHKTrIBJeh6WnaRIrBf7Hpb8jkvUze+uCnKFbpMv9rS6D7or+IUTc9jk0+pBwQhTZd5TiEe7pqd/PGnQE0JsXb0qtzrGtOzJ5lDCabtHP+FOTBSwHjb1ZnmhSOYGbb/jHCTTWL8b2OOG61EHsmjmz1aE3419TMu8SMEXBUoY8q47Mi0Uw+ACP49KjbpoW60aDwhdWPGE+OsVQ9m+Ee X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, 2025-01-23 at 13:16 -0600, Vinay Banakar wrote: >=20 > We have two options: > 1. Keep the current logic where TLB flush batching varies by caller > 2. Enforce consistent 512-page batching in shrink_folio_list() and > also convert to folio_batch as suggested by Matthew >=20 Given that your code is correct, and only the comment was a little misleading, would you be open to resending your patch without the comments about "PMD level" batching? It would be really nice to get this optimization into the kernel. If you don't have the time currently, I would also be happy to clean up the patch and get it to Andrew. Just let me know. kind regards, Rik --=20 All Rights Reversed.