From: Rik van Riel <riel@surriel.com>
To: Vinay Banakar <vny@google.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
akpm@linux-foundation.org, willy@infradead.org, mgorman@suse.de,
Wei Xu <weixugc@google.com>, Greg Thelen <gthelen@google.com>
Subject: Re: [PATCH] mm: Optimize TLB flushes during page reclaim
Date: Mon, 17 Mar 2025 15:20:13 -0400 [thread overview]
Message-ID: <cb76a32131dd10dee4f6097fd349dd3d5786eee6.camel@surriel.com> (raw)
In-Reply-To: <CALf+9YdLB3U7cjY8xi0PQjqPJ_YKformTZFQ4ZxXo_ZzsEwCog@mail.gmail.com>
On Thu, 2025-01-23 at 13:16 -0600, Vinay Banakar wrote:
>
> We have two options:
> 1. Keep the current logic where TLB flush batching varies by caller
> 2. Enforce consistent 512-page batching in shrink_folio_list() and
> also convert to folio_batch as suggested by Matthew
>
Given that your code is correct, and only the comment
was a little misleading, would you be open to resending
your patch without the comments about "PMD level"
batching?
It would be really nice to get this optimization into
the kernel.
If you don't have the time currently, I would also be
happy to clean up the patch and get it to Andrew.
Just let me know.
kind regards,
Rik
--
All Rights Reversed.
prev parent reply other threads:[~2025-03-17 19:25 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-20 22:47 Vinay Banakar
2025-01-21 0:05 ` Vinay Banakar
2025-01-22 8:59 ` Bharata B Rao
2025-01-22 11:09 ` Vinay Banakar
2025-01-22 11:31 ` Bharata B Rao
2025-01-22 13:28 ` Vinay Banakar
2025-01-22 20:05 ` SeongJae Park
2025-01-23 17:11 ` Vinay Banakar
2025-01-23 17:23 ` SeongJae Park
2025-01-23 18:17 ` Matthew Wilcox
2025-01-21 1:43 ` Byungchul Park
2025-01-21 18:03 ` Vinay Banakar
2025-01-23 4:17 ` Rik van Riel
2025-01-23 19:16 ` Vinay Banakar
2025-01-28 22:01 ` Rik van Riel
2025-03-17 19:20 ` Rik van Riel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cb76a32131dd10dee4f6097fd349dd3d5786eee6.camel@surriel.com \
--to=riel@surriel.com \
--cc=akpm@linux-foundation.org \
--cc=gthelen@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=vny@google.com \
--cc=weixugc@google.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox