From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2363CC7115B for ; Mon, 23 Jun 2025 13:31:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B9D676B00B5; Mon, 23 Jun 2025 09:31:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B755E6B00B6; Mon, 23 Jun 2025 09:31:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AB26D6B00B7; Mon, 23 Jun 2025 09:31:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 990EF6B00B5 for ; Mon, 23 Jun 2025 09:31:53 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 4CC311A0436 for ; Mon, 23 Jun 2025 13:31:53 +0000 (UTC) X-FDA: 83586753306.14.EE2E6AE Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf27.hostedemail.com (Postfix) with ESMTP id 82BCF40010 for ; Mon, 23 Jun 2025 13:31:51 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf27.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750685511; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wKxfUu1Nl8jiAD3SuSRMZYhG0RzKbBHJd64nPcAJjsI=; b=AVC/4u3oEJuK9qTEJhGuZKYbftB6Gg9lXJdiK8F+jC3rafHwK0BELiHBGCGzexPVXQssC8 qAx1VkUeAJmgNuf7nQD3tw0DDcW+ZdnAHqenBX8XyWcxsatY+G4cyICDSfaEtXb39zdnNm O/8r9Vh+Oxs+6Icpo/AeXo0/zW9Isxo= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf27.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750685511; a=rsa-sha256; cv=none; b=bp6/DPHe5trX8SyW1AHJVQU3X+y1mauIcGjZNTfSQ5iY/M0aUqQPMRc/WlMWJG8oOoBjKl IlVKpL1bs7QfvX//RFrsyG2LmE02iq6/VfT7uK7IteH6Jla4BjI9uJvZKrketG3Vo2Nvc7 vRPq1nqtTNaOjt6SdOju5M9zC8dGFqE= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 91D2A113E; Mon, 23 Jun 2025 06:31:32 -0700 (PDT) Received: from [10.1.29.169] (XHFQ2J9959.cambridge.arm.com [10.1.29.169]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id E265D3F58B; Mon, 23 Jun 2025 06:31:49 -0700 (PDT) Message-ID: Date: Mon, 23 Jun 2025 14:31:48 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm/vmalloc: leave lazy MMU mode on PTE mapping error Content-Language: en-GB To: Alexander Gordeev Cc: Dan Carpenter , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20250623075721.2817094-1-agordeev@linux.ibm.com> <107bfdb7-c8f5-45fa-872e-3e6928dc8025@arm.com> From: Ryan Roberts In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam11 X-Rspam-User: X-Rspamd-Queue-Id: 82BCF40010 X-Stat-Signature: kk1q564ts6i6hemwtminuamp55tp7mb5 X-HE-Tag: 1750685511-981202 X-HE-Meta: U2FsdGVkX1/wXTXA+sHRd0KDtWn8pH72zlOvET9SOljc7qhcLYbEKKT4D6dnKpVzyfDusDq7Y6+iiK+fqV0SqyKebN4ltMdPFzzT+uT1ZU/s8zg/vIXGJgPh1zmMf2X6JbIY2vV9H8CX+BHym1ZVysUrsW2xGz7QzcVFWDLYAfQ8yvuua/1HoysRaBvO9kJFYn6kEfY25GBZfkJMupDYI7RnqHSfI4idydcyWrzWgzEjX0NNVjSLUjfwGMw0AwC1VGfiv/yl7xn/WUhtdqsqrnSokpt3F2ZaLS7MqEalJHk53zw4mECYfZjnml/iRd/moimM+OwnSK9jJnnIOPsQ9gxs6KoMlyEsu+ebcJ28T6a0gTv28S2fX65wUWk6hA4ftg/97ZwJuFeWwkdSwwZcJgJuYgv4x+/2jWEvS1OSqjCmx3zAGMm6aM932syru6di2wnjvW6xlz35HZv4mfm0/TnMq7nBJWblez1FH1ZOBZUawo0kjw4FpHrOOR3j8uAoZ2Gk8lKEVmv4aKeyWv9ekNflXYBGJqPyLb8+NHOq5Jgq1t0pREnwxlspKFQFOrZ0TX1J8lBEd/qvRlNVwJaPqb6CZU24Rnb/zMIJgVAP29HOGiohfjXzcEvg6MMYYOJLolCeEGN5wwkJx8InszC/OyykViXoF5E9Axv1xOidchneOvv/wEGPXPihbyPo1TE94myo3Wa0AloN2RwON2NC/QQkyHTuqaw2qeFBau/YwFSNSf2TTWDZ7jjC/l7m3C8bkN7Aj8n54436c6j/RmuarMLdrlP82+onjQ30RpC5YxihxhtFQPD3oPuFPAL6ltdLvGYHsmUib4PfYRgv0oDw48stc1WDRQm7vi9OMtBJWnEppNu3gIdnLoBlmZwnVXq/VFnOtAcvxGFzw8ezZW04DRlM+Wk6NMTywml0sFR61n01J4H/DfV5nXPHlCpvgOZMrirrXIVGWc1uSWBC8Ar 99lBEzTk pV2826kazQrN/YNx7WSP5xNr4AlxZgaLy2j56qDb7Ko4PtIeXnvd4O78qFOEVobEZAZxrKz5F2JBmBkVZylJBft9+35vTG9tKIIEIx3zEXD9Zuor+UUfo7nnxLDvcO3fjqQ1i9QtxMkvn972kbQOhg3yr6gMmUftdZ4/UgxQol6SjQ9Md7Cr/KKOvE7PrHrEeq9SXBWA+6aOYXpIG2gup4rwC7MO9sI4EWbuviFD9+zLmuT/myEPtPfiMhJN16DMWwsfslmm6BtSOxySu/zRWsnTe4oNbj/uFY2GMEn6dfeKXdaiWp9GVveMhzmP04DwTW+2Iy176PqIS76s= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 23/06/2025 14:03, Alexander Gordeev wrote: > On Mon, Jun 23, 2025 at 01:37:11PM +0100, Ryan Roberts wrote: >> On 23/06/2025 08:57, Alexander Gordeev wrote: >>> Function vmap_pages_pte_range() enters the lazy MMU mode, >>> but fails to leave it in case an error is encountered. >>> >>> Reported-by: kernel test robot >>> Reported-by: Dan Carpenter >>> Closes: https://lore.kernel.org/r/202506132017.T1l1l6ME-lkp@intel.com/ >>> Fixes: 44562c71e2cf ("mm/vmalloc: Enter lazy mmu mode while manipulating vmalloc ptes") >>> Signed-off-by: Alexander Gordeev >> >> Ouch, sorry about that! The patch looks good to me so: >> >> Reviewed-by: Ryan Roberts >> >> I wonder an aditional Fixes: should be added for Commit 2ba3e6947aed >> ("mm/vmalloc: track which page-table levels were modified") though? That's the >> one that added the "*mask |= PGTBL_PTE_MODIFIED;" which would have also been >> skipped if an error occured before this patch. > > Good catch! I think it certainly needs to be reported with Fixes > and I even doubt whether your commit should be mentioned at all? Well I would certainly argue that my patch is broken as is. So happy to have 2 Fixes: tags. But I'm not really sure what the rules are here... > >> Thanks, >> Ryan > > Thanks!