From: "David Hildenbrand (Red Hat)" <david@kernel.org>
To: Wale Zhang <wale.zhang.ftd@gmail.com>,
akpm@linux-foundation.org, chrisl@kernel.org, ziy@nvidia.com
Cc: lorenzo.stoakes@oracle.com, baohua@kernel.org,
matthew.brost@intel.com, linux-mm@kvack.org
Subject: Re: [PATCH v2] mm/swapops,rmap: remove should-never-be-compiled codes.
Date: Tue, 30 Dec 2025 20:50:13 +0100 [thread overview]
Message-ID: <cb69a1e7-e836-4115-8733-12d2de879f51@kernel.org> (raw)
In-Reply-To: <20251230130110.1366374-1-wale.zhang.ftd@gmail.com>
> - break;
> +#ifdef CONFIG_NO_PAGE_MAPCOUNT
> + last = atomic_add_negative(-1, &folio->_entire_mapcount);
> + if (level == PGTABLE_LEVEL_PMD && last)
> + nr_pmdmapped = folio_large_nr_pages(folio);
> + nr = folio_dec_return_large_mapcount(folio, vma);
> + if (!nr) {
> + /* Now completely unmapped. */
> + nr = folio_large_nr_pages(folio);
> + } else {
> + partially_mapped = last &&
> + nr < folio_large_nr_pages(folio);
> + nr = 0;
The whole code was written to avoid ifdefs.
Sorry, no.
--
Cheers
David
next prev parent reply other threads:[~2025-12-30 19:50 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-30 13:01 Wale Zhang
2025-12-30 18:10 ` Andrew Morton
2025-12-30 19:50 ` David Hildenbrand (Red Hat) [this message]
2025-12-30 21:28 ` Barry Song
2025-12-30 21:35 ` Andrew Morton
2025-12-30 21:59 ` David Hildenbrand (Red Hat)
2025-12-31 11:58 ` wale zhang
2025-12-31 12:17 ` David Hildenbrand (Red Hat)
2025-12-31 9:30 ` wale zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cb69a1e7-e836-4115-8733-12d2de879f51@kernel.org \
--to=david@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=baohua@kernel.org \
--cc=chrisl@kernel.org \
--cc=linux-mm@kvack.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=matthew.brost@intel.com \
--cc=wale.zhang.ftd@gmail.com \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox