From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DC010C00140 for ; Fri, 5 Aug 2022 08:10:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3495A8E0002; Fri, 5 Aug 2022 04:10:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2F74F8E0001; Fri, 5 Aug 2022 04:10:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 171558E0002; Fri, 5 Aug 2022 04:10:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 088568E0001 for ; Fri, 5 Aug 2022 04:10:35 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id C3D6781838 for ; Fri, 5 Aug 2022 08:10:34 +0000 (UTC) X-FDA: 79764817188.02.4A48899 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf28.hostedemail.com (Postfix) with ESMTP id 8BDF1C0120 for ; Fri, 5 Aug 2022 08:10:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1659687032; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Atr+DhHiSOWmg4pa/shGgRsQSRBKuEt9aU4m/334aTs=; b=Vc3aSXRLpSEVikrQqLgIJRGoOAE3O1DvlO4pbJaKVjKZdFqxPhWS9+3xUYn263d2Z53Wud IDe1q0giD4/M/AQ8tGd+sU+idmVC9YGJfDRjzTfX7cYTzjOFFU6R/qvBKQUot+QLHmtTMI bCjLMWkie9rK3oPeK59ePvM1MPNvq3Y= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-617-LlAG78RzO--vevEZ7aWBMA-1; Fri, 05 Aug 2022 04:10:23 -0400 X-MC-Unique: LlAG78RzO--vevEZ7aWBMA-1 Received: by mail-wr1-f72.google.com with SMTP id d6-20020adfa346000000b002206e4c29caso297817wrb.8 for ; Fri, 05 Aug 2022 01:10:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc; bh=Atr+DhHiSOWmg4pa/shGgRsQSRBKuEt9aU4m/334aTs=; b=Zks4vcVIYqfxIZa0rxav2CzPGkZhdg3QStseM4rPO3maEa0+9p3FWUNYipqxFXQzwe f3VbLpBj+PHdNO3RxKMDltOLzNDPb4lebqpye5K/E/1jEkTo5x5ijBBFZNdLmfaLVv9f bP+/UUgr3ieHgHa3ZveiteJu+LvZlUbXY8agwljcVda/KUpxPkyFnj9DjSLd1doyBMgz UXo0i2FSCGcgnLLCtSmUPYouyZd212Tcs+Cl6hVQCQHe8BDScYz7oxVF4umwn9wZ33LX F+NN20Vu199GrJoy7NcFQaVI5ldpP/NUtwefELih6CVRWP9cCECBh+hqc6TGtuY9JlLp BEbg== X-Gm-Message-State: ACgBeo1X+JwW48esPlHfihmPLjGPnGsNjhRWBq2KIKZaG5Bh7wDstbDH 5dKwaTVi/0PSPjRIQWn7TNikFdoY6M7tFm0MWICsZGTlibMO54KAm7FCBBUyfRTzWj2vxU2NBG+ vKTwwF1Wv3KM= X-Received: by 2002:a05:600c:1d16:b0:3a5:2240:da2e with SMTP id l22-20020a05600c1d1600b003a52240da2emr416856wms.136.1659687021830; Fri, 05 Aug 2022 01:10:21 -0700 (PDT) X-Google-Smtp-Source: AA6agR7KqFFWWJFPfWJSaVVoqqHnK3ueHfpqrvra3oyJst8TIyPiytSvU5+peoIm9xxviMav/0gp2A== X-Received: by 2002:a05:600c:1d16:b0:3a5:2240:da2e with SMTP id l22-20020a05600c1d1600b003a52240da2emr416830wms.136.1659687021608; Fri, 05 Aug 2022 01:10:21 -0700 (PDT) Received: from ?IPV6:2003:cb:c706:fb00:f5c3:24b2:3d03:9d52? (p200300cbc706fb00f5c324b23d039d52.dip0.t-ipconnect.de. [2003:cb:c706:fb00:f5c3:24b2:3d03:9d52]) by smtp.gmail.com with ESMTPSA id i17-20020a05600011d100b0021e9d98bec4sm3218381wrx.88.2022.08.05.01.10.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 05 Aug 2022 01:10:21 -0700 (PDT) Message-ID: Date: Fri, 5 Aug 2022 10:10:20 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v2 1/2] mm/gup.c: Don't pass gup_flags to check_and_migrate_movable_pages() To: Alistair Popple , linux-mm@kvack.org Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org, "Sierra Guiza, Alejandro (Alex)" , Chaitanya Kulkarni , Dan Williams , Felix Kuehling , Jason Gunthorpe , John Hubbard , Logan Gunthorpe , Miaohe Lin , Muchun Song , Ralph Campbell References: <3e20a542e756bbc0f66435c9344ff674f3ff7ac7.1659680600.git-series.apopple@nvidia.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <3e20a542e756bbc0f66435c9344ff674f3ff7ac7.1659680600.git-series.apopple@nvidia.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1659687034; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Atr+DhHiSOWmg4pa/shGgRsQSRBKuEt9aU4m/334aTs=; b=dbp+knTsI1/o8fvWgu5hC9m4RzOhcRC6CUm/UZv1PzO+kXu99XEC3XURT5shOite+W04Oj v2zTpg5GuOURhzoh8hDbCRxVh5s/5vrqnkr1IpyANbkUmLUr0/6pGbPBwvjLw20KhO89RY XwvSSft/QVaalh8uyv6bhbuxa8k4kNg= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Vc3aSXRL; spf=pass (imf28.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1659687034; a=rsa-sha256; cv=none; b=BoaFiTOCz5m1DbF090NaQjgTAa21OcVOp9w96+DbrbhujAxYsy5JJnLMbPT/nXba3PiLN6 kzWhZEnwyNsJJBL941+CkschvGPtQGGTxk/e8QG+is+ZtmHgUdtDBJ4dnl0PXgTiu2Bum+ Z9sCkHaGe/yYyThpdSNN9QSKda/F3Uc= X-Stat-Signature: 7zmq3pe9j7egw3e1bepssukojt8jgua1 X-Rspam-User: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 8BDF1C0120 Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Vc3aSXRL; spf=pass (imf28.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-HE-Tag: 1659687033-744322 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 05.08.22 08:29, Alistair Popple wrote: > gup_flags is passed to check_and_migrate_movable_pages() so that it can > call either put_page() or unpin_user_page() to drop the page reference. > However check_and_migrate_movable_pages() is only called for > FOLL_LONGTERM, which implies FOLL_PIN so there is no need to pass > gup_flags. > > Signed-off-by: Alistair Popple > --- > mm/gup.c | 21 ++++++++------------- > 1 file changed, 8 insertions(+), 13 deletions(-) Reviewed-by: David Hildenbrand -- Thanks, David / dhildenb