答复: [External Mail]+ mm-cma-print-total-and-used-count-in-cma_alloc.patch added to mm-unstable branch

答复: [External Mail]+ mm-cma-print-total-and-used-count-in-cma_alloc.patch added to mm-unstable branch

[高翔]

[-- Attachment #1: Type: text/plain, Size: 3974 bytes --]

So now we're ready to merge into master?


________________________________
发件人: Andrew Morton <akpm@linux-foundation.org>
发送时间: 2024年9月27日 4:25
收件人: mm-commits@vger.kernel.org; 高翔; akpm@linux-foundation.org
主题: [External Mail]+ mm-cma-print-total-and-used-count-in-cma_alloc.patch added to mm-unstable branch

[外部邮件] 此邮件来源于小米公司外部，请谨慎处理。若对邮件安全性存疑，请将邮件转发给misec@xiaomi.com进行反馈

The patch titled
     Subject: mm/cma: print total and used count in cma_alloc()
has been added to the -mm mm-unstable branch.  Its filename is
     mm-cma-print-total-and-used-count-in-cma_alloc.patch

This patch will shortly appear at
     https://git.kernel.org/pub/scm/linux/kernel/git/akpm/25-new.git/tree/patches/mm-cma-print-total-and-used-count-in-cma_alloc.patch

This patch will later appear in the mm-unstable branch at
    git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm

Before you just go and hit "reply", please:
   a) Consider who else should be cc'ed
   b) Prefer to cc a suitable mailing list as well
   c) Ideally: find the original patch on the mailing list and do a
      reply-to-all to that, adding suitable additional cc's

*** Remember to use Documentation/process/submit-checklist.rst when testing your code ***

The -mm tree is included into linux-next via the mm-everything
branch at git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
and is updated there every 2-3 working days

------------------------------------------------------
From: gaoxiang17 <gaoxiang17@xiaomi.com>
Subject: mm/cma: print total and used count in cma_alloc()
Date: Thu, 26 Sep 2024 20:00:49 +0800

To better understand cma area during debugging.

before:
[   24.407814] cma: cma_alloc(cma (____ptrval____), name: reserved, count 1, align 0)
[   24.413397] cma: cma_alloc(cma (____ptrval____), name: reserved, count 1, align 0)
[   24.415886] cma: cma_alloc(cma (____ptrval____), name: reserved, count 1, align 0)

after:
[   24.097989] cma: cma_alloc(cma (____ptrval____), name: reserved, total count 16384, used count: 64, request count 1, align 0)
[   24.104260] cma: cma_alloc(cma (____ptrval____), name: reserved, total count 16384, used count: 65, request count 1, align 0)
[   24.107504] cma: cma_alloc(cma (____ptrval____), name: reserved, total count 16384, used count: 66, request count 1, align 0)

Link: https://lkml.kernel.org/r/20240926120049.321514-1-gxxa03070307@gmail.com
Signed-off-by: gaoxiang17 <gaoxiang17@xiaomi.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

 mm/cma.c |   15 +++++++++++++--
 1 file changed, 13 insertions(+), 2 deletions(-)

--- a/mm/cma.c~mm-cma-print-total-and-used-count-in-cma_alloc
+++ a/mm/cma.c
@@ -403,6 +403,17 @@ static void cma_debug_show_areas(struct
        spin_unlock_irq(&cma->lock);
 }

+static unsigned long cma_get_used(struct cma *cma)
+{
+       unsigned long used;
+
+       spin_lock_irq(&cma->lock);
+       used = bitmap_weight(cma->bitmap, (int)cma_bitmap_maxno(cma));
+       spin_unlock_irq(&cma->lock);
+
+       return used << cma->order_per_bit;
+}
+
 static struct page *__cma_alloc(struct cma *cma, unsigned long count,
                                unsigned int align, gfp_t gfp)
 {
@@ -420,8 +431,8 @@ static struct page *__cma_alloc(struct c
        if (!cma || !cma->count || !cma->bitmap)
                return page;

-       pr_debug("%s(cma %p, name: %s, count %lu, align %d)\n", __func__,
-               (void *)cma, cma->name, count, align);
+       pr_debug("%s(cma %p, name: %s, total count %lu, used count: %lu, request count %lu, align %d)\n", __func__,
+               (void *)cma, cma->name, cma->count, cma_get_used(cma), count, align);

        if (!count)
                return page;
_

Patches currently in -mm which might be from gaoxiang17@xiaomi.com are

mm-cma-print-total-and-used-count-in-cma_alloc.patch


[-- Attachment #2: Type: text/html, Size: 6826 bytes --]

Re: 答复: [External Mail]+ mm-cma-print-total-and-used-count-in-cma_alloc.patch added to mm-unstable branch

[Andrew Morton]

On Thu, 26 Sep 2024 23:19:25 +0000 高翔 <gaoxiang17@xiaomi.com> wrote:

> So now we're ready to merge into master?
> 

Nope.  There's a review question I'd like answered and the patch should
go through our regular integration testing.  This is 6.13 material.

答复: 答复: [External Mail]+ mm-cma-print-total-and-used-count-in-cma_alloc.patch added to mm-unstable branch

[高翔]

[-- Attachment #1: Type: text/plain, Size: 857 bytes --]

If you pass the regular integration testing, it will be classified as 6.13 material, and then finally merge into version 6.13?

________________________________
发件人: Andrew Morton <akpm@linux-foundation.org>
发送时间: 2024年9月27日 8:17:47
收件人: 高翔
抄送: mm-commits@vger.kernel.org; linux-mm@kvack.org; linux-kernel@vger.kernel.org; david@redhat.com
主题: Re: 答复: [External Mail]+ mm-cma-print-total-and-used-count-in-cma_alloc.patch added to mm-unstable branch

[外部邮件] 此邮件来源于小米公司外部，请谨慎处理。若对邮件安全性存疑，请将邮件转发给misec@xiaomi.com进行反馈

On Thu, 26 Sep 2024 23:19:25 +0000 高翔 <gaoxiang17@xiaomi.com> wrote:

> So now we're ready to merge into master?
>

Nope.  There's a review question I'd like answered and the patch should
go through our regular integration testing.  This is 6.13 material.

[-- Attachment #2: Type: text/html, Size: 2366 bytes --]

Re: 答复: 答复: [External Mail]+ mm-cma-print-total-and-used-count-in-cma_alloc.patch added to mm-unstable branch

[David Hildenbrand]

On 27.09.24 02:46, 高翔 wrote:
> If you pass the regular integration testing, it will be classified as 
> 6.13 material, and then finally merge into version 6.13?

That's the usual flow.

-- 
Cheers,

David / dhildenb