From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 18B99C77B7F for ; Sat, 13 May 2023 15:11:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8B4586B007B; Sat, 13 May 2023 11:11:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 863E96B007D; Sat, 13 May 2023 11:11:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 72C076B007E; Sat, 13 May 2023 11:11:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 5F5046B007B for ; Sat, 13 May 2023 11:11:38 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 2B40CA10A0 for ; Sat, 13 May 2023 15:11:38 +0000 (UTC) X-FDA: 80785571076.03.DAB93AE Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf10.hostedemail.com (Postfix) with ESMTP id 53521C0004 for ; Sat, 13 May 2023 15:11:36 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=gjBSYIL7; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf10.hostedemail.com: domain of "SRS0=bcyx=BC=paulmck-ThinkPad-P17-Gen-1.home=paulmck@kernel.org" designates 139.178.84.217 as permitted sender) smtp.mailfrom="SRS0=bcyx=BC=paulmck-ThinkPad-P17-Gen-1.home=paulmck@kernel.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1683990696; h=from:from:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=JmjS21VdJGZT+UGxU/Y0Ss6kFZr8uMrD1+oWLVxWf+A=; b=73paUOblVe45HhGcoXwfcZL099RGLDHSU7KXC5aZQ2EddAQsbvbGbCMUEYLjDPP4sFQwaW 9oGnMoVEbjCfTdnZmyL8k2kbuqm95Ywwp208vlTbyu2ahYMHMkPzBSRZACIT+HTPnuxLr5 8N213nj8GhYb+D8Hc7cclieG8aRm6nM= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=gjBSYIL7; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf10.hostedemail.com: domain of "SRS0=bcyx=BC=paulmck-ThinkPad-P17-Gen-1.home=paulmck@kernel.org" designates 139.178.84.217 as permitted sender) smtp.mailfrom="SRS0=bcyx=BC=paulmck-ThinkPad-P17-Gen-1.home=paulmck@kernel.org" ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1683990696; a=rsa-sha256; cv=none; b=V6eN4KcOhSEaiuKF5lhK1FvNdblZ+gEsoWgDdHN0HvtASnpUdoVQjOiYWtPyL+debxQztQ ObbKfzdRi01E4YngS1VHH0+Hc7tQXEEkLDfee0mE/P8AFAAcydOjz+hOXusJ9VHiOESsMx h43ZOhF08C0FTDGpfK5zhA2Py9Mk5Xg= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 4638760DE9; Sat, 13 May 2023 15:11:35 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AB53EC433D2; Sat, 13 May 2023 15:11:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1683990694; bh=pR4RXgNA+/+KjsSrCT4MQ28a3vJH47KkHXVp9PB3kKk=; h=Date:From:To:Cc:Subject:Reply-To:References:In-Reply-To:From; b=gjBSYIL7Is7/Y6iRml8LqVndMiGe65qw8Ah/jdq9qXSDQ2xKGZUNo/qdkIgMpPP2T wLkwOwwxeWHBV7TInS3pgHe0EzVDLAOw7LSlV4fzYKh1A0Dtmixo7Y8m6ZXv6YmqW5 RQUlu5k/0gLfSM8MghKa45j7+VUr13Ix6tWs1YvGrEkWArdgcZCvIzJHqxGJfpOTK2 hVdlKeyLx1TqiBaCpeC+pOiu4e4YgxkDe8RIAapssEsOjURzG9Ri1ytXxK8Dhoopdi BVy6kx63tuUuwSIRTPhO6oDCTc4VSP6F+ofCEsMoOrsQ8LyfDT0zng+qcAp2mOibqt uNwtthcgVriGA== Received: by paulmck-ThinkPad-P17-Gen-1.home (Postfix, from userid 1000) id 49C78CE001B; Sat, 13 May 2023 08:11:34 -0700 (PDT) Date: Sat, 13 May 2023 08:11:34 -0700 From: "Paul E. McKenney" To: kernel test robot Cc: "Uladzislau Rezki (Sony)" , oe-kbuild-all@lists.linux.dev, Linux Memory Management List , "Joel Fernandes (Google)" , rpearsonhpe@gmail.com Subject: Re: [linux-next:master 1574/2056] drivers/infiniband/sw/rxe/rxe_verbs.c:1359:21: error: macro "kfree_rcu" requires 2 arguments, but only 1 given Message-ID: Reply-To: paulmck@kernel.org References: <202305130903.yugzGgvD-lkp@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202305130903.yugzGgvD-lkp@intel.com> X-Stat-Signature: sm6mxxqwoipi5m8kbomjtpqm19c1np9m X-Rspam-User: X-Rspamd-Queue-Id: 53521C0004 X-Rspamd-Server: rspam07 X-HE-Tag: 1683990696-95765 X-HE-Meta: U2FsdGVkX18YwGeAkSuTCVdyNEcJsDFB/VJxZbIahmZXhWelzB77NwS/oFrGD5armC1w1IRcpVcVYRXj1np8XjGt2GyCUktZ1bGaSfJDwaiQcg5uGIWklZ4OVo2/mlK/8puq6TIbKocU+OdrWTZz/MlmsbuJrJJZoEAc87MYJHxrhP9DnwPYnVb+ycktxvCG5b07iwHRdLgx3wY9X1cuohwW0n2cXJgYiLxFbBiweojZW/TIoHZNkbWXZl7gJofsQ3pVGKDB5hP101XrzdsPgfKGnotA4trZOzqkeNJqz4TgEO35+9oU70/Zl+UL7DFbXyPKolkW9vM42TJww1pwR4QmPZthchPYuhsqXpsl/u0hYk+totqsHMvg857xBlaZBL4aQm1WqzXe2FlcbFFBJfMX3XvCHnRjrjed2jFP3x8bJ1A/n9IHxzNzdhwcO9dZqndY0KFl4Z8ucwoWiDw+98QNS9pkk09NPJgTb/FwNzuMGN73Ax0oEJENxCZDjat2F0cDJxbpen67hVHzoYETciANDAoVGbXW8SfGLCKTUAv4LbeP0XcvLn0F6NL4CrKNMWxB/4QxB2KrnS+VSeV9tpHgddxNk7teMHoBLpfa1+hCPRqDVPJnAcObAPadF5PHFtBGNI1hAF+onX1jqnQDyMUyMc5P93sEeuZs6gO7ttMrEIuRzIxI4BCO3ZGhv2lT7kVZm3rOLZgZO4wssHSjeq+4F23/Yn70TII6GeAC0p1p17bF7m6Z2EgjvM+7+e24fWRVfhWbTyo48IV706zS2zh/fHe7pKZ4L4rYyo8cWOwKlvNiPdM0BCRIL9e2RiFND8deHsXJz/T+C41InbCrN6ZUtUWF0+1+vVgD0PhF7dS43NioBNoNkr488tCEH9SSjn8muSZ8gR/AZMXN+Q7KHmWqp1JAyY5XpE6ss5fNofLffKyHyloJdGmhq3hRBSB9KuFptxOm9nY07OjJS+8 gpabfV7s byjJuy09TLto1wHmlrQNn0TFNT5YUN980CddUytQzAiDnebFt7GCo3iZjOMHYl6BAFqVBVmfD0neNfb+jyE/T9/ajUGCA+5w+ojeAa2DMThWmTR+/Uxw4X+7UxPXgYWK5OpFibCaX3DaIeswPhrQy/xbN1LFTbcpKNd+hvXfV2Enw4mASFK+jtVn/q5tYqU46tM49zpX95d/cLD3wyfs9Vlt3crypihMy3lYowkZlPrFxrncCThjiY7M+p/VK3BOuXwy6y4IO5K0M87DQq5qLNmq9R67pbXBJij3kTBdJTYGGmP4wjtv2U9qNHoE78UKMbNq32VaJx8bXeb0vYlox0KoJCDiorB25v2nG8PJBFQAvI9JKL+xm3dbTo7JpWY7zydY+I1FRDV4inruN+mCxSaa6yKlHRZU7BNvLjBu0StyvZTdjFFzuM6CO/9TfmnLlH3gfueqC3VHZ1U8/NLXUb2+kTBctKstEBgEEk/H23CJgvPoHVmjT4CvVT0K1jiJ96jgqI2XFZBqPmTwbery8hets639LhTflb5jJEDj8ott8mrEWVyOpT984eptkoz7Bszjzb5wvX3TaZSYxBz109kmXreROsU9UzD/5whAQ69nnKLM1J77o7zsB8TDI5QTiPKZ3mdoBREkoeM3Uoa8h2HM3y3VmLgT1yUO3nYtfDI9d1JioEPvSXyiZV0TLuLbEF2dX40rZZIsoRaomQEJ11hXHr/f4CKqqbfXOBGbVE1TaXt5ZenTbY5fDGR2Zp8r2rZDq4p9+fEDpRUnFzFLarxTzzMSHQictvvZQ4m3qOlzgpi32Tpz4i5zUFO2cze9eOxoRqWQA5y6nciCUqN3qp4qBPUYYkTHvl4/YOFpgGficLMamcJzDcHgPgBk0mGJEYdKV32Y7sCuIkHI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, May 13, 2023 at 09:53:01AM +0800, kernel test robot wrote: > tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master > head: e922ba281a8d84f640d8c8e18a385d032c19e185 > commit: 7e3f926bf4538cb4988b3e3f8bc1cb4a603b2ef6 [1574/2056] rcu/kvfree: Eliminate k[v]free_rcu() single argument macro > config: x86_64-rhel-8.3-func (https://download.01.org/0day-ci/archive/20230513/202305130903.yugzGgvD-lkp@intel.com/config) > compiler: gcc-11 (Debian 11.3.0-12) 11.3.0 > reproduce (this is a W=1 build): > # https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=7e3f926bf4538cb4988b3e3f8bc1cb4a603b2ef6 > git remote add linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git > git fetch --no-tags linux-next master > git checkout 7e3f926bf4538cb4988b3e3f8bc1cb4a603b2ef6 > # save the config file > mkdir build_dir && cp config build_dir/.config > make W=1 O=build_dir ARCH=x86_64 olddefconfig > make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash drivers/infiniband/sw/rxe/ > > If you fix the issue, kindly add following tag where applicable > | Reported-by: kernel test robot > | Link: https://lore.kernel.org/oe-kbuild-all/202305130903.yugzGgvD-lkp@intel.com/ The fix for this was recently in -next. Should we push a fix up through -rcu? The default approach is of course to change that kfree_rcu() to kfree_rcu_mightsleep(). Thanx, Paul > Note: the linux-next/master HEAD e922ba281a8d84f640d8c8e18a385d032c19e185 builds fine. > It may have been fixed somewhere. > > All errors (new ones prefixed by >>): > > drivers/infiniband/sw/rxe/rxe_verbs.c: In function 'rxe_dereg_mr': > >> drivers/infiniband/sw/rxe/rxe_verbs.c:1359:21: error: macro "kfree_rcu" requires 2 arguments, but only 1 given > 1359 | kfree_rcu(mr); > | ^ > In file included from include/linux/rculist.h:11, > from include/linux/pid.h:5, > from include/linux/sched.h:14, > from include/linux/ratelimit.h:6, > from include/linux/dev_printk.h:16, > from include/linux/device.h:15, > from include/linux/dma-mapping.h:7, > from drivers/infiniband/sw/rxe/rxe_verbs.c:7: > include/linux/rcupdate.h:986: note: macro "kfree_rcu" defined here > 986 | #define kfree_rcu(ptr, rhf) kvfree_rcu_arg_2(ptr, rhf) > | > >> drivers/infiniband/sw/rxe/rxe_verbs.c:1359:9: error: 'kfree_rcu' undeclared (first use in this function); did you mean 'kfree_skb'? > 1359 | kfree_rcu(mr); > | ^~~~~~~~~ > | kfree_skb > drivers/infiniband/sw/rxe/rxe_verbs.c:1359:9: note: each undeclared identifier is reported only once for each function it appears in > > > vim +/kfree_rcu +1359 drivers/infiniband/sw/rxe/rxe_verbs.c > > 8700e3e7c4857d2 Moni Shoua 2016-06-16 1342 > 5bf944f24129cbc Bob Pearson 2023-03-03 1343 static int rxe_dereg_mr(struct ib_mr *ibmr, struct ib_udata *udata) > 5bf944f24129cbc Bob Pearson 2023-03-03 1344 { > 5bf944f24129cbc Bob Pearson 2023-03-03 1345 struct rxe_mr *mr = to_rmr(ibmr); > 5bf944f24129cbc Bob Pearson 2023-03-03 1346 int err, cleanup_err; > 5bf944f24129cbc Bob Pearson 2023-03-03 1347 > 5bf944f24129cbc Bob Pearson 2023-03-03 1348 /* See IBA 10.6.7.2.6 */ > 5bf944f24129cbc Bob Pearson 2023-03-03 1349 if (atomic_read(&mr->num_mw) > 0) { > 5bf944f24129cbc Bob Pearson 2023-03-03 1350 err = -EINVAL; > 5bf944f24129cbc Bob Pearson 2023-03-03 1351 rxe_dbg_mr(mr, "mr has mw's bound"); > 5bf944f24129cbc Bob Pearson 2023-03-03 1352 goto err_out; > 5bf944f24129cbc Bob Pearson 2023-03-03 1353 } > 5bf944f24129cbc Bob Pearson 2023-03-03 1354 > 5bf944f24129cbc Bob Pearson 2023-03-03 1355 cleanup_err = rxe_cleanup(mr); > 5bf944f24129cbc Bob Pearson 2023-03-03 1356 if (cleanup_err) > 5bf944f24129cbc Bob Pearson 2023-03-03 1357 rxe_err_mr(mr, "cleanup failed, err = %d", cleanup_err); > 5bf944f24129cbc Bob Pearson 2023-03-03 1358 > 5bf944f24129cbc Bob Pearson 2023-03-03 @1359 kfree_rcu(mr); > 5bf944f24129cbc Bob Pearson 2023-03-03 1360 return 0; > 5bf944f24129cbc Bob Pearson 2023-03-03 1361 > 5bf944f24129cbc Bob Pearson 2023-03-03 1362 err_out: > 5bf944f24129cbc Bob Pearson 2023-03-03 1363 rxe_err_mr(mr, "returned err = %d", err); > 5bf944f24129cbc Bob Pearson 2023-03-03 1364 return err; > 5bf944f24129cbc Bob Pearson 2023-03-03 1365 } > 5bf944f24129cbc Bob Pearson 2023-03-03 1366 > > :::::: The code at line 1359 was first introduced by commit > :::::: 5bf944f24129cbc4b5828348bdce2db94ca9fbd6 RDMA/rxe: Add error messages > > :::::: TO: Bob Pearson > :::::: CC: Jason Gunthorpe > > -- > 0-DAY CI Kernel Test Service > https://github.com/intel/lkp-tests