From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CCEF4C4707C for ; Fri, 12 Jan 2024 20:00:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5C1676B0099; Fri, 12 Jan 2024 15:00:10 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 571868D0003; Fri, 12 Jan 2024 15:00:10 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3EB646B009B; Fri, 12 Jan 2024 15:00:10 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 31C586B0099 for ; Fri, 12 Jan 2024 15:00:10 -0500 (EST) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 0196B140EBA for ; Fri, 12 Jan 2024 20:00:09 +0000 (UTC) X-FDA: 81671725380.18.6920B59 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.7]) by imf26.hostedemail.com (Postfix) with ESMTP id 41AC1140016 for ; Fri, 12 Jan 2024 20:00:07 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=YIF9MQof; spf=pass (imf26.hostedemail.com: domain of dave.hansen@intel.com designates 192.198.163.7 as permitted sender) smtp.mailfrom=dave.hansen@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1705089607; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=VI2JHjNkmrOmyGLmEaKXwJUKB/SdgtTvw+PqCqOnteQ=; b=8jIPrI3ZsQfGyfvlDcNnHl0RN1Js5NaFfo2U6A5XEKm3FL//nV2N5YI9ZxXsfg3iUhEQAS VFQ6/O37zP4FNEQpmWeIvMyvFwSPlBnR3oMfG8kJsZhKhFeYXcdBdkJC8pQ8uFCAPv+y67 ovmrNosu6KPWTt7mefe7rGZ6rnOXIsU= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1705089607; a=rsa-sha256; cv=none; b=ZdLiul6msI2E/Lz2BiuXB6EuPDnpyNkrHjJzO91HnhSfV6frX6s3QY78QPHhZ3RWE6FjRz 8Nh9cTY2YpyPb/80IIJuun5PnrC8fHkH80v4OGByUJPnpIbijLrwGzIeqgmTXrQPc07bVi mz7VZfTJB4DcNviTAwwWzROvt8o19NE= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=YIF9MQof; spf=pass (imf26.hostedemail.com: domain of dave.hansen@intel.com designates 192.198.163.7 as permitted sender) smtp.mailfrom=dave.hansen@intel.com; dmarc=pass (policy=none) header.from=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1705089607; x=1736625607; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=qPNC9mudVSFiC3KpRKvCImonwqaWIZEM6Iecg80VkYI=; b=YIF9MQofTcFfYNVBXyzzKKhNRDTnGvmLa4AHOXBftXYWqYP3R1aI1CyG JtAo/kEDhZnGfWFsq24aI7yc9iOSF7VMNu4AWlahzMCA1jP8lW3fBySnc bz8/webd47H4s3bnB+ShJ8ZHMyke0pP2iby8wMG3vGMUkwCcXZG2uCD50 7++abH9t4PAl100+durP6pcYVTKWHrQ0fsCtylfQBJQu0l0f9dugXivUK /0XRuJgmQT8Ex/KZhWb6tN/3zgZPYUSDgqxL1I7SezrBjrg+sDEd+CVQd ToxcWZZ4wNNeXItxGyHTv+pwS10CLElbi+3qINCgG6mYzogbauZTA635I A==; X-IronPort-AV: E=McAfee;i="6600,9927,10951"; a="20750676" X-IronPort-AV: E=Sophos;i="6.04,190,1695711600"; d="scan'208";a="20750676" Received: from fmviesa002.fm.intel.com ([10.60.135.142]) by fmvoesa101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Jan 2024 12:00:05 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.04,190,1695711600"; d="scan'208";a="17500215" Received: from yrayx-mobl.amr.corp.intel.com (HELO [10.209.50.27]) ([10.209.50.27]) by fmviesa002-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Jan 2024 12:00:02 -0800 Message-ID: Date: Fri, 12 Jan 2024 12:00:01 -0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 11/26] x86/sev: Invalidate pages from the direct map when adding them to the RMP table Content-Language: en-US To: Michael Roth , x86@kernel.org Cc: kvm@vger.kernel.org, linux-coco@lists.linux.dev, linux-mm@kvack.org, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, tglx@linutronix.de, mingo@redhat.com, jroedel@suse.de, thomas.lendacky@amd.com, hpa@zytor.com, ardb@kernel.org, pbonzini@redhat.com, seanjc@google.com, vkuznets@redhat.com, jmattson@google.com, luto@kernel.org, dave.hansen@linux.intel.com, slp@redhat.com, pgonda@google.com, peterz@infradead.org, srinivas.pandruvada@linux.intel.com, rientjes@google.com, tobin@ibm.com, bp@alien8.de, vbabka@suse.cz, kirill@shutemov.name, ak@linux.intel.com, tony.luck@intel.com, sathyanarayanan.kuppuswamy@linux.intel.com, alpergun@google.com, jarkko@kernel.org, ashish.kalra@amd.com, nikunj.dadhania@amd.com, pankaj.gupta@amd.com, liam.merwick@oracle.com, zhi.a.wang@intel.com, Brijesh Singh References: <20231230161954.569267-1-michael.roth@amd.com> <20231230161954.569267-12-michael.roth@amd.com> From: Dave Hansen Autocrypt: addr=dave.hansen@intel.com; keydata= xsFNBE6HMP0BEADIMA3XYkQfF3dwHlj58Yjsc4E5y5G67cfbt8dvaUq2fx1lR0K9h1bOI6fC oAiUXvGAOxPDsB/P6UEOISPpLl5IuYsSwAeZGkdQ5g6m1xq7AlDJQZddhr/1DC/nMVa/2BoY 2UnKuZuSBu7lgOE193+7Uks3416N2hTkyKUSNkduyoZ9F5twiBhxPJwPtn/wnch6n5RsoXsb ygOEDxLEsSk/7eyFycjE+btUtAWZtx+HseyaGfqkZK0Z9bT1lsaHecmB203xShwCPT49Blxz VOab8668QpaEOdLGhtvrVYVK7x4skyT3nGWcgDCl5/Vp3TWA4K+IofwvXzX2ON/Mj7aQwf5W iC+3nWC7q0uxKwwsddJ0Nu+dpA/UORQWa1NiAftEoSpk5+nUUi0WE+5DRm0H+TXKBWMGNCFn c6+EKg5zQaa8KqymHcOrSXNPmzJuXvDQ8uj2J8XuzCZfK4uy1+YdIr0yyEMI7mdh4KX50LO1 pmowEqDh7dLShTOif/7UtQYrzYq9cPnjU2ZW4qd5Qz2joSGTG9eCXLz5PRe5SqHxv6ljk8mb ApNuY7bOXO/A7T2j5RwXIlcmssqIjBcxsRRoIbpCwWWGjkYjzYCjgsNFL6rt4OL11OUF37wL QcTl7fbCGv53KfKPdYD5hcbguLKi/aCccJK18ZwNjFhqr4MliQARAQABzUVEYXZpZCBDaHJp c3RvcGhlciBIYW5zZW4gKEludGVsIFdvcmsgQWRkcmVzcykgPGRhdmUuaGFuc2VuQGludGVs LmNvbT7CwXgEEwECACIFAlQ+9J0CGwMGCwkIBwMCBhUIAgkKCwQWAgMBAh4BAheAAAoJEGg1 lTBwyZKwLZUP/0dnbhDc229u2u6WtK1s1cSd9WsflGXGagkR6liJ4um3XCfYWDHvIdkHYC1t MNcVHFBwmQkawxsYvgO8kXT3SaFZe4ISfB4K4CL2qp4JO+nJdlFUbZI7cz/Td9z8nHjMcWYF IQuTsWOLs/LBMTs+ANumibtw6UkiGVD3dfHJAOPNApjVr+M0P/lVmTeP8w0uVcd2syiaU5jB aht9CYATn+ytFGWZnBEEQFnqcibIaOrmoBLu2b3fKJEd8Jp7NHDSIdrvrMjYynmc6sZKUqH2 I1qOevaa8jUg7wlLJAWGfIqnu85kkqrVOkbNbk4TPub7VOqA6qG5GCNEIv6ZY7HLYd/vAkVY E8Plzq/NwLAuOWxvGrOl7OPuwVeR4hBDfcrNb990MFPpjGgACzAZyjdmYoMu8j3/MAEW4P0z F5+EYJAOZ+z212y1pchNNauehORXgjrNKsZwxwKpPY9qb84E3O9KYpwfATsqOoQ6tTgr+1BR CCwP712H+E9U5HJ0iibN/CDZFVPL1bRerHziuwuQuvE0qWg0+0SChFe9oq0KAwEkVs6ZDMB2 P16MieEEQ6StQRlvy2YBv80L1TMl3T90Bo1UUn6ARXEpcbFE0/aORH/jEXcRteb+vuik5UGY 5TsyLYdPur3TXm7XDBdmmyQVJjnJKYK9AQxj95KlXLVO38lczsFNBFRjzmoBEACyAxbvUEhd GDGNg0JhDdezyTdN8C9BFsdxyTLnSH31NRiyp1QtuxvcqGZjb2trDVuCbIzRrgMZLVgo3upr MIOx1CXEgmn23Zhh0EpdVHM8IKx9Z7V0r+rrpRWFE8/wQZngKYVi49PGoZj50ZEifEJ5qn/H Nsp2+Y+bTUjDdgWMATg9DiFMyv8fvoqgNsNyrrZTnSgoLzdxr89FGHZCoSoAK8gfgFHuO54B lI8QOfPDG9WDPJ66HCodjTlBEr/Cwq6GruxS5i2Y33YVqxvFvDa1tUtl+iJ2SWKS9kCai2DR 3BwVONJEYSDQaven/EHMlY1q8Vln3lGPsS11vSUK3QcNJjmrgYxH5KsVsf6PNRj9mp8Z1kIG qjRx08+nnyStWC0gZH6NrYyS9rpqH3j+hA2WcI7De51L4Rv9pFwzp161mvtc6eC/GxaiUGuH BNAVP0PY0fqvIC68p3rLIAW3f97uv4ce2RSQ7LbsPsimOeCo/5vgS6YQsj83E+AipPr09Caj 0hloj+hFoqiticNpmsxdWKoOsV0PftcQvBCCYuhKbZV9s5hjt9qn8CE86A5g5KqDf83Fxqm/ vXKgHNFHE5zgXGZnrmaf6resQzbvJHO0Fb0CcIohzrpPaL3YepcLDoCCgElGMGQjdCcSQ+Ci FCRl0Bvyj1YZUql+ZkptgGjikQARAQABwsFfBBgBAgAJBQJUY85qAhsMAAoJEGg1lTBwyZKw l4IQAIKHs/9po4spZDFyfDjunimEhVHqlUt7ggR1Hsl/tkvTSze8pI1P6dGp2XW6AnH1iayn yRcoyT0ZJ+Zmm4xAH1zqKjWplzqdb/dO28qk0bPso8+1oPO8oDhLm1+tY+cOvufXkBTm+whm +AyNTjaCRt6aSMnA/QHVGSJ8grrTJCoACVNhnXg/R0g90g8iV8Q+IBZyDkG0tBThaDdw1B2l asInUTeb9EiVfL/Zjdg5VWiF9LL7iS+9hTeVdR09vThQ/DhVbCNxVk+DtyBHsjOKifrVsYep WpRGBIAu3bK8eXtyvrw1igWTNs2wazJ71+0z2jMzbclKAyRHKU9JdN6Hkkgr2nPb561yjcB8 sIq1pFXKyO+nKy6SZYxOvHxCcjk2fkw6UmPU6/j/nQlj2lfOAgNVKuDLothIxzi8pndB8Jju KktE5HJqUUMXePkAYIxEQ0mMc8Po7tuXdejgPMwgP7x65xtfEqI0RuzbUioFltsp1jUaRwQZ MTsCeQDdjpgHsj+P2ZDeEKCbma4m6Ez/YWs4+zDm1X8uZDkZcfQlD9NldbKDJEXLIjYWo1PH hYepSffIWPyvBMBTW2W5FRjJ4vLRrJSUoEfJuPQ3vW9Y73foyo/qFoURHO48AinGPZ7PC7TF vUaNOTjKedrqHkaOcqB185ahG2had0xnFsDPlx5y In-Reply-To: <20231230161954.569267-12-michael.roth@amd.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 41AC1140016 X-Rspam-User: X-Stat-Signature: t9smhd4cy774gd86z4ebbqji1k4sjib6 X-Rspamd-Server: rspam03 X-HE-Tag: 1705089607-214072 X-HE-Meta: U2FsdGVkX1/AJ2LCxzWy6MUXUPqCicPoj4qGtXiSMhIZNEu/9P9/BVYOfDI/oBIteqA0SwwcfPJF0O25lDaZjPGKdyOhZeEdbCF8+6pjQSTTwKcas28gZlVCd04TH/RCIubRWCJ3L4bqDVGS3y2HP+RqfTgtQZKf5qkPRAh01eI5EEpaawvwW1tmqSO58T+QiS6D0+LRqej2n6XzGu6HCywl2CT7cK6vB5QIPGCv0w4ZyP26IWMOMCqg0cLAKOSXFQnEuaCPUou2kPkXa0qFNk73AHs8axKiRGyiCX/G2WCY75xC0hYwefra+f44+NshcMXjoe3H/VjpO4N4Aon5FPFc+SZRzpSMKbbA5cDL6dpuA/muPw4ky5mML63Ef8m1lAB4nk88KpyHFYR5RgP4ZEzqJjN8C5lC5FHNTMBJYX3rxKEpmjWlCoGc/KVktEIuIGjy0Nyk9lOnFs7TLOuxqIBUjxlyGZFR0fljoAvVgLJOO1GK5XgVxWEEZb/RAlMNp1pB6zNz/zNYo5knSn29w1jXXb1etfVpSjKONoVP31rg5JSwCqQvZl9KyFLG5ZEC6T44ZSC6hQwPleuW1EO5XyuYGwtbV//uOYcTBNFFkNpS2ZXkEbWTQ8jhbAX40YLtxYL0VJu/3Uz+whJMAzCOM7q5LcbNskRfHNm+6ixDyCE3kzaNgZor1akHmZCUC+rU9il3cGhHw3TBVoaqxor2zMndPUB1nmezs1WUKjoFEnyN4K7aWSxAmPPah9K3qe37RMqyZAecKsWHlgoV/weuCSpJrjJL7oKvsQZmJQKjR6Hp8E1erqDI04nhIWfQSrndDAkV2OYDsrObHyS3/5tOGU3Lfe/OSkbPz8fRQp2K0gzG6chws+Mpz8Evu2pqrvOcu6FR0/SHMiHAL5SyJWawUNQYSELUi+xb+zKshJG9OC2LTMJ9eCFyMsidXYzutybM5IWBRNrAAM+zrx9x/K/ Zw57Hw8Y c+I+9x5nWhwafcF0UQjcuQWPCyQAoqtOmkCkKp1lZVUs1n+N5Mw+N40RycmZfWFzOTRGMVSUsKNmqSWQwDvA8dDPk2k3cmuiwWwIZhFKZs4Ft3ebH0o7DCRWZgCKCLAQXLdR1Mxv3ktxyxcs5xhXKACUbQfkI4z3Fm3gQPoCibK0ER7mNFDeBkbgzGA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 12/30/23 08:19, Michael Roth wrote: > If the kernel uses a 2MB directmap mapping to write to an address, and > that 2MB range happens to contain a 4KB page that set to private in the > RMP table, that will also lead to a page-fault exception. I thought we agreed long ago to just demote the whole direct map to 4k on kernels that might need to act as SEV-SNP hosts. That should be step one and this can be discussed as an optimization later.