From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AE7C0C624B4 for ; Thu, 23 Nov 2023 19:43:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2516A6B0713; Thu, 23 Nov 2023 14:43:34 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 201AE6B0712; Thu, 23 Nov 2023 14:43:34 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0A1E06B0713; Thu, 23 Nov 2023 14:43:34 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id EE0256B070F for ; Thu, 23 Nov 2023 14:43:33 -0500 (EST) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id C8654B7011 for ; Thu, 23 Nov 2023 19:43:33 +0000 (UTC) X-FDA: 81490243506.23.829ACA0 Received: from mail-pf1-f182.google.com (mail-pf1-f182.google.com [209.85.210.182]) by imf18.hostedemail.com (Postfix) with ESMTP id BF1C31C001E for ; Thu, 23 Nov 2023 19:43:31 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=kernel-dk.20230601.gappssmtp.com header.s=20230601 header.b=l6G1oRaC; spf=pass (imf18.hostedemail.com: domain of axboe@kernel.dk designates 209.85.210.182 as permitted sender) smtp.mailfrom=axboe@kernel.dk; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1700768612; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=WpkzZHg09ad7VkHOnG/quo/T41ONjJ1411UTG4haLXU=; b=uxZje0PUwObEAEFy1S1DQetUxwDCnVVgl6vK5PJRmcB7ILWK8Q2XK5f2eKZfAq8d8PPLjj IMmnF2IBh3+UHVBvSneS0UVgJvHBZWJnew0J7NlDdtLshNr7qCZ/DslhTucJtfqUDU8kt4 S9PEOk7jyhOcvrkfGIDghjVjgRa/6+A= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1700768612; a=rsa-sha256; cv=none; b=mJi9kXqr5lMhr8nLvWJn6VjO4AY5/X+AqgHYigytFgzV0u3TH6zZEkIMgdm1syIXUX9k2M ZjWgMLTI9sGmR7xX8Qc0g2dxwMq1+Zj5jy2Zp1kP6DkkLkIqR6f3L1gyGsxcsX8zDuqaMR UmWg5n90KoxivZ38lUQwHGuuNUqK/k0= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=kernel-dk.20230601.gappssmtp.com header.s=20230601 header.b=l6G1oRaC; spf=pass (imf18.hostedemail.com: domain of axboe@kernel.dk designates 209.85.210.182 as permitted sender) smtp.mailfrom=axboe@kernel.dk; dmarc=none Received: by mail-pf1-f182.google.com with SMTP id d2e1a72fcca58-6c48fad2f6dso206929b3a.0 for ; Thu, 23 Nov 2023 11:43:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20230601.gappssmtp.com; s=20230601; t=1700768610; x=1701373410; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=WpkzZHg09ad7VkHOnG/quo/T41ONjJ1411UTG4haLXU=; b=l6G1oRaCB2crxSJMtkj5vhxJ7Ti9ynvcdITEg7eUzSuJU66GGtB0eyxYN7vZUKAOCP 5J4dThbPxEjnaYfmNDDvBbvjzCm6+6JKmOJaYbHb0RwBVqGiz/Dzeo+OY5NHPFvdStk+ eQ6qr3YGDGisz5t+SsIaf+SQ+at3oflWLwYy0oM64OCl6/BXNurcR+zGZdghLnLSU0Ez En8XepOCQPVogyT9pzWeR13fTgsVfid5LpStk5V0tWMNhqFufy7naaOVV5nisH4Q3LL/ 1WnJA+W/eu4CvNfKZk/Jm87C6Dzf5pnlhwho7eejjCmw4ylysn9I4I2eNB7kpjZFPFp7 v3BA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700768610; x=1701373410; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=WpkzZHg09ad7VkHOnG/quo/T41ONjJ1411UTG4haLXU=; b=qURFHU7+reh/dxpTT7no4cYMBzSPONmTB0F0zvssV6s9R+gEVKEbx275VcEJAgx9PN c3BHpdLG47bnrY6qaZuYLUz9SzEz5gWnEymuDaKZu5mtQ7owHBdosxRvaD4i0YHUttBM 3YdbtRnl0zeiskMDvG62+PqE4M4kW+nAKvU5zeQht6BuYxNPvWxnyw/491BxRNXV4Bax 4knLii6pV2WT/DJYKQ4x4MFiL7i9l/B9U6ksSVp9TQC2RB2amP5LzB6Skt6dzCRQbj3W ab/bFkucjDJKad/cvvSY0I1DL8CU4aHkgroyXwUhpKCKV22KdUBBP0K04FbBcPuo5DXg Qg0Q== X-Gm-Message-State: AOJu0Yxzz6l0828INEus8xsMKka1ptWGJjYdRdZ6Ed3EqNSCzNSLskpJ vtfUrzeky7v/RI79ozoFsJjWdw== X-Google-Smtp-Source: AGHT+IEPG4J941SLrpY4uC/ri/G2ja2akCNdtY4pHEKeo+HpcNnwpEYC41wSse9D2H40uEI86qohgw== X-Received: by 2002:a05:6a00:9381:b0:6bc:ff89:a2fc with SMTP id ka1-20020a056a00938100b006bcff89a2fcmr544106pfb.2.1700768610318; Thu, 23 Nov 2023 11:43:30 -0800 (PST) Received: from [192.168.1.150] ([198.8.77.194]) by smtp.gmail.com with ESMTPSA id n17-20020a056a0007d100b006cb65cfde6dsm1567524pfu.200.2023.11.23.11.43.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 23 Nov 2023 11:43:29 -0800 (PST) Message-ID: Date: Thu, 23 Nov 2023 12:43:23 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 0/4] eventfd: simplify signal helpers Content-Language: en-US To: Christian Brauner , linux-fsdevel@vger.kernel.org Cc: Christoph Hellwig , Jan Kara , Vitaly Kuznetsov , Sean Christopherson , Paolo Bonzini , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, David Woodhouse , Paul Durrant , Oded Gabbay , Wu Hao , Tom Rix , Moritz Fischer , Xu Yilun , Zhenyu Wang , Zhi Wang , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Daniel Vetter , Leon Romanovsky , Jason Gunthorpe , Frederic Barrat , Andrew Donnellan , Arnd Bergmann , Greg Kroah-Hartman , Eric Farman , Matthew Rosato , Halil Pasic , Vineeth Vijayan , Peter Oberparleiter , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Tony Krowiak , Jason Herne , Harald Freudenberger , "Michael S. Tsirkin" , Jason Wang , Xuan Zhuo , Diana Craciun , Alex Williamson , Eric Auger , Fei Li , Benjamin LaHaise , Johannes Weiner , Michal Hocko , Roman Gushchin , Shakeel Butt , Muchun Song , Kirti Wankhede , kvm@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-fpga@vger.kernel.org, intel-gvt-dev@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, linux-rdma@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, linux-usb@vger.kernel.org, virtualization@lists.linux-foundation.org, netdev@vger.kernel.org, linux-aio@kvack.org, cgroups@vger.kernel.org, linux-mm@kvack.org, Pavel Begunkov , io-uring@vger.kernel.org References: <20231122-vfs-eventfd-signal-v2-0-bd549b14ce0c@kernel.org> From: Jens Axboe In-Reply-To: <20231122-vfs-eventfd-signal-v2-0-bd549b14ce0c@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Stat-Signature: zpmomr6jzoaz7ij94zz3bggcrasksczm X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: BF1C31C001E X-Rspam-User: X-HE-Tag: 1700768611-220516 X-HE-Meta: U2FsdGVkX1/X4DwfrYHfFiu0sUmptT3WxvzUep1O3JLO2/pw0bvBbL1pN6xGpY5OBOHLoXgpWWWcMZ77wvpswotXsdgZ0ziXTsKvy96W3EPHywbgtVhEHfCTa1S4v37H2DPpll9SoHd3o1EpaU6mEdBN2hz9Spn6NGjLxZoRd07AHmk3R9TQlhDGXnPACcaafQ0fg6U8iTkooPY0xO5Qqe05aEhxgCLKlvYy3DQnSAvZXFMBD+lr+2LyJ/DX6IDH+6EELMMG24wtWdO8rlcfQG/5p365RAH1bnNefzwObEBPvVArxZ0G9WA0vB2CP0p5oW/7/vN6TWPV+xEDHS8jYtsB7cBoazLv54e0uWQMjo+p5ulYWeTOl9Edx14hTL5hUKV3HadyqvCrBZcYC9SeGobjEkLsnLU0uNZPlq6eabTNCdxTp+RkdwdgVXXboJbnzKMZZOrSc0o5urImmVS8j22cHUZxtcweyUvVQbTRGJPiGaG/BPd5xjoWp+hj4JdXn1ZrIh707NuJKXdEEuJsoBP15HN7IRBPPdETAlmCqALfmJJd+CbAF15OAkmGkOazJlGOBAJGJIsUEG1Z8n0JS5geWlBhy21/HNjPGZ6rtvWGtzCjKfyv41vQgGvLadrIhHiK0TzFs93zIeloSSmmUA5Wd6lIqzwtBJseiSYFNPf+lUeg5pKHOxEqxj9O2ewne8AefBPAZcgyjsMtFO118GHDTYaF8KufzBGXn339eQ7C3Vwl7/nTkpEH1orOfc3M8YJlJCLMPpKgxBsfntQMoVzSCvIVcBXo+AJQYlCmhju/fdzASYix06flzfvlcnYM7t2fs/TVd/mbWdYLY5SfFC4kjXrNs4rjMosqi742jDZ1Ksv55AGx83LFb9h9EEz8Y9toW74KqqNYSHU7wgY1Ab/uDD4pAmy2Uo6wYC5takHPlWmhy8roObacw7zVojxcjGGD7ul0nCNM6oYfIB9 tPKLy6TS Ekntc9h4kis+6Kfq/CsrvU1eagcdtbtCjnqaLKS6M+uHkroGo5Arm5/9hOsPNGDIAKtADoEstOYgfFy44Rq1L7+LKueZUqKSCuzzW4I40fPFcvDYewHDQbD6fpTM+ywWR+xb1YMeg/TDaWqiRS01Bx+Xb8oTcRIVqBtzrIsFOLLy87DMPK28PeHW2Kdruo6KqCSKFW2xOUPl1qq7qTP/YQBMybt8y0ut6nIgGFnLJKsCVFpyO+5dh6+gli349HOZQHiQN2XUf1UImSag3dge8oFG544F2Bxu955pNgyrhaVDzNsdutkCWfXmkyxHk2XDWT44XxtmeISnfRPAnvJh4WQmDpYJ5rYXJ9xc0sR7UobhRjd2TWetr3Yfl/I9qd6LDt83AkkSHaj4vsKy2rN+R0sPuM5T56hvnK1cqaS/GS9tLXzvYOfFCW0q188iGle7r8B5hEkxQbzZwoS0+LB64pS9WEzt1PEi07BiY8tZ2bkj6CFTqdsReV79VyjDn0W0O4ETZ1sEcGwAcUV4O0rodlLaIgDM1Ckd7keYxMC/TUbfkWNbXkWZlAySjZ6MvSPb5smkEVIGqDTIcrpdwxJm81HIJKM4wxHrZyUu7 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 11/22/23 5:48 AM, Christian Brauner wrote: > Hey everyone, > > This simplifies the eventfd_signal() and eventfd_signal_mask() helpers > significantly. They can be made void and not take any unnecessary > arguments. > > I've added a few more simplifications based on Sean's suggestion. > > Signed-off-by: Christian Brauner > > Changes in v2: > - further simplify helpers > - Link to v1: https://lore.kernel.org/r/20230713-vfs-eventfd-signal-v1-0-7fda6c5d212b@kernel.org Only oddity I spotted was the kerneldoc, which someone else already brought up. Reviewed-by: Jens Axboe -- Jens Axboe