From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D955FC43334 for ; Thu, 23 Jun 2022 12:07:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5D94F8E0149; Thu, 23 Jun 2022 08:07:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5873E8E0144; Thu, 23 Jun 2022 08:07:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 475DC8E0149; Thu, 23 Jun 2022 08:07:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 34F9D8E0144 for ; Thu, 23 Jun 2022 08:07:48 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 0C34020BAC for ; Thu, 23 Jun 2022 12:07:48 +0000 (UTC) X-FDA: 79609376616.01.6B53575 Received: from szxga03-in.huawei.com (szxga03-in.huawei.com [45.249.212.189]) by imf13.hostedemail.com (Postfix) with ESMTP id C13B52001C for ; Thu, 23 Jun 2022 12:07:46 +0000 (UTC) Received: from canpemm500002.china.huawei.com (unknown [172.30.72.55]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4LTJs34MfZzDsLg; Thu, 23 Jun 2022 20:07:03 +0800 (CST) Received: from [10.174.177.76] (10.174.177.76) by canpemm500002.china.huawei.com (7.192.104.244) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Thu, 23 Jun 2022 20:07:37 +0800 Subject: Re: [PATCH 07/16] mm/huge_memory: minor cleanup for split_huge_pages_pid To: "Kirill A. Shutemov" CC: , , , , , References: <20220622170627.19786-1-linmiaohe@huawei.com> <20220622170627.19786-8-linmiaohe@huawei.com> <20220623032211.rvrtlas25u7nddpt@box.shutemov.name> From: Miaohe Lin Message-ID: Date: Thu, 23 Jun 2022 20:07:37 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <20220623032211.rvrtlas25u7nddpt@box.shutemov.name> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.177.76] X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To canpemm500002.china.huawei.com (7.192.104.244) X-CFilter-Loop: Reflected ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1655986067; a=rsa-sha256; cv=none; b=3UkorHYUr0wCzqY6HdCDWrWN3Tk329ipLJc0cTJWvfADm0qJ9oMiZBxu3drUJOfxEnbsSu YxVyITXK7VMJ4A8nSyAIqWHYu55DoiJyMLm8WU72bD2/j0kXCpeHTcQZv4cH6svfDaxn2N 1iklBzFQ6bYfXGpzJ6pUo3fZtzZ7iqs= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf13.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.189 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1655986067; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rpzPhgjj8d+VDoqU8DJySphlpQEtiEwKL464QpH8Wmk=; b=Sg+gla1YgeyE0CuTfQiYos7ujgveZyJdOOiSe9mF+LCXK4y5z5JnGUQRJz/A4uxoMumTOQ RviyVF5ErSX89Qrfzy6HBNqJ/sP4LWghrdoVOp9eu7xpL2TPA80P4AnusTZ3hfRRgwESb3 Ufs+xYdF2T+RWf5OS5D1d54p0Boocbg= X-Rspamd-Queue-Id: C13B52001C X-Rspam-User: Authentication-Results: imf13.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf13.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.189 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com X-Rspamd-Server: rspam03 X-Stat-Signature: nxy3ydnjh1ps9rbu7nu4w3i1fz3njj9u X-HE-Tag: 1655986066-386904 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2022/6/23 11:22, Kirill A. Shutemov wrote: > On Thu, Jun 23, 2022 at 01:06:18AM +0800, Miaohe Lin wrote: >> Use helper function vma_lookup to lookup the needed vma and use help macro >> IS_ERR_OR_NULL to check the validity of page to simplify the code. Minor >> readability improvement. > > Grouping of changing seems random, but okay. I group them because they belong to the same function. Should I split these two changes? Many thanks for reviewing and comment! >