From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 863BDC433FE for ; Wed, 2 Nov 2022 09:16:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DA4858E0002; Wed, 2 Nov 2022 05:16:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D55588E0001; Wed, 2 Nov 2022 05:16:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C1CE18E0002; Wed, 2 Nov 2022 05:16:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id B3BCB8E0001 for ; Wed, 2 Nov 2022 05:16:18 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 840394117C for ; Wed, 2 Nov 2022 09:16:18 +0000 (UTC) X-FDA: 80087946036.15.316CEA0 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf24.hostedemail.com (Postfix) with ESMTP id 0D327180004 for ; Wed, 2 Nov 2022 09:16:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1667380577; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OU3/Jf159y9pxepl1ueY1aykPP8lnzdozH8CN27nur4=; b=A+H7hr3lfzaCOvO9A9NgSreUtcXIROG94B9Krszieik0grfBriB5ciGVZHFXXu7f2I0qM4 t3kekjE9ghPyDiVqsfIb/seJDUGoJ4anOSdNiKNkAD8SlPvi8iVdDH4sjfMjtwA/inFng9 XCVDkKwD2OhO8pWKT/GQ0tXFFGyJNxY= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-642-Z38NO0g8O-KOj0pVJokiVA-1; Wed, 02 Nov 2022 05:16:16 -0400 X-MC-Unique: Z38NO0g8O-KOj0pVJokiVA-1 Received: by mail-wr1-f69.google.com with SMTP id i14-20020adfa50e000000b0023652707418so4627688wrb.20 for ; Wed, 02 Nov 2022 02:16:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=OU3/Jf159y9pxepl1ueY1aykPP8lnzdozH8CN27nur4=; b=NuZU+OQUQyPITikzHjeV93Qd6vkBlR/3TCmJybK01pyQk+DOPtEJ/ETkeXxpguxxJs l4F0DEeWcbE1g9AkLqbFCaBnZIJ6ydfQess3FxTIqEVDvTn3DKABxJgk2Ter9XLYesQp hcHSw9NT6P+z41+4zBTy2ABaiYsWclV4ifx76bOlgHWbSsR3s00FeIi244Ex6gRqG8E7 pMLPyvvyEB9tYK3BQPXwXn0dal+fOPmA9H4BGBn/kZZl2iD6J3wzcyQtawZrg55IOwUo tBjWlDInc8op6UFdaMsbMUL+jhxBf+AWZghR8s8NhREYnZU/8eXFs80aQl+xnbjGKPlp UoiQ== X-Gm-Message-State: ACrzQf2PLEiZUgphNyvBspxoeJGiqpud8ADWAOcSdQWh8UCSSan0nLzy 24fDDBF/PhxeMWm/AhGZdUHWdx9bCh6ByapEFEsxvLT8iVWWqUT0HyvhqkyQvcaVg/I53DiVfFp Hbpq8XKHZ1MQ= X-Received: by 2002:adf:e405:0:b0:236:6e0d:6ed2 with SMTP id g5-20020adfe405000000b002366e0d6ed2mr14662136wrm.338.1667380575177; Wed, 02 Nov 2022 02:16:15 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4sIteimN6epkIB/tZvlJsG7zIWZp7bk9NgF29Slu6DC5fw7jJDbqHpP+2ybLO2IHytCabcrw== X-Received: by 2002:adf:e405:0:b0:236:6e0d:6ed2 with SMTP id g5-20020adfe405000000b002366e0d6ed2mr14662110wrm.338.1667380574833; Wed, 02 Nov 2022 02:16:14 -0700 (PDT) Received: from ?IPV6:2003:cb:c705:f100:af38:1d1f:66f4:48c7? (p200300cbc705f100af381d1f66f448c7.dip0.t-ipconnect.de. [2003:cb:c705:f100:af38:1d1f:66f4:48c7]) by smtp.gmail.com with ESMTPSA id w12-20020a5d404c000000b002365254ea42sm12493299wrp.1.2022.11.02.02.16.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 02 Nov 2022 02:16:14 -0700 (PDT) Message-ID: Date: Wed, 2 Nov 2022 10:16:13 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.0 Subject: Re: [PATCH 2/2] mm: Use pte markers for swap errors To: Peter Xu , linux-kernel@vger.kernel.org, linux-mm@kvack.org Cc: Andrew Morton , Miaohe Lin , Huang Ying , HORIGUCHI NAOYA , Andrea Arcangeli References: <20221030214151.402274-1-peterx@redhat.com> <20221030214151.402274-3-peterx@redhat.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20221030214151.402274-3-peterx@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1667380578; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=OU3/Jf159y9pxepl1ueY1aykPP8lnzdozH8CN27nur4=; b=tJY03fRg6Y1+qWlzS5dMd0lptzvZ+FK6evQwy7j+2g+tkppHptUOH05v1eRpecqOhTKcnD 8Cr6cF2PjmBbsOisSubOAyMwW0Irfc5RQya0f5x/NFOGq0x0X8SxkVuwJNTB9+75suk0RZ H6p9653cYYvMbH1N/lTapmHZVIYDoUY= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=A+H7hr3l; spf=pass (imf24.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1667380578; a=rsa-sha256; cv=none; b=co9PZ0CGRvrwnzFtwAlOCFg00OrUOOEO5keWSYGxdty+UxQJvtvhbqZgdGEOnEqP+fcnuF zjgbpXueQt6+b1eB4MdbDz062NZsPiEhVN24msy3zM+O+Ojb/5h+7nhN2kOpMLQhlYXKT4 rgXyjp0KQ1Jc3KjnlDiL6oCRJKFGjEg= Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=A+H7hr3l; spf=pass (imf24.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-Stat-Signature: 8opxseqqe15wycw4d3sfcgr7azx77fie X-Rspam-User: X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 0D327180004 X-HE-Tag: 1667380577-78069 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 30.10.22 22:41, Peter Xu wrote: > PTE markers are ideal mechanism for things like SWP_SWAPIN_ERROR. Using a > whole swap entry type for this purpose can be an overkill, especially if we > already have PTE markers. Define a new bit for swapin error and replace it > with pte markers. Then we can safely drop SWP_SWAPIN_ERROR and give one > device slot back to swap. > > We used to have SWP_SWAPIN_ERROR taking the page pfn as part of the swap > entry, but it's never used. Neither do I see how it can be useful because > normally the swapin failure should not be caused by a bad page but bad swap > device. Drop it alongside. > > Reviewed-by: Huang Ying > Reviewed-by: Miaohe Lin > Signed-off-by: Peter Xu > --- Acked-by: David Hildenbrand -- Thanks, David / dhildenb