From: David Hildenbrand <david@redhat.com>
To: Peter Xu <peterx@redhat.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Cc: Andrew Morton <akpm@linux-foundation.org>,
Miaohe Lin <linmiaohe@huawei.com>,
Huang Ying <ying.huang@intel.com>,
HORIGUCHI NAOYA <naoya.horiguchi@nec.com>,
Andrea Arcangeli <aarcange@redhat.com>
Subject: Re: [PATCH 2/2] mm: Use pte markers for swap errors
Date: Wed, 2 Nov 2022 10:16:13 +0100 [thread overview]
Message-ID: <cb273d26-df8e-7c68-c81d-4d9a440aa975@redhat.com> (raw)
In-Reply-To: <20221030214151.402274-3-peterx@redhat.com>
On 30.10.22 22:41, Peter Xu wrote:
> PTE markers are ideal mechanism for things like SWP_SWAPIN_ERROR. Using a
> whole swap entry type for this purpose can be an overkill, especially if we
> already have PTE markers. Define a new bit for swapin error and replace it
> with pte markers. Then we can safely drop SWP_SWAPIN_ERROR and give one
> device slot back to swap.
>
> We used to have SWP_SWAPIN_ERROR taking the page pfn as part of the swap
> entry, but it's never used. Neither do I see how it can be useful because
> normally the swapin failure should not be caused by a bad page but bad swap
> device. Drop it alongside.
>
> Reviewed-by: Huang Ying <ying.huang@intel.com>
> Reviewed-by: Miaohe Lin <linmiaohe@huawei.com>
> Signed-off-by: Peter Xu <peterx@redhat.com>
> ---
Acked-by: David Hildenbrand <david@redhat.com>
--
Thanks,
David / dhildenb
next prev parent reply other threads:[~2022-11-02 9:16 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-30 21:41 [PATCH 0/2] mm: Use pte marker for swapin errors Peter Xu
2022-10-30 21:41 ` [PATCH 1/2] mm: Always compile in pte markers Peter Xu
2022-11-02 9:15 ` David Hildenbrand
2022-10-30 21:41 ` [PATCH 2/2] mm: Use pte markers for swap errors Peter Xu
2022-11-02 9:16 ` David Hildenbrand [this message]
2022-10-31 1:40 ` [PATCH 0/2] mm: Use pte marker for swapin errors Huang, Ying
2022-10-31 14:14 ` Peter Xu
2022-11-01 5:05 ` Huang, Ying
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cb273d26-df8e-7c68-c81d-4d9a440aa975@redhat.com \
--to=david@redhat.com \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=linmiaohe@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=naoya.horiguchi@nec.com \
--cc=peterx@redhat.com \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox