From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4A735CF34D5 for ; Thu, 3 Oct 2024 23:04:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C8E5C6B0436; Thu, 3 Oct 2024 19:04:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C3E8F6B0437; Thu, 3 Oct 2024 19:04:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B37066B0438; Thu, 3 Oct 2024 19:04:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 924536B0436 for ; Thu, 3 Oct 2024 19:04:53 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 44F7DAC495 for ; Thu, 3 Oct 2024 23:04:53 +0000 (UTC) X-FDA: 82633822866.20.213200D Received: from mail-il1-f182.google.com (mail-il1-f182.google.com [209.85.166.182]) by imf25.hostedemail.com (Postfix) with ESMTP id 4F93BA0007 for ; Thu, 3 Oct 2024 23:04:51 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=google header.b=BCQoXEwH; dmarc=pass (policy=none) header.from=linuxfoundation.org; spf=pass (imf25.hostedemail.com: domain of skhan@linuxfoundation.org designates 209.85.166.182 as permitted sender) smtp.mailfrom=skhan@linuxfoundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1727996668; a=rsa-sha256; cv=none; b=dVDjq1o/MpGYW6PD9NoLI2NV2Ihv3Ua2dJsiv7Gsr/YnuCVT4xEX0kARtgP1n7t5iiMYL9 83u/1N+Rhd13d6HJuGzjaKQCtwWhUnyJzmcNPFbYgpEVc8LGxFLSWxL1VNLHRgPHqIQUT2 HsVoKX66FzEWoiCW8+kWwWGEZflzBQs= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=google header.b=BCQoXEwH; dmarc=pass (policy=none) header.from=linuxfoundation.org; spf=pass (imf25.hostedemail.com: domain of skhan@linuxfoundation.org designates 209.85.166.182 as permitted sender) smtp.mailfrom=skhan@linuxfoundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1727996668; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=M6nfuUKflXlu0gy64XrlY7jGUy2rKVA8VyjGUfxntcw=; b=fAb1U2c8F7cEluf1jsyF9QSEzrDx5OfCPfdfrspPyCMKdPbjuNVVuqUFdAj1idfqsqSbvC RC7fmc4oqLLqTT01JcvwzQJtCKsn4o+FfZHrQaIxxdymgKLR2vXj+CHbGlSkmsbw4XeLSv 4Fy7IjybibtJknVCTUMggyKVrtJSTsM= Received: by mail-il1-f182.google.com with SMTP id e9e14a558f8ab-3a27638f868so5934435ab.2 for ; Thu, 03 Oct 2024 16:04:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; t=1727996690; x=1728601490; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=M6nfuUKflXlu0gy64XrlY7jGUy2rKVA8VyjGUfxntcw=; b=BCQoXEwHeiPE+Y0vsY+TWLKbS5RYV3hrGRrEXHsLDze04RuNmm6KSWUjHlPXbaCNwn odvp9I6Kp7c6NJj5Q5Uw84ls3fQefeeyCuG4DZCEJR1Q+WQRipvoSC8eDOdu3XOdF0eG WPU5aGvzlTkwXTOk9mlEOe6Is4uOwxVokNBbk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727996690; x=1728601490; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=M6nfuUKflXlu0gy64XrlY7jGUy2rKVA8VyjGUfxntcw=; b=kqfE73d5xdAmEvDtD89NBnqSCY/WI4iJ/JxAM9lUyXS0UtKvQulxywelC2k4xrwxdR s1kXYzlxpxWaITq2GyFBqfh5yEW6Bmv1wkKNmxXgsUzhq0jgB4luIXA3HuV0cn8bENIh YcU5xTpv8cpkVH+1LsJLon7xrItK7UZM6ZSDdXm6mJMhQ9wxUG4hdYTjIXwBlFz2VzIV EODVwULIqtiiIGEJ3gjtOzCbDSiIO6dSZLncSoPan/RA2bd1iiCL8SILkjRkBVI2Y7In YuqWSSq0VcK7F+3vV1WJVx5shVzWHZ42pb6XcQ3QONNKZMwfoniMSULIDrD8XIqEdH0f 3G3w== X-Forwarded-Encrypted: i=1; AJvYcCWpWrKrHitZxeFxtc+V+9j40ephbQWZCFWuHqvyWI04DlDBE1SSIprCAs/SzOf8RELc2R0HMXeO0Q==@kvack.org X-Gm-Message-State: AOJu0YxOLhaYhlIVMaODgdbbFFE0G7WM3WUZ1F0O7wgWWiERlJlEv7Io OmygaDc6alNruN/XTVW19ExmGsmrjHt2ZYNcWjypGWMfkp/7vMmXh1V//0k+h+k= X-Google-Smtp-Source: AGHT+IEf92eF4XbI75+DDch6LT1NVeo6TRIQ29YwXnjI+iDeNTTSz8c4ISNOJ8P9ysseWA+UZhFJyQ== X-Received: by 2002:a05:6e02:214d:b0:3a0:480c:6ac4 with SMTP id e9e14a558f8ab-3a375bd323emr8671095ab.22.1727996690235; Thu, 03 Oct 2024 16:04:50 -0700 (PDT) Received: from [192.168.1.128] ([38.175.170.29]) by smtp.gmail.com with ESMTPSA id 8926c6da1cb9f-4db5585f2ebsm482149173.4.2024.10.03.16.04.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 03 Oct 2024 16:04:49 -0700 (PDT) Message-ID: Date: Thu, 3 Oct 2024 17:04:48 -0600 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 33/33] kselftest/riscv: kselftest for user mode cfi To: Mark Brown Cc: Deepak Gupta , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Andrew Morton , "Liam R. Howlett" , Vlastimil Babka , Lorenzo Stoakes , Paul Walmsley , Palmer Dabbelt , Albert Ou , Conor Dooley , Rob Herring , Krzysztof Kozlowski , Arnd Bergmann , Christian Brauner , Peter Zijlstra , Oleg Nesterov , Eric Biederman , Kees Cook , Jonathan Corbet , Shuah Khan , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-riscv@lists.infradead.org, devicetree@vger.kernel.org, linux-arch@vger.kernel.org, linux-doc@vger.kernel.org, linux-kselftest@vger.kernel.org, alistair.francis@wdc.com, richard.henderson@linaro.org, jim.shu@sifive.com, andybnac@gmail.com, kito.cheng@sifive.com, charlie@rivosinc.com, atishp@rivosinc.com, evan@rivosinc.com, cleger@rivosinc.com, alexghiti@rivosinc.com, samitolvanen@google.com, rick.p.edgecombe@intel.com, Shuah Khan References: <20241001-v5_user_cfi_series-v1-0-3ba65b6e550f@rivosinc.com> <20241001-v5_user_cfi_series-v1-33-3ba65b6e550f@rivosinc.com> Content-Language: en-US From: Shuah Khan In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Stat-Signature: tzpm9y3uqrqazx4putdmdjw6d8zibd8p X-Rspamd-Queue-Id: 4F93BA0007 X-Rspamd-Server: rspam02 X-HE-Tag: 1727996691-165377 X-HE-Meta: U2FsdGVkX19oYYFYUecM94uASSNTHBqUe9l+IclzgQDvgSW/O7nz9r/hI+QTciWSJWaJTRrPN9yN4M39OenjGWfClq0ZcLGPF+L3JN4OHFg2x8CdUCNQNkLEiW8kbyTQzwUZAx38JO0DwDhPNISP+8Nd8n3Gcz+pVU8+Um+pZRe4+ijX/8Iw+EX7l7uLcADobnLAZpFgnTt4shxN+PbNbrk2G25oLp2yj2jUnZYjpuEujczBV6B7aEZqJx/j/FFXAD9qAkH6yYMEkqBy78BDkp014MtRX6gQ4urPTysZsdSbmrbRc2m8PXkA3pOLyHZhdT2Jx9kUGEZW2ukILioxBlK84CZ90YhgNevEJLE3YyCKuvjuo4ZQybZvMMzu8nnxji+3mrYe7BWkhJC2T6hJtIAlYCC3yFnPS1LVgIguYXrtB3cgt42tuAhCj7tffhxrWCvjN+uLq91lO4JcKxCoSdVlp03FTe1b+lFrMjF4paX2ZC+3oea/zZNBZDQm3kaWKvMQYVqmBUiwjSstxcNaLfmqgy9eYbA+3L8RB6TuElJIvu7f/VPfxwsC49s4Et0x0k8BdgOqAeDc3F3l4wgxP2YbA9s+BH/AZw0cbg3KtyH+QN+yHTfCEzJQCdoy3WNdsNBhTzGxTD/zNzfUC7xwSdQCrDb3xhuWNoX9Sd5oz7inOZCjU9T+S0IHHqfKZ4wxXWoaLtTpA1KTzyNJiL37iiC0aDCorS35rCr9vppQJiZ7gE3mrCxdzggaTGpVu28OHqPTqM4jsTW1lP0SkbZJGI0jwEXP8MBjVZUo2zc8NmbK4oH7Kssi/JgS9EEsCJYE9ypwWC0YRcVu3OdpYzo6dlKDtursvyIwhwC4wLHYVfzct14aR+9NHnHQ+/AKRCVCyaofoCfv0Ix9Z5dW1RnzkuiUSipj1ZyMe7k/UDa6CvVm+YZEcssjDf0SV8TIzjjZnhpFUi0LPFfuHfo7kvV QUYrQ/xh GOtJj1UIaQqz0NMYhi8uwTqAlm3a/bUyyz2L7frHoGiDTiRO/qKPy2JmWpRfBaq4e0sIarxPpPhD+UNeR3pSq3bw6uWKxXmY/ssNjnwg6hgSExJsP73Fi3SxCQawjPiJdW0TvhaY8M+E44NhLCO2FYjuGzMW0VCsN7+PwoVmt3OfqvKaQKeQ++S3DzwE6f6N5w1uCiCqfHJU8AaB3vq66la+D+LnNj4dNJbh/hMfQf+M8jn5JSLuKRERAAb7HYoA7DHdsjBZVfieqQ8AQpln+NVeX4Q9yop4tzRAUWiR6JjAKqJUoXCDCPzuCzXtrf3E6KXlt6xnfW2ZIO9D7XS+4zvnakGWtZ4MpnObbzCv6XXA+7qMiyHu5PFP+9ogWo4CXwaRD2SWjxgfMBEoXBkmFHDoLettzQsGe6Pju83V5hig9MLc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 10/3/24 05:03, Mark Brown wrote: > On Wed, Oct 02, 2024 at 05:18:36PM -0600, Shuah Khan wrote: >> On 10/1/24 10:06, Deepak Gupta wrote: > >>> +#ifndef __NR_prctl >>> +#define __NR_prctl 167 >>> +#endif > >>> +#ifndef __NR_map_shadow_stack >>> +#define __NR_map_shadow_stack 453 > >> Why do we need to define these? Shouldn't including >> asm-generic/unistd.h sufficient? > > We have this issue on arm64 as well, there's some issue with directly > pulling in the asm header interfering with libc in some situation (I > can't immediately figure out which situation or which libc to remind > myself what it is though...) so we've got local defines like we do for > the NT_ defines for ptrace. I see x86 is doing the same. It would be nice to figure. There have been some issues reported due to local defines - the test fails if the define happens to not match. Does including fix the problem? thanks, -- Shuah