From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 88A93C5478C for ; Mon, 26 Feb 2024 08:32:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D6A4D6B0092; Mon, 26 Feb 2024 03:32:19 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D1A796B0096; Mon, 26 Feb 2024 03:32:19 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BE2FF6B0098; Mon, 26 Feb 2024 03:32:19 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id AEAF36B0092 for ; Mon, 26 Feb 2024 03:32:19 -0500 (EST) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 55C161601F9 for ; Mon, 26 Feb 2024 08:32:19 +0000 (UTC) X-FDA: 81833287998.18.E1B9E2D Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf08.hostedemail.com (Postfix) with ESMTP id 0D54216000D for ; Mon, 26 Feb 2024 08:32:16 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b="oX1QNv/s"; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=kVXS+5AQ; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=Pa6N4nXt; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=6T2U4WS+; spf=pass (imf08.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708936337; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=JyXqqDQ2t8ePG++k2k0I3bejH0Ru+OjYUizfw98W8JI=; b=nigGgF2M1fY7kauRiWQU+TinpAtZKk4AwJmaJT59fO2HfYnbZa0gdnoZa8sDnPeMKPdSw7 lADjZLIXcPGgIVCwKZOprjokXvss1s0j0ISbktHmk4T3QHJpvZ4DG+TMallVevmDM/rfBU FZfhQ8wZXEB/Yi/sNFHuAmz0zCwuWRY= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708936337; a=rsa-sha256; cv=none; b=8MDE7t3HvMmi+5VrR0VAat4fBSa/iwUGLmT/wsITV6z0cySFfIDOXxZLgpnbstCgYseCVm ofL3wilCrveGjTnUyWzyf29XPL/IE7lzPkk+6kZe7thMEVJGA1Jd1lBugN1MGwXDEuyUQe QOJztSSJcWT4yl1z/Xrvp33aGrR5u40= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b="oX1QNv/s"; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=kVXS+5AQ; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=Pa6N4nXt; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=6T2U4WS+; spf=pass (imf08.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id C980B1F911; Mon, 26 Feb 2024 08:32:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1708936333; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=JyXqqDQ2t8ePG++k2k0I3bejH0Ru+OjYUizfw98W8JI=; b=oX1QNv/s+OMiW+SxXCMZIsDsHvnifJyIx5BVVRWnaN/4Vy3m2JkCiClnoWtfB54mFDHiaB BJohmwiZsnOD9bUIldBaAOsyhx301u07w9ncLstXd5ufsFSNyRp2w46HnGs2pXSgreKcEy ks6L8h/VQdR8vFG0UyuEnMNWuDrgqw4= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1708936333; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=JyXqqDQ2t8ePG++k2k0I3bejH0Ru+OjYUizfw98W8JI=; b=kVXS+5AQywkgJ9EDUzh2zOQHBdvctwRgUTTG2JxyfvrOdGUIvQU3FtdJrmZNZlviJlpZVF iqfeoQRO6tTs4VBg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1708936332; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=JyXqqDQ2t8ePG++k2k0I3bejH0Ru+OjYUizfw98W8JI=; b=Pa6N4nXtUw4v1BPnCvq1WsAST1pWYpiXckWmtHPaXoJgOBieI3Vp5AYTkF+HYuHXlYOfBY U8F0SsCn/NE2yEO2UyOaPz/WCLAsxjyOSsA64eGVCK6TbICAXFZZZ99H/LYAUOxXJ1acrK NHmw34aaYu3llC/PTZaNswdFxoXFfJI= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1708936332; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=JyXqqDQ2t8ePG++k2k0I3bejH0Ru+OjYUizfw98W8JI=; b=6T2U4WS+HjgY1KoJJdHz5U6Uvzn3CX5ln+t5kEcZF0/4srMecPsI83y3UtOUCb+MXqfjwG CRTFw/hq+Np9EFDg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id B1F5E13A58; Mon, 26 Feb 2024 08:32:12 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id hkcYK4xM3GVOEgAAD6G6ig (envelope-from ); Mon, 26 Feb 2024 08:32:12 +0000 Message-ID: Date: Mon, 26 Feb 2024 09:32:12 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] ceph: remove SLAB_MEM_SPREAD flag usage To: Xiubo Li , Chengming Zhou , idryomov@gmail.com, jlayton@kernel.org Cc: ceph-devel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, roman.gushchin@linux.dev, Xiongwei.Song@windriver.com, Chengming Zhou References: <20240224134715.829225-1-chengming.zhou@linux.dev> <35df81f5-feac-4373-87a3-d3a27ba9c9d4@redhat.com> <82c2553f-822e-40c2-9bf8-433689b3669d@linux.dev> <69589d2f-978d-4d14-9e5f-6bd6b3a43062@redhat.com> Content-Language: en-US From: Vlastimil Babka In-Reply-To: <69589d2f-978d-4d14-9e5f-6bd6b3a43062@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Stat-Signature: uex8p6awiiajf5fcre7owex64amfugko X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 0D54216000D X-Rspam-User: X-HE-Tag: 1708936336-512774 X-HE-Meta: U2FsdGVkX19xtP4dgPKrVDaOYDPSalIYLq50crMbSn9f0Fj3v1iu2Y565EbPTx+yl9IO4iwL2Re/+Qx5VaJHRyeI5xgrsjI459mdoc5Wn1fhq5Y8ahZ8CVQreGD9MCYhdi3CdxyMRnGcIgaT9XJXIzMrA9BY0jEkZNa8HkTC8HUhwoC6LOZGa6giUOdtTfrq02bacMTbB2SROcP6pYU0YsO1CZIQPYjeDJMBe8pC9bNlYdvpiN5yloTGst5kIiHzq1YVXyRlP5YZYPSSwRNiVlBbvnyheI7ahhsTCVWBhYhAwffMHGig2J/CVHa24YOMaU5JLi3idgTNC93lffmsOrKDPHsVYHMJmdhMcs298vKfkU0ozwrA/ImYq43QG+NYa4BKF+ISzjqhL8WK/w9ps5QO5nDAsAr9tDYUpuGeY8UXE14mj/+hUcHOx38HWEnY6kvJ1QztNnQNu5oLgY2lpMKJwyHUwtO/8qnMS/VbKzejHH9oQmXLwPJTJBq/g0e0Mt99AOdzIEvXfmin6fgLUKPMWkNoEDUwBHq1cZKMxkQdqWEwZuNGGpywkHHqNGKnMjZ/tRAAcfbAYw6EYFvXR7wLaD3iuCSavWwXKiPfEFS3i0E2sBAaQx497EREuW8cFIm1rBh/1cYPtgJ9gV82+gfgBP0oNI6lSlbhTTRMsAE9ZUsZMLVyXVH/I0Pxrr5sLHccfWpMNw8TYJNYmcGTtvEEEPNcsVxZnBtecitdTnXwdyZPLGs+AXyp43qjk4ohV/ZgwZKntD4Kgl6hY9fPaXvP1rhi+imiN+9oUh7V9w83Xyu1xDWyi88UgJ2fcrgJOuliESeogL3uzF621W7wfoWeXIDDvIr3NDLYM56IUcsgzgQrrv9Q2+m9sfymecV21wrAMhuFbg/2iIEUeRGXCQgxIxb1Som0hxddenH769STAW6gsFsoC1bVeJP0IXXJD9REUp6BAl0VT4XoJSu bY4ZqBOr 3RrX9n0Z8U0kkPzU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2/26/24 05:54, Xiubo Li wrote: > > On 2/26/24 12:30, Chengming Zhou wrote: >> On 2024/2/26 12:23, Xiubo Li wrote: >>> On 2/26/24 10:42, Chengming Zhou wrote: >>>> On 2024/2/26 09:43, Xiubo Li wrote: >>>>> Hi Chengming, >>>>> >>>>> Thanks for your patch. >>>>> >>>>> BTW, could you share the link of the relevant patches to mark this a no-op ? >>>> Update changelog to make it clearer: >>>> >>>> The SLAB_MEM_SPREAD flag used to be implemented in SLAB, which was >>>> removed as of v6.8-rc1, so it became a dead flag. And the series[1] >>>> went on to mark it obsolete to avoid confusion for users. Here we >>>> can just remove all its users, which has no functional change. >>>> >>>> [1] https://lore.kernel.org/all/20240223-slab-cleanup-flags-v2-1-02f1753e8303@suse.cz/ >>> Thanks for your quick feedback. >>> >>> BTW, I couldn't find this change in Linus' tree in the master and even the v6.8-rc1 tag, please see https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/include/linux/slab.h?h=master. >>> >>> Did I miss something ? Or has this patch been merged ? >> You're right, this patch hasn't been merged. But it's already a dead flag as of v6.8-rc1. >> >> Update changelog to make it clearer: >> >> The SLAB_MEM_SPREAD flag used to be implemented in SLAB, which was >> removed as of v6.8-rc1, so it became a dead flag since the commit >> 16a1d968358a ("mm/slab: remove mm/slab.c and slab_def.h"). And the >> series[1] went on to mark it obsolete to avoid confusion for users. >> Here we can just remove all its users, which has no functional change. >> >> [1] https://lore.kernel.org/all/20240223-slab-cleanup-flags-v2-1-02f1753e8303@suse.cz/ >> >> Does this look clearer to you? I can improve it if there is still confusion. > > Yeah, much clearer, thanks! > > Maybe we should just wait for the [1] to get merged first ? It's really not necessary to wait, [1] just makes it explicit but the flag is really effectively dead since v6.8-rc1 because nothing acts on it.