From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0111BCD6114 for ; Mon, 9 Oct 2023 17:28:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 86FDE8002F; Mon, 9 Oct 2023 13:28:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7F8BD80027; Mon, 9 Oct 2023 13:28:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 69A148002F; Mon, 9 Oct 2023 13:28:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 57A9680027 for ; Mon, 9 Oct 2023 13:28:35 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 2187B1CA96F for ; Mon, 9 Oct 2023 17:28:35 +0000 (UTC) X-FDA: 81326607390.29.EF56529 Received: from mail-io1-f48.google.com (mail-io1-f48.google.com [209.85.166.48]) by imf21.hostedemail.com (Postfix) with ESMTP id 2A0AC1C0013 for ; Mon, 9 Oct 2023 17:28:32 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=google header.b="Bnt91/nz"; dmarc=pass (policy=none) header.from=linuxfoundation.org; spf=pass (imf21.hostedemail.com: domain of skhan@linuxfoundation.org designates 209.85.166.48 as permitted sender) smtp.mailfrom=skhan@linuxfoundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1696872513; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=7BjVxNp/YRM5k6f5csMN7Rbql0PbCwEA0Qhwm+7n1+k=; b=HqIZ5hHhggVcEX986q8G1aFWOuk9Xo6obI4ITncFpbbH4qrgSiGef6cxU62WW2HHI2yKkE ZVXGO6QoMnWHaGgZDV98Eh61hjbmpORRqC2z45QZ9KQxXFCl1sIOHZ/+B8W/CJ0jEX5FuZ cfhPWZSNg4M+LTWf5TT5ajrb3s4IBxQ= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=google header.b="Bnt91/nz"; dmarc=pass (policy=none) header.from=linuxfoundation.org; spf=pass (imf21.hostedemail.com: domain of skhan@linuxfoundation.org designates 209.85.166.48 as permitted sender) smtp.mailfrom=skhan@linuxfoundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1696872513; a=rsa-sha256; cv=none; b=6MdpQK/u8mhphFP4mQcbjeTUNf6rrziFUvobBTWm5wtBV15lm0t4Bv9o85Jx4tf6rNyvPX RFVvBU9hGrSMVCUY2u24r0ZH/7swlCyQkLiBiYmPD9q3yZoBElBmNjpplTa9zGKJoscUiF fpFg+A7z54d5FS8/AdnRLBXsX+C5WXE= Received: by mail-io1-f48.google.com with SMTP id ca18e2360f4ac-7a2874d2820so59435439f.1 for ; Mon, 09 Oct 2023 10:28:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; t=1696872512; x=1697477312; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=7BjVxNp/YRM5k6f5csMN7Rbql0PbCwEA0Qhwm+7n1+k=; b=Bnt91/nzbSgQQiIK6V4veJbU7/w2HVXJJFn6ma0FGKSK7HceyGtUNwdGYs1USKrhjf cj2vhzu1oeG06IJvMqGtWvPtBqK2PzEwJz++fVX6Obbk5OpCIJFcWqpNI9cU5QjJPwGl S8HRDNvQw7hs8vUTb6rE6iriwU3ItheSzL1RA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696872512; x=1697477312; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=7BjVxNp/YRM5k6f5csMN7Rbql0PbCwEA0Qhwm+7n1+k=; b=SmvodUx+MtT9KUvLCBrcjUWlH8EoiVSzhkEE/PHAhdy9L85fKKojzIij0LPtdAzvTX RSadAlPwl0ZACgb/ZYqvtqBxnw0TWeT42k1WMTBpBckFe9AZJGGG9Cs22cEQLPgVg3VW rinjFapmNNtA6y8Fzw1ezbfE34Qnjq+Rb5wnD/yiYEIi/Zx+Z55vbZaYI6YPSrwNkp2S 0oH117UxdsQ7Wx01IG48/tVcvozMzOMKXt8BbAZHDxCfsB3PCUy1xoYW/6SpHEG+1JmG jnbBI59vgopErP1JEHy7sKqGpq8kORsPLmqa9WsXTxQAVZ4vkyV/nuLPpsIXfwMWEI4D QVwg== X-Gm-Message-State: AOJu0YxLIZrcBLiavmTEFdtEtr7VCWb45SMKimaIAKrZjArB/WdRTimp YUEMrOHVJxCUJnVHsBXa2qyK+w== X-Google-Smtp-Source: AGHT+IG524RLm2iNS7rGqigma7E7MkPPDCMafw1IlVfCC2AnEpocWiOhD+/3WH5nhUw39rAm0J1f0A== X-Received: by 2002:a6b:5a0a:0:b0:790:958e:a667 with SMTP id o10-20020a6b5a0a000000b00790958ea667mr15344414iob.2.1696872512138; Mon, 09 Oct 2023 10:28:32 -0700 (PDT) Received: from [192.168.1.128] ([38.15.45.1]) by smtp.gmail.com with ESMTPSA id fx23-20020a0566381e1700b0042b47e8869bsm2242289jab.49.2023.10.09.10.28.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 09 Oct 2023 10:28:31 -0700 (PDT) Message-ID: Date: Mon, 9 Oct 2023 11:28:30 -0600 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 0/8] Add printf attribute to kselftest functions Content-Language: en-US To: Maciej Wieczor-Retman , akpm@linux-foundation.org, christian@kellner.me, fenghua.yu@intel.com, keescook@chromium.org, ndesaulniers@google.com, coltonlewis@google.com, dmatlack@google.com, vipinsh@google.com, seanjc@google.com, brauner@kernel.org, pbonzini@redhat.com, shuah@kernel.org, hannes@cmpxchg.org, nphamcs@gmail.com, reinette.chatre@intel.com Cc: ilpo.jarvinen@linux.intel.com, linux-kselftest@vger.kernel.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Shuah Khan References: From: Shuah Khan In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 2A0AC1C0013 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: cnoefd4zsxmxiwix36ogd3m9nk5o5ydc X-HE-Tag: 1696872512-20359 X-HE-Meta: U2FsdGVkX1+jH061M99ZU2c6OEUBsy1Ih4SRpQ+pxIzVGmefLyrAZgTzXQXShrlDJUebACeBhGGXZN9kpCsgtawVV9b3xoLcS2zsnc/pL0yv+bmKiK91GuAro11FDlLJfAsNXff+c0OFbnifqSpx18R0UjwG/teuIIMn+BoZIxPWOx1bUL43THlsteO38DNPneO036AUMTrkkQ4kqzO62nH82Pb8o1kXOWjycUoAE7loNOGl8E/Dtb4BrrC1h/+EAsAOo4GOuFI1O9bZTUYIPDjxy4pSHlRTSqGtQW55E/5Oreaf6dAIyQqMsP2Fti4japvaz14fyU4S580T6XITxTFCwNRXljr6Ml6oL6yljb8f3A/H2s9+yrq3WS9kxal+qNz9Vwsqo25gWZJGf3i3Km/l1RyTkgx9qwKeU324S1JL6MigQL3m/myLiZ+oOTaGwRfQj3aV56UifQ461er76h+WMqUsrpt0z2kC7fAoBilMjTVeIsEUFSDiaF44aNR6wOlrykHercDM3a0bmtb9Pg6uo8jQEMeTESoeobcxxFGd+uois7PHm/EJqJHCnxDshdctFb+1GiXYQwMjuM4+/J/XI9ijEXJo3aAryL/wMGThHluuMTMoiGIBIGW6CjHUrgwi4T/xw94leQKkMYP9O5MchjvljmNuc4hHgf/RFX089IeeeG1C9sAjOMZsmMSzy2xZoz7aGCDI+9Zvf1Qms6FWBLgycYKk/EzjGrhKdbAW26X6N7Mjl4RurX7EulzmPa3t4qzAXWplRuvZsYnOSM4Sz2SutLeJN4PYUsPDQIYJHhFNWkOqT1Z0B2bbPU8CJDbVo4f7I4GAsKRZ5CI2MMRWNFAfBJBWj4t+8/L0Z+LqH5aZDVoRg73BerVtrzn0uMJTHKf4piP1FLOB6V9NN9A0rFWf7tAB/Lt0sP5zd7la5IcSeKxzOHYSrX2CStYeMatA1e8g3WuEkl9j5C0 jzR6SKq2 0N0LPEsAr2pZf5MONcqY4RwRmqmjewvqKDq5IRY+6LJRBqhUjbzZfBNLdg0CziCf7LDSWaUyrCXGVLj0OpWKfp5DyTeAPXat5aDz8EXxirBG1U4MITdWxdozckGEqqSpBMfd9pfG8VNy3G2S5Z3YgHledFpBIJLY2OBNrvmcomxdyj1KYg5Ihk+xWjlvnT3mrR9eKyCzIAEinLct0DAIjftd/rgJ0EQKJnLkcArIiA8MvK+xNDLemCBpHRSxAyERXKVgbHK+p41OxAMtzrCW0098EiuMdTmaWIQU5e2P2GrlcNjThJFQP2Wuz2R5fASe71LoRvF12X7tWGu+IXVyWhQT3wr0MtAAIcfOcMbcnSMNkE0kiIQo4ieOh7ITyZviBv4a59NiSP7ArfB9WvRMxgr4LOoAUrrMQH2W/OwsYTjAqRZI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 10/9/23 04:28, Maciej Wieczor-Retman wrote: > Kselftest.h declares many variadic functions that can print some > formatted message while also executing selftest logic. These > declarations don't have any compiler mechanism to verify if passed > arguments are valid in comparison with format specifiers used in > printf() calls. > > Attribute addition can make debugging easier, the code more consistent > and prevent mismatched or missing variables. > > Add a __printf() macro that validates types of variables passed to the > format string. The macro is similarly used in other tools in the kernel. > > Add __printf() attributes to function definitions inside kselftest.h that > use printing. > > Adding the __printf() macro exposes some mismatches in format strings > across different selftests. > > Fix the mismatched format specifiers in multiple tests. > > Series is based on kselftests next branch. How did you find these problems? I don't see any information how these problems are found in the commit logs. thanks, -- Shuah