From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5DA40C54E49 for ; Mon, 11 Mar 2024 01:52:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B9C346B0078; Sun, 10 Mar 2024 21:52:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B4BD16B007B; Sun, 10 Mar 2024 21:52:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A132F6B007D; Sun, 10 Mar 2024 21:52:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 8CCD06B0078 for ; Sun, 10 Mar 2024 21:52:07 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 2F358120450 for ; Mon, 11 Mar 2024 01:52:07 +0000 (UTC) X-FDA: 81883082694.23.CA78472 Received: from szxga04-in.huawei.com (szxga04-in.huawei.com [45.249.212.190]) by imf15.hostedemail.com (Postfix) with ESMTP id 66871A0008 for ; Mon, 11 Mar 2024 01:52:03 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf15.hostedemail.com: domain of liushixin2@huawei.com designates 45.249.212.190 as permitted sender) smtp.mailfrom=liushixin2@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1710121925; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=IVePNPtQdat/mnDb4KXD6rDrLocWZAo4xfweA7tqW7I=; b=idEiwQqKKtAtYnMWvGfOws0fWfzrRqyXPpVL2Z3ov2/BqpH7r6iiAsQ4qpY3JHp0hZuCGs J9XGAN91/w2wJnthsZCaDP7hOIFxI8eyRe2iO4qdLgM/VJ+UdrHIPd868b2B1PvfTe9DIT QRBcYtrLQe5cUy5hw/nXVZYDZayJiZA= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf15.hostedemail.com: domain of liushixin2@huawei.com designates 45.249.212.190 as permitted sender) smtp.mailfrom=liushixin2@huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1710121925; a=rsa-sha256; cv=none; b=isPCI7NgJfiS4jhtf4oIUuSwmkDvjBAzuH88BWXXox5dH+EniLEQWsGRva1NHhi1BNFv1V rILQ0cMKfGK1GhgSElM9MgQW5+kJMHSeWtvbcVbF5FNPprh7UIaCMubTPeMaqkRaHlbBWc PaZnJaxctakBpS6UsrKVl9AW9X0WNV0= Received: from mail.maildlp.com (unknown [172.19.163.17]) by szxga04-in.huawei.com (SkyGuard) with ESMTP id 4TtKT80PTJz2BfpM; Mon, 11 Mar 2024 09:49:32 +0800 (CST) Received: from dggpemd200004.china.huawei.com (unknown [7.185.36.141]) by mail.maildlp.com (Postfix) with ESMTPS id 4177A1A0172; Mon, 11 Mar 2024 09:51:57 +0800 (CST) Received: from [10.174.179.24] (10.174.179.24) by dggpemd200004.china.huawei.com (7.185.36.141) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1258.28; Mon, 11 Mar 2024 09:51:56 +0800 Subject: Re: [PATCH stable-5.10] mm/memory-failure: fix an incorrect use of tail pages To: Greg Kroah-Hartman References: <20240307124841.2838010-1-liushixin2@huawei.com> CC: Matthew Wilcox , Andrew Morton , Sasha Levin , Dan Williams , Naoya Horiguchi , , , From: Liu Shixin Message-ID: Date: Mon, 11 Mar 2024 09:51:56 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 MIME-Version: 1.0 In-Reply-To: <20240307124841.2838010-1-liushixin2@huawei.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.179.24] X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To dggpemd200004.china.huawei.com (7.185.36.141) X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 66871A0008 X-Stat-Signature: mcuis95ygp8quzs9rwfk54kpygnb8k4w X-Rspam-User: X-HE-Tag: 1710121923-203509 X-HE-Meta: U2FsdGVkX1/5C3vuCDMUj0A/hSz9MqsbmW9csi1dMfF2L2prKFnMdBml3AQ07SbZ8Q8yLg3B7j+mwfTTKc6h6HTfCNjsBnaoYYTS4W4DQIkLe0VXfgwqsLXKdJYp+ui3uQ8VkeZcVrOw9+xPXbHRd42AEIiaA70lf0rv+aLelCAJrwnJQ0t14m19IpiFdB8FZPEkro5neiuQe4pLEqt/A8Y+bVTFvNSrrzrnVyAqRvMAifOS4VyCOcKMAuKNN8cyKc/OwkhDj1Pr2EiabFRKydiSd9y42LKKeZiNKV/gemXcbCiRH7pp+3YsM+HJiMfNfFV/wtbhftbe5L3mMQ+L6zcOSuTQPXE273Apk0X4KNzCuVFq0yzZgzck4niDkIsNHKDI04VcQ+IC7yLG8ZaT+fML7w16L2UoRXw5uwlCOdMWmV+99s0JK4pNadNI5oMWnMmxt2xwNoLv7nBT3eisilGNxmgFePgEkJYEF31Cv1nDoH/knwDmcCS2xafqWU2YmVjWOJzX0KnNOSxfdHYK/GAqjJCGIe2MIYFlG1EupLM5OkeRM5mfZXIJFpVYikHvFcOR1BKWN4RRUNJPBWPObdfL8Kv8wSe5qQmpjvVnuMgtY7A5hPdoiilXYeWzIj8FFN1KQe6LNct60CU50Fm8Rf1+upLE3rPAw6+xMe7gV88jBw6iufMHOLG8Rqg06CJCZ/Goai3P99erHtJhfjJqzCVHB8IxOV2mTSz5s9QNMcCyAJ2vbQrAiAuE2RnH9dHx5RWdENXJXxccloNCxmWN7RkRz18mdkEi7eB5txpaHMaB65B/3gB6dA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi, Greg, There is a bugfix for 5.10-stable, 5.4-stable, 4.19-stable. Introduced when backport commit c79c5a0a00a9 ("mm/memory-failure: check the mapcount of the precise page"). [1]: https://lore.kernel.org/stable/20240307124841.2838010-1-liushixin2@huawei.com/ [2]: https://lore.kernel.org/stable/20240307125053.2847205-1-liushixin2@huawei.com/ [3]: https://lore.kernel.org/stable/20240307125150.2849068-1-liushixin2@huawei.com/ Thanks, On 2024/3/7 20:48, Liu Shixin wrote: > When backport commit c79c5a0a00a9 to 5.10-stable, there is a mistake change. > The head page instead of tail page should be passed to try_to_unmap(), > otherwise unmap will failed as follows. > > Memory failure: 0x121c10: failed to unmap page (mapcount=1) > Memory failure: 0x121c10: recovery action for unmapping failed page: Ignored > > Fixes: 70168fdc743b ("mm/memory-failure: check the mapcount of the precise page") > Signed-off-by: Liu Shixin > --- > mm/memory-failure.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/memory-failure.c b/mm/memory-failure.c > index f320ff02cc19..dba2936292cf 100644 > --- a/mm/memory-failure.c > +++ b/mm/memory-failure.c > @@ -1075,7 +1075,7 @@ static bool hwpoison_user_mappings(struct page *p, unsigned long pfn, > unmap_success = false; > } > } else { > - unmap_success = try_to_unmap(p, ttu); > + unmap_success = try_to_unmap(hpage, ttu); > } > } > if (!unmap_success)